unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: Emacs Development <Emacs-devel@gnu.org>
Subject: Re: master 1d4862e: Fix English grammar in some doc strings and comments
Date: Fri, 8 Nov 2019 13:31:01 -0800	[thread overview]
Message-ID: <d2dcc649-0ded-07da-346b-b41eac4e943d@cs.ucla.edu> (raw)
In-Reply-To: <CAAeL0SQ-oX=uqFJ4X34YfHu86-=C26cEkQdAKF9gVoyWg4MWPw@mail.gmail.com>

On 11/7/19 8:24 PM, Juanma Barranquero wrote:
>> -This function only handles buffers that are visiting files.
>> +This function handles only buffers that are visiting files.

> there's no additional clarity. It could also be argued that, in those cases
> where the result is less natural-sounding it diminishes clarity,

I'm not aware of any such cases. To my ear, the revised text in the example you 
gave is just as natural-sounding as the original. I agree that we shouldn't be 
pedantic about "only" in places where that would reduce clarity.

I'm willing to put up with these less-important changes, if consistent use of 
the style helps to fix confusion elsewhere (as that patch did). It's akin to 
preferring signed to unsigned arithmetic in C code - even in places where this 
makes no real difference - because being reasonably consistent about preferring 
signed arithmetic helps makes Emacs more reliable overall.



  reply	other threads:[~2019-11-08 21:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20191104023801.20244.67873@vcs0.savannah.gnu.org>
     [not found] ` <20191104023803.36ABA20A3C@vcs0.savannah.gnu.org>
2019-11-04 12:51   ` master 1d4862e: Fix English grammar in some doc strings and comments Juanma Barranquero
2019-11-04 17:21     ` Stephen Gildea
2019-11-04 20:33       ` Joost Kremers
2019-11-04 21:37         ` Juanma Barranquero
2019-11-04 21:47           ` Stephen Berman
2019-11-04 22:03             ` Juanma Barranquero
2019-11-06  3:28             ` Richard Stallman
2019-11-07 10:47               ` Juanma Barranquero
2019-11-07 19:32                 ` Richard Stallman
2019-11-07 19:55                   ` Lars Ingebrigtsen
2019-11-08  3:35                     ` Paul Eggert
2019-11-08  4:24                       ` Juanma Barranquero
2019-11-08 21:31                         ` Paul Eggert [this message]
2019-11-08 21:51                           ` Juanma Barranquero
2019-11-08  4:33                       ` Lars Ingebrigtsen
2019-11-09  3:31                     ` Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d2dcc649-0ded-07da-346b-b41eac4e943d@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=Emacs-devel@gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).