From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2) Date: Tue, 11 May 2021 21:46:17 +0200 Message-ID: References: <0bbdeece-90d5-160c-07ec-2ad8edbf9872@daniel-mendler.de> <87czudm7bv.fsf@mail.linkov.net> <976056e8-3d46-db27-32c2-ddf3ca32d5a7@daniel-mendler.de> <878s5090e9.fsf@mail.linkov.net> <69fd42ed-a1a0-adcb-ac8b-caad80cb0967@daniel-mendler.de> <878s4zzpvc.fsf@mail.linkov.net> <95ac7ef3-5e8c-fc58-b316-544096c82aa0@daniel-mendler.de> <87o8dus00b.fsf@mail.linkov.net> <6718c89f-88a0-b529-1676-7e89fc152f00@daniel-mendler.de> <878s4w3law.fsf@mail.linkov.net> <87sg2ymq6j.fsf@mail.linkov.net> <87r1ifpyuc.fsf@mail.linkov.net> <83eeef7nzh.fsf@gnu.org> <87eeed2l0q.fsf@mail.linkov.net> <83o8dh3ybw.fsf@gnu.org> <854d8dbc-b64c-77e1-843b-95ac19e230e2@daniel-mendler.de> <83h7j93wjg.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34556"; mail-complaints-to="usenet@ciao.gmane.io" Cc: gregory@heytings.org, dgutov@yandex.ru, emacs-devel@gnu.org, monnier@iro.umontreal.ca, juri@linkov.net To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue May 11 21:47:12 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lgYLY-0008si-3e for ged-emacs-devel@m.gmane-mx.org; Tue, 11 May 2021 21:47:12 +0200 Original-Received: from localhost ([::1]:51324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lgYLX-0002vM-6L for ged-emacs-devel@m.gmane-mx.org; Tue, 11 May 2021 15:47:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:59290) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgYKo-0002Ei-Ix for emacs-devel@gnu.org; Tue, 11 May 2021 15:46:26 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:35701 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lgYKl-0003hu-2Y; Tue, 11 May 2021 15:46:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=PnwVvyYbiHLHMKxNveZOeLi7Ep6vZixEhaJDSNGOJhI=; b=syVk54VwxQKXtP+SVhR5NzQ1y9 J7wis4Tdb9UG3MfjB21KVUO9QjE3EJabZzWfHc/J388F44B605q2VJ/TyokqkgJgtLuwacunPdxFS hVjt7kJCEG4VUX0WHoBv9tq+LCzOzIRqAakT7Jhxf0OBbZzLvBJj+WySNffPCfanvNAk=; In-Reply-To: <83h7j93wjg.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:269185 Archived-At: On 5/11/21 9:22 PM, Eli Zaretskii wrote: > Why not provide a defcustom that can accept both simple value, for the > most popular sort methods, and also allow function values for advanced > users? This is exactly what I did. If the user selects "No sorting" the value identity is taken and if the value "Sort alphabetically" is selected, the value completions-group-sort-alphabetically is taken. There is no point in introducing another symbolic indirection. We could add more options in case some more reasonable group sortings come up. There is no need for a newbie to directly manipulate functions. > Thanks. Now try putting yourself into the shoes of a newbie and try > imagining what can he/she make out of this doc string. "Function > taking and returning an alist"? really? The snippet which I just sent is a proposal. Up to now there has been a bit of back and forth of how the grouping feature is best implemented. Under these circumstances it does not make sense to send a fully polished patch each time. But by now the discussion seems to have somehow concluded, or at least I interpret that there is some agreement between the participants of the discussion which was mostly Juri, Stefan, Dmitry and myself. Daniel