From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Changes for emacs 28 Date: Fri, 11 Sep 2020 13:10:29 +0300 Message-ID: References: <20200910231420.kvqg6ohvxetpup5c.ref@Ergus> <20200910231420.kvqg6ohvxetpup5c@Ergus> <83zh5whl5p.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="22531"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: rekado@elephly.net, ghe@sdf.org, drew.adams@oracle.com, emacs-devel@gnu.org To: Eli Zaretskii , Ergus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Sep 11 12:11:08 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kGg1M-0005l6-5v for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Sep 2020 12:11:08 +0200 Original-Received: from localhost ([::1]:50324 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kGg1L-0005Eh-6t for ged-emacs-devel@m.gmane-mx.org; Fri, 11 Sep 2020 06:11:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55076) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kGg0q-0004pQ-06 for emacs-devel@gnu.org; Fri, 11 Sep 2020 06:10:36 -0400 Original-Received: from mail-lf1-x12a.google.com ([2a00:1450:4864:20::12a]:40842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kGg0o-0005pU-2G; Fri, 11 Sep 2020 06:10:35 -0400 Original-Received: by mail-lf1-x12a.google.com with SMTP id m5so5263929lfp.7; Fri, 11 Sep 2020 03:10:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=4gLrV1e8Qrv8bOqeN0TZQ5lgmnhdT7+4S1yEtI3Fftc=; b=mXw2xRuLpanqwNEPOOcRqF5MYSoHsTXpvLd2yRK0PZVsnucvm1+/lIUK8JSkUOYeRi Rgi/klYyFtuT71IQGUyV3VHsdRD2Fk7dukWwK1YMKsR3OkiKebwOJ5+/08f/UaFd6/eX sZVTdaeFGKnFc4i9tRNVHv3PdRO1uX8BRAXsv0kXBsQZV6P5nPwb+NUcZdTSpGpC6rbg 0h4B/s36qBPz9hfy5RJclylHViVa7hxYKHQTT44uGWilkEWK0nayZ+ilyrLpa6uGUmzS dYxmHa4ZjV5vFGfjglIN3Gi3IwF+/Ph2ajcjJ3RaLloxoJu4vtnb4hmQc51B/6X+f0Qu riXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=4gLrV1e8Qrv8bOqeN0TZQ5lgmnhdT7+4S1yEtI3Fftc=; b=XuYXyK7GbtECwlfBzW6cYHtETXSW8TkckYMoq5HoOZM51/RYdODKSenMYXY8Ttr264 2FPu8Opw4FzTp5rj36fOiVZT1nB1dd/bgZD1kJMYqb5kHo0TUzfjaSW4o5B0t7Chsf4O z8J5mGssP1kgG2PQmWsHlCwoUnrl/C+NYrCyj4KpUzK74Z0e2MpmcrlDGlJ7pakaVF9y 3hUMEXhrv5mZ/tLNEoRfQGDFmEja96J0BaDuXY9zcTkrPNcAmWLaWlShF+iuYDre4Izp QHnb39lPP/nWR1Vg1WDE0vy3n4FFuWRoh8hPYXZHb7gDqrOQsyl0R6BLBcIe7op7YIn1 QN0g== X-Gm-Message-State: AOAM531dDF716OSw4b/HKd6Ose+/6UE8xueOq+ig9RpJHoV1/kNa2EDM RuqMSmAKnIGAbSHeJCWopElXsNQsAz/zdw== X-Google-Smtp-Source: ABdhPJwRSuply5hivmdQXQxikcx/3h6omOp97EfqUNMvLJnV64MiBhPmzIyDnD6vnYIBqBOm9g5ViA== X-Received: by 2002:a19:dd5:: with SMTP id 204mr62051lfn.579.1599819031279; Fri, 11 Sep 2020 03:10:31 -0700 (PDT) Original-Received: from [192.168.0.104] ([94.229.108.16]) by smtp.googlemail.com with ESMTPSA id f18sm15499lfd.100.2020.09.11.03.10.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Sep 2020 03:10:30 -0700 (PDT) In-Reply-To: <83zh5whl5p.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::12a; envelope-from=raaahh@gmail.com; helo=mail-lf1-x12a.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -50 X-Spam_score: -5.1 X-Spam_bar: ----- X-Spam_report: (-5.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-3.576, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:255122 Archived-At: On 11.09.2020 09:39, Eli Zaretskii wrote: >> Date: Fri, 11 Sep 2020 01:14:20 +0200 >> From: Ergus >> Cc: Ricardo Wurmus, Gregory Heytings, >> emacs-devel@gnu.org >> >> 3) Is it possible/should we: add a redo icon in the toolbar >> conditionally when the mode is enabled? >> >> else >> >> 4) I see a redo added in the menu-bar unconditionally... should we do >> the same in the toolbar unconditionally? > I indeed think that the Redo icon should be added unconditionally > (enabled only when there's something to redo, like the menu item). Are you not worried about the divergence between the menu items and the toolbar, and the actual available bindings? And also about the fact the menu item next to 'redo' doesn't call 'undo-only'? Which will be contrary to the expectations of users who know the concept of 'redo' from other programs. I think this created a potential for additional user confusion. A global mode like undo-redo-mode, like suggested by Ergus, would avoid both of these problems. We'd only need to find a key for 'undo-redo'. Perhaps, 'M-_' and 'C-?'? That's what undo-tree uses by default.