From: Phil Sainty <psainty@orcon.net.nz>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org, kaushal.modi@gmail.com
Subject: Re: Help using the right hook for loading theme on emacs daemon GUI
Date: Fri, 25 Jan 2019 10:16:58 +1300 [thread overview]
Message-ID: <d02170ec28cf9bbc2bfd9f9a50bdf269@webmail.orcon.net.nz> (raw)
In-Reply-To: <83d0ol7scu.fsf@gnu.org>
On 2019-01-25 08:44, Eli Zaretskii wrote:
> It's not entirely a no-op, since there's early-init-file and
> package-initialize, both of which are called before this hook.
Ah, interesting. So this subtlety is new as of Emacs 27.
I was already thinking that the `after-make-frame-functions' docstring
could use some additional information (it seems to be a common point
of confusion when people start using --daemon); and even more so given
this new wrinkle.
(info "(elisp) Creating Frames") does already say:
> Note that any functions added to these hooks by your initial file
> are
> usually not run for the initial frame, since Emacs reads the initial
> file only after creating that frame. However, if the initial frame is
> specified to use a separate minibuffer frame (*note Minibuffers and
> Frames::), the functions will be run for both, the minibuffer-less and
> the minibuffer frame.
(As a tangent, the terminology "initial file" instead of the more
common "init file" is a little jarring. It crops up in that context
in a couple of other places in the manual, I see, and I'm unsure
whether it's a typo or intended, but I would be inclined to replace
them with "init file" in all cases.)
The info node should be updated to cover the new behaviour in 27, and
I suggest that the docstrings ought to provide a clear pointer to the
info node as being very important reading regarding when the hooks do
and do not run. I think the docstrings should possibly also replicate
or summarise some of that information; but just ensuring that readers
know there are additional subtleties to understand, and where to read
about them, would be good enough.
-Phil
next prev parent reply other threads:[~2019-01-24 21:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-17 15:44 Help using the right hook for loading theme on emacs daemon GUI Kaushal Modi
2019-01-17 15:49 ` Kaushal Modi
2019-01-17 15:55 ` Eli Zaretskii
2019-01-17 16:04 ` Kaushal Modi
2019-01-17 19:28 ` Daniel Colascione
2019-01-17 18:33 ` martin rudalics
2019-01-17 20:02 ` Kaushal Modi
2019-01-17 21:50 ` Eli Zaretskii
2019-01-22 20:25 ` Kaushal Modi
2019-01-18 3:47 ` Phil Sainty
2019-01-22 20:27 ` Kaushal Modi
2019-01-23 22:00 ` Phil Sainty
2019-01-24 3:47 ` Phil Sainty
2019-01-24 14:11 ` Eli Zaretskii
2019-01-24 19:17 ` Phil Sainty
2019-01-24 19:44 ` Eli Zaretskii
2019-01-24 21:16 ` Phil Sainty [this message]
2019-01-25 1:42 ` Phil Sainty
2019-01-25 7:20 ` Eli Zaretskii
2019-01-25 7:13 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d02170ec28cf9bbc2bfd9f9a50bdf269@webmail.orcon.net.nz \
--to=psainty@orcon.net.nz \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kaushal.modi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).