From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Glenn Morris Newsgroups: gmane.emacs.devel Subject: why keep generated lisp/international/uni-*.el in the repo? Date: Wed, 27 Nov 2013 04:04:38 -0500 Message-ID: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1385543082 20402 80.91.229.3 (27 Nov 2013 09:04:42 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Nov 2013 09:04:42 +0000 (UTC) Cc: Kenichi Handa To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Nov 27 10:04:49 2013 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vlb3B-00052T-1f for ged-emacs-devel@m.gmane.org; Wed, 27 Nov 2013 10:04:49 +0100 Original-Received: from localhost ([::1]:34604 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vlb3A-0005Dt-Ja for ged-emacs-devel@m.gmane.org; Wed, 27 Nov 2013 04:04:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vlb36-0005BP-PK for emacs-devel@gnu.org; Wed, 27 Nov 2013 04:04:45 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vlb31-0003Rg-PO for emacs-devel@gnu.org; Wed, 27 Nov 2013 04:04:44 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33427) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vlb31-0003Rc-MI for emacs-devel@gnu.org; Wed, 27 Nov 2013 04:04:39 -0500 Original-Received: from rgm by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1Vlb30-0005Lk-Ao; Wed, 27 Nov 2013 04:04:38 -0500 X-Spook: Steve Case 22nd SAS IRA BLU-114/B secure Craig X-Ran: nvb/mL~*[gX*o_B[5#LE#2$_Xjm2qOTE^`XFw^sYe^93`@l}.WeBVX>vXYE|N<#hxu>=9> X-Hue: black X-Attribution: GM User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:165799 Archived-At: Why do we keep the generated files lisp/internation/uni-*.el, charprop.el in the repo, rather than generating them during bootstrap? Is it just that "they don't change very often, and it makes bootstrap a tiny bit faster"? On my machine, it takes me ~ 5 seconds to generate them; compared to ~ 5 mins for a bootstrap. It doesn't seem worth keeping them for that. This is all we need to change to remove them from the repo: === modified file 'admin/unidata/Makefile.in' *** admin/unidata/Makefile.in 2013-10-30 16:45:51 +0000 --- admin/unidata/Makefile.in 2013-11-27 08:56:18 +0000 *************** *** 64,66 **** --- 64,70 ---- -rm -f ./Makefile maintainer-clean: distclean + if test -f ${DSTDIR}/charprop.el; then \ + (cd ${DSTDIR} && rm -f `sed -n 's/^;; FILE: //p' < charprop.el`); \ + rm -f ${DSTDIR}/charprop.el; \ + fi === modified file 'src/Makefile.in' *** src/Makefile.in 2013-11-27 06:15:06 +0000 --- src/Makefile.in 2013-11-27 08:50:26 +0000 *************** *** 417,429 **** $(leimdir)/leim-list.el: bootstrap-emacs$(EXEEXT) cd ../leim && $(MAKE) $(MFLAGS) leim-list.el EMACS="$(bootstrap_exe)" ## The dumped Emacs is as functional and more efficient than ## bootstrap-emacs, so we replace the latter with the former. ## Strictly speaking, emacs does not depend directly on all of $lisp, ## since not all pieces are used on all platforms. But DOC depends ## on all of $lisp, and emacs depends on DOC, so it is ok to use $lisp here. emacs$(EXEEXT): temacs$(EXEEXT) $(ADDSECTION) \ ! $(etc)/DOC $(lisp) $(leimdir)/leim-list.el if test "$(CANNOT_DUMP)" = "yes"; then \ rm -f emacs$(EXEEXT); \ ln temacs$(EXEEXT) emacs$(EXEEXT); \ --- 417,433 ---- $(leimdir)/leim-list.el: bootstrap-emacs$(EXEEXT) cd ../leim && $(MAKE) $(MFLAGS) leim-list.el EMACS="$(bootstrap_exe)" + $(lispsource)/international/charprop.el: bootstrap-emacs$(EXEEXT) + cd ../admin/unidata && $(MAKE) $(MFLAGS) all EMACS="../$(bootstrap_exe)" + ## The dumped Emacs is as functional and more efficient than ## bootstrap-emacs, so we replace the latter with the former. ## Strictly speaking, emacs does not depend directly on all of $lisp, ## since not all pieces are used on all platforms. But DOC depends ## on all of $lisp, and emacs depends on DOC, so it is ok to use $lisp here. emacs$(EXEEXT): temacs$(EXEEXT) $(ADDSECTION) \ ! $(etc)/DOC $(lisp) $(leimdir)/leim-list.el \ ! $(lispsource)/international/charprop.el if test "$(CANNOT_DUMP)" = "yes"; then \ rm -f emacs$(EXEEXT); \ ln temacs$(EXEEXT) emacs$(EXEEXT); \