From: Glenn Morris <rgm@gnu.org>
To: emacs-devel@gnu.org
Cc: Kenichi Handa <handa@gnu.org>
Subject: why keep generated lisp/international/uni-*.el in the repo?
Date: Wed, 27 Nov 2013 04:04:38 -0500 [thread overview]
Message-ID: <ckhaay9pw9.fsf@fencepost.gnu.org> (raw)
Why do we keep the generated files lisp/internation/uni-*.el, charprop.el
in the repo, rather than generating them during bootstrap?
Is it just that "they don't change very often, and it makes bootstrap a
tiny bit faster"?
On my machine, it takes me ~ 5 seconds to generate them;
compared to ~ 5 mins for a bootstrap.
It doesn't seem worth keeping them for that.
This is all we need to change to remove them from the repo:
=== modified file 'admin/unidata/Makefile.in'
*** admin/unidata/Makefile.in 2013-10-30 16:45:51 +0000
--- admin/unidata/Makefile.in 2013-11-27 08:56:18 +0000
***************
*** 64,66 ****
--- 64,70 ----
-rm -f ./Makefile
maintainer-clean: distclean
+ if test -f ${DSTDIR}/charprop.el; then \
+ (cd ${DSTDIR} && rm -f `sed -n 's/^;; FILE: //p' < charprop.el`); \
+ rm -f ${DSTDIR}/charprop.el; \
+ fi
=== modified file 'src/Makefile.in'
*** src/Makefile.in 2013-11-27 06:15:06 +0000
--- src/Makefile.in 2013-11-27 08:50:26 +0000
***************
*** 417,429 ****
$(leimdir)/leim-list.el: bootstrap-emacs$(EXEEXT)
cd ../leim && $(MAKE) $(MFLAGS) leim-list.el EMACS="$(bootstrap_exe)"
## The dumped Emacs is as functional and more efficient than
## bootstrap-emacs, so we replace the latter with the former.
## Strictly speaking, emacs does not depend directly on all of $lisp,
## since not all pieces are used on all platforms. But DOC depends
## on all of $lisp, and emacs depends on DOC, so it is ok to use $lisp here.
emacs$(EXEEXT): temacs$(EXEEXT) $(ADDSECTION) \
! $(etc)/DOC $(lisp) $(leimdir)/leim-list.el
if test "$(CANNOT_DUMP)" = "yes"; then \
rm -f emacs$(EXEEXT); \
ln temacs$(EXEEXT) emacs$(EXEEXT); \
--- 417,433 ----
$(leimdir)/leim-list.el: bootstrap-emacs$(EXEEXT)
cd ../leim && $(MAKE) $(MFLAGS) leim-list.el EMACS="$(bootstrap_exe)"
+ $(lispsource)/international/charprop.el: bootstrap-emacs$(EXEEXT)
+ cd ../admin/unidata && $(MAKE) $(MFLAGS) all EMACS="../$(bootstrap_exe)"
+
## The dumped Emacs is as functional and more efficient than
## bootstrap-emacs, so we replace the latter with the former.
## Strictly speaking, emacs does not depend directly on all of $lisp,
## since not all pieces are used on all platforms. But DOC depends
## on all of $lisp, and emacs depends on DOC, so it is ok to use $lisp here.
emacs$(EXEEXT): temacs$(EXEEXT) $(ADDSECTION) \
! $(etc)/DOC $(lisp) $(leimdir)/leim-list.el \
! $(lispsource)/international/charprop.el
if test "$(CANNOT_DUMP)" = "yes"; then \
rm -f emacs$(EXEEXT); \
ln temacs$(EXEEXT) emacs$(EXEEXT); \
next reply other threads:[~2013-11-27 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-27 9:04 Glenn Morris [this message]
2013-11-27 13:20 ` why keep generated lisp/international/uni-*.el in the repo? Andy Moreton
2013-11-27 17:18 ` Glenn Morris
2013-11-27 17:41 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ckhaay9pw9.fsf@fencepost.gnu.org \
--to=rgm@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=handa@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).