From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Harald_J=c3=b6rg?= Newsgroups: gmane.emacs.devel Subject: Re: cperl-mode: Eliminating references to obsolete packages Date: Thu, 24 Sep 2020 20:43:33 +0200 Message-ID: References: <63ad78b2-ec6b-8215-e775-db5889f4f94e@posteo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30650"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Sep 24 20:44:36 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kLWEN-0007rd-Kf for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 20:44:35 +0200 Original-Received: from localhost ([::1]:47004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kLWEM-0004BU-LU for ged-emacs-devel@m.gmane-mx.org; Thu, 24 Sep 2020 14:44:34 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLWDX-0003kL-NS for emacs-devel@gnu.org; Thu, 24 Sep 2020 14:43:45 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:33325) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kLWDT-0000zR-OK for emacs-devel@gnu.org; Thu, 24 Sep 2020 14:43:43 -0400 Original-Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id E00122400FB for ; Thu, 24 Sep 2020 20:43:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1600973014; bh=PK+32bAhWrSLSakNK1ivA634mxXpCqtvQWDNjNrBTH0=; h=Subject:To:From:Autocrypt:Date:From; b=bwEmCWwHuQcAXo4pgug+vA5Ry8uMeFvuUuIu3gfGPKDz9YXJTlSK79tlh9Algludd KSgGoT+g/G33ViqjHL9ygGqTHCxv0ub18cIHgjthSeXTff5z1SJ4HXIJ63NePlktiP uYAWPr8LeZbkFR8tfN3DxfH5DcZiZSGaweUJorjzJWEIgAAfCe686NutAd00lbpbx0 NpEN2d1uy7Hvk/rI268ThcU6LRrGR1gEgdC+2QxRpgW2eR6PTfhx1VZIAjN7X9LN4l gB2xWTZD4o5DbzQCXQ8ItUWlodZAFUXjV/IkEgBDGZj8wSeO5f+0V1xEneC4W7Mfo6 mnb80vXLshXfw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4By3pZ2tWZz6tn7 for ; Thu, 24 Sep 2020 20:43:34 +0200 (CEST) Autocrypt: addr=haj@posteo.de; keydata= mQINBF0DVrIBEAC7TRlIilBg/5Dx7R2rV4FBDEavbyMT2cS2wWyksh7JA8e17LNmTdakf+Bm u6C2m6+frolteYRlkreoyAg0fj/5tDw/s5dJDw3tM0b+m/pj2HcwTSRpQSEy5lBiCg11E6Mt F9UngCfkGtJzu8PBWXc1RDQVBwRn5MZbpMZZatE8NOq9AA3Yg6sY11Ez3xIvYU2R7a4OSxmc RJV2+dhdQ4oOTBIGQ2urQSU81kyRtkx+/Yh8WefMrk9nF3nzYziLS53euCAXyzklwYmD6Li3 XSu7wYp5fISky9DK6DPFK7h4RXEL4GFAhy31ehrVnNTcGRohM1Dm9BV9dwXkwlaeT3q0X+nE SXVqPDHtv748bXNIg2WVCZ0WgShcA46XVlSE9Fm+w0HI/1m1L4BaMmQ7gyK5dEchbhxohkk0 AqC3hEJ4ULRidrsCoCWGMFKiOIb9rjeC00vhrUkVJDkPWEGLXjhnRQykb6cESko0rPrSDLqX 9YqaNQ6KO9Un6uogE7YnXYg35EXJ8ORdX257IbXNbFVpgM8FFsl48WV3Pl9WNdADhnnOrz3O wzyK58i/BTsnjVX8ghbWkQcPQ2Kprt+4YR2trEi7TM5Uqzzrg0vp7Oe/9KZBxdxCE67thV7h ElW3CHb4q6o31b4cFmLbtFesSy+hnUU4UymgHgi/hvhxioBxIQARAQABtBxIYXJhbGQgSsO2 cmcgPGhhakBwb3N0ZW8uZGU+iQJOBBMBCAA4FiEEIpYEZLQynxF8Q17KN4XzzzqAcpsFAl0D VrICGwMFCwkIBwIGFQgJCgsCBBYCAwECHgECF4AACgkQN In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=185.67.36.66; envelope-from=haj@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/09/24 14:43:35 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -29 X-Spam_score: -3.0 X-Spam_bar: --- X-Spam_report: (-3.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.214, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:256399 Archived-At: Stefan Monnier writes: > For example that "format-prompt" problem currently also affects the > python.el GNU ELPA package. Luckily, AFAICT we haven't yet released > a new python.el package (because the version number has not been > bumped), but the problem is real. I noticed that some of them (but not python.el) contain a comment like this: ;; This is an Elpa :core package. Don't use functionality that is not ;; compatible with Emacs 24.1. ...but I don't know whether that actually helps. For me it would be rather cumbersome to find out which functionality isn't compatible with Emacs 24.1. Some recent doc strings (e.g. time-convert) show it, some (e.g. format-prompt) don't. > [...] > Some automated tests that try to build&compile (and treat warnings as > errors) those packages on the corresponding oldest Emacs version > supported would come in handy. Wouldn't this rule out the type of fallback patch you suggested? When I byte-compile-file cperl-mode.el in Emacs 26.1 _with_ your fallback patch applied, I still get the warning: In end of data: cperl-mode.el:8736:1:Warning: the function ‘format-prompt’ is not known to be defined. Sorta obvious, though: The compilation step doesn't _run_ the fboundp safeguard. Anyway: Are there frameworks for such tests in the Emacs repository? On GitHub, I can apply stuff from https://github.com/marketplace/actions/emacs-lisp-check, but as of now this also gives false positives: github-actions / test-on-self (26.1, true) cperl-mode.el#L5880 You should depend on (emacs "27.1") if you need ‘cperl-force-face’. This is fairly idiotic since "my" cperl-mode.el itself _defines_ cperl-force-face. Somehow the check seems to "know" what's available in vanilla Emacs 26.1 and 27.1. I discovered that GitHub action in Sacha Chua's blog https://sachachua.com/blog/2020/06/2020-06-22-emacs-news/ and just gave it a try without actually understanding what I was doing :) -- Cheers, haj