From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jostein_Kj=c3=b8nigsen?= Newsgroups: gmane.emacs.devel Subject: bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face Date: Mon, 9 Sep 2019 10:49:31 +0200 Message-ID: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="268218"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.0 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 09 10:49:49 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1i7FMp-0017dr-Lz for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 10:49:48 +0200 Original-Received: from localhost ([::1]:52994 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7FMo-0001VL-9S for ged-emacs-devel@m.gmane.org; Mon, 09 Sep 2019 04:49:46 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58286) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i7FMg-0001TQ-Em for emacs-devel@gnu.org; Mon, 09 Sep 2019 04:49:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i7FMf-0004NO-Du for emacs-devel@gnu.org; Mon, 09 Sep 2019 04:49:38 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:51201) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i7FMf-0004M1-16 for emacs-devel@gnu.org; Mon, 09 Sep 2019 04:49:37 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 310B3691 for ; Mon, 9 Sep 2019 04:49:34 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Mon, 09 Sep 2019 04:49:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= secure.kjonigsen.net; h=to:from:subject:message-id:date :mime-version:content-type:content-transfer-encoding; s=fm1; bh= 4cgqw/UNSgle7QrdLYd8lOIIQVRMKuHWPxA/lXtVYyY=; b=N+J/5bdHzY5zkD4l FLuSSDAMyGptJtmFzaQ670bq+yUzGluDEJvJMWdUDibQNdQC2ECq4DrmC6GbxTJv g6UwDiml6ivwCEYWAZ18Y1OXBaQY5kzh/F2LdwmyQTxFU34hEOyVgnYPMOeAQqws qIC2EIvBcmRGphpphI/izE4MeTYKVtGN99HkntBrJGyR98sIxDfWJcnTtJS2VTb7 rLBNjyBLet4IsYk953CdVaZahgQ/Y2d3O94cd9p1rxGSoTi8+pvT5nhbhxfaqtPD GMj/f0iQLU5Y02lef0eKaiUXM6IttU01sGOZ4d0vRjfVEJ2nSkceqxR5yJsXkfJE 1/XM1A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=4cgqw/ UNSgle7QrdLYd8lOIIQVRMKuHWPxA/lXtVYyY=; b=lvhd7Ar0sTlcIYQm35lOZQ GHZFneCgdkurW0rfkzQZxtjezVV/wtnk5C4wCtrzgL8WUpRJh7JCfZGPvPQKxCY6 1S5jg+Q+/mDG5Y8xMf19f4b0GB2C3R3dLvV6h6UWvp1QTgg/uk9nB/qPk6ItV2BF 41tDY0MSoWZ5oPA02JfqxnFvWlL68rNmFnGn3h+Ic91N5v/exfZ5reAe6uhU7vLi tN0fDtcBsnXtxhORU2OP1g4ZGa0St22D7yyyp4PpIFOAp3uIsj4dycGW6Qp6Yj+/ 5bz9fsuuteGInYClBvgBjawTDQOB9anIAGUjBrN5C6XwFAGuAs61M7LDvoggeuJw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudekiedgtdeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefvhffukffffgggtgfgsehtkeertd dtfeejnecuhfhrohhmpeflohhsthgvihhnpgfmjhppnhhighhsvghnuceojhhoshhtvghi nhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvghtqeenucffohhmrghinhepnhhigh hsvghnrdhnohenucfkphepvddujedrudeggedrvdefledrudeftdenucfrrghrrghmpehm rghilhhfrhhomhepjhhoshhtvghinhesshgvtghurhgvrdhkjhhonhhighhsvghnrdhnvg htnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Original-Received: from [10.0.4.71] (fw01mx01.superoffice.com [217.144.239.130]) by mail.messagingengine.com (Postfix) with ESMTPA id 3DE028005C for ; Mon, 9 Sep 2019 04:49:33 -0400 (EDT) Content-Language: en-GB X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 64.147.123.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:239951 Archived-At: Hey everyone. Right now Emacs' bat-mode has an inconsistent use of faces, both internally and w.r.t. to the rest of the Emacs universe. In batch files you can create "labels". A label is a line whose character is : followed by alpha-numerical characters. :EXAMPLE_LABEL These labels are often used via GOTO-statements for direct control flow, but they can also be used via CALL-statements and then they work like functions/subroutines and control is eventually returned to the caller. CALL :subroutine param1 param2 GOTO :EOF etc Right now labels have one custom-face defined for bat-mode (bat-label-face), and all -uses- of this label via GOTO or CALL-statements has this label highlighted using font-lock-constant-face. My proposal is that we change both these rules to instead be font-lock-function-name-face. This solves both constency-problems: - internal consistency of label/function fontification - external consistency of function-name fontification. Does anyone have an issue with such a change? -- Vennlig hilsen *Jostein Kjønigsen* jostein@kjonigsen.net 🍵 jostein@gmail.com https://jostein.kjønigsen.no