From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: git history tracking across renames (and emacs support) (Was: The name gnus-cloud.el) Date: Mon, 8 Jan 2018 23:27:10 -0800 Organization: UCLA Computer Science Department Message-ID: References: <87bmj6dda0.fsf@linux-m68k.org> <87vahe911g.fsf@lifelogs.com> <87374id7jy.fsf@linux-m68k.org> <877ett8g7k.fsf@lifelogs.com> <87a7yn7tqp.fsf@lifelogs.com> <878te75xa1.fsf@lifelogs.com> <87ind6l2tt.fsf@lifelogs.com> <877etklvsa.fsf@lifelogs.com> <83y3m0pv8u.fsf@gnu.org> <86608msw0h.fsf@dod.no> <838tdiet25.fsf@gnu.org> <87y3li4vh7.fsf@telefonica.net> <87efnan46u.fsf@linux-m68k.org> <86wp12qtgo.fsf@dod.no> <83tvw6chqv.fsf@gnu.org> <86shbprix7.fsf_-_@dod.no> <7c7503b4-1f82-8a25-fedd-c61c3e7629f6@cs.ucla.edu> <83zi5o6w4p.fsf@gnu.org> <745d2f02-8ca3-8962-0de4-053340c8fa63@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1515482763 15577 195.159.176.226 (9 Jan 2018 07:26:03 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 9 Jan 2018 07:26:03 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 Cc: eliz@gnu.org, sb@dod.no, emacs-devel@gnu.org To: rms@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jan 09 08:25:58 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eYoIG-0003aW-TH for ged-emacs-devel@m.gmane.org; Tue, 09 Jan 2018 08:25:57 +0100 Original-Received: from localhost ([::1]:34616 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYoKE-0000Hb-Sc for ged-emacs-devel@m.gmane.org; Tue, 09 Jan 2018 02:27:58 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:39016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eYoJZ-0000HK-Qg for emacs-devel@gnu.org; Tue, 09 Jan 2018 02:27:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eYoJY-0003ii-VY for emacs-devel@gnu.org; Tue, 09 Jan 2018 02:27:17 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:49232) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1eYoJV-0003hW-5D; Tue, 09 Jan 2018 02:27:13 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 0705A1615EC; Mon, 8 Jan 2018 23:27:12 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id yp0tkTy40Iku; Mon, 8 Jan 2018 23:27:11 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 48D0A1615ED; Mon, 8 Jan 2018 23:27:11 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 10-AS5QRh899; Mon, 8 Jan 2018 23:27:11 -0800 (PST) Original-Received: from [192.168.1.9] (unknown [47.154.30.119]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1C43E1615EC; Mon, 8 Jan 2018 23:27:11 -0800 (PST) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:221748 Archived-At: Richard Stallman wrote: > > If it's important enough to > > mention the change from extern to static in the commit message, th= e > > current guidelines would seem to imply that it's important enough = to > > mention why the change was made in code comments. >=20 > Here's what the standard actually says: >=20 > If you think that a change > calls for explanation, you're probably right. Please do explain > it---but please put the full explanation in comments in the code, > where people will see it whenever they see the code. >=20 > So you're criticizing a practice which is NOT our standard. I didn't think that particular change required any description or explana= tion.=20 That is, the change and its intent was obvious from the diff, and I put=20 something into the commit message (aka ChangeLog entry) only because the = coding=20 standards required it. If commit messages are not required for trivial ch= anges,=20 it'd be helpful for the coding standards to say so, as this will save us = some=20 unnecessary work.