From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Tree-sitter and major mode inheritance Date: Sun, 20 Nov 2022 01:42:04 +0200 Message-ID: References: <0249C656-21C8-49F2-B979-A1894BF80637@gmail.com> <1B76E73A-0DCD-456E-9F28-0E90723DA66D@gmail.com> <83sfif8cl2.fsf@gnu.org> <43E997E4-3449-4974-AB8C-BD5A4AA8A738@gmail.com> <2ccc9409-36ae-9bb5-127f-bb77a8b59460@yandex.ru> <6D0D24A7-7A7B-4D8E-A267-1FA752071C68@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5705"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Cc: Eli Zaretskii , emacs-devel@gnu.org, monnier@iro.umontreal.ca, theo@thornhill.no To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Nov 20 00:43:04 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owXUG-0001IF-KP for ged-emacs-devel@m.gmane-mx.org; Sun, 20 Nov 2022 00:43:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1owXTe-00041o-L9; Sat, 19 Nov 2022 18:42:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owXTd-00041f-Fl for emacs-devel@gnu.org; Sat, 19 Nov 2022 18:42:25 -0500 Original-Received: from mail-wr1-x434.google.com ([2a00:1450:4864:20::434]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1owXTb-00066m-UQ; Sat, 19 Nov 2022 18:42:25 -0500 Original-Received: by mail-wr1-x434.google.com with SMTP id bs21so14746950wrb.4; Sat, 19 Nov 2022 15:42:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=uKUF4t/faSY7OJSu9In0/ToPlcywLTNkgdAc6ryquFw=; b=ZE1pjWZBulIVBbQDXLRcGzZZ5iSAXNfx7PLGOfkhPzwkRq9rX8GBkI1pBQL2lqtz0u 0IgP5MTlfg5tHZPhqFchmaVgDiAtiQ2ETz7t9R4FexXAnq0uSgZAuS0p6+ppqlYg8QFJ n59lOFfjRQJNUh5OYVGR3HHRInZHB0wPpwLYEKqtVBa3o758vi72SsmdMNvSpnrAFEP7 F66ZoNVFbQbYnwIvcJMdSsadAffcpocmi1t7Z+pGWd+wWjDqUTlLXdGsufwa85L6GrGN LqPill8uqlltmlwm3M6ZHwR36JMRFFwzcfOzib594ARtldY3sYjwBkV5Z09s+DSQQkCY 59SQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uKUF4t/faSY7OJSu9In0/ToPlcywLTNkgdAc6ryquFw=; b=CxPaorizpuvS9sNTk7sV3r6iNGn2p2AXjiKCeWk4R/ly0HDRUz6NHAGUXV3SASmeQb cslUwHTiVTuVoV0UdrvZzWxMYupr4f+sTfRoc1DCVHm1P/JiCn4oe7F5CYK4rGsoZnvT Xmwot60KCzTKAkTz0ZjbV5IaTBKjl2HAWwa+kgFmjSBCfmbS15rGFQZUu6xzD/XICI+N fw99x6GkywrEWgT8Qk+2dQhn+pLSookr8Y/vxiXWhkAZqojc/7rUpsnSlK+RWa5bjsa6 xRvUBBGdYkXYnPuM5Gl2H/IgBIVuQYm7SD2pDXdFnKyGn+AB3BQEfgZtgI3vstw+/F9z 4mLA== X-Gm-Message-State: ANoB5pkMfG/9af10El/ahZ1s8uD8AYSwI+xyMc1Ji8Rqw3mHZMIHKB4l K5s4XZcwwDM7P3wiQXhv5cM= X-Google-Smtp-Source: AA0mqf4zxUixVv/PrEBQprUKteKFmpbYKeQi9JrndlSCHY4gy2aMnTPghET5j/MUBzepQZr0Onw2sw== X-Received: by 2002:a05:6000:103:b0:241:d028:78c5 with SMTP id o3-20020a056000010300b00241d02878c5mr834136wrx.131.1668901326744; Sat, 19 Nov 2022 15:42:06 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id o18-20020a05600c4fd200b003cf6a55d8e8sm9949423wmq.7.2022.11.19.15.42.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 15:42:06 -0800 (PST) Content-Language: en-US In-Reply-To: <6D0D24A7-7A7B-4D8E-A267-1FA752071C68@gmail.com> Received-SPF: pass client-ip=2a00:1450:4864:20::434; envelope-from=raaahh@gmail.com; helo=mail-wr1-x434.google.com X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.001, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:300218 Archived-At: On 20.11.2022 01:36, Yuan Fu wrote: > If we keep js-mode as-is, and add js-base-mode and js-ts-mode, (derived-mode-p ‘js-mode) should keep working as before, or maybe I’m msiunderstanding your question? (derived-mode-p 'js-mode) will return nil in js-ts-mode. Which could be a problem when this call is used as a substitute for a file type check (e.g. "are we editing a JavaScript file?"), which is one of its common uses.