RPATH on 64-bit arches

RPATH on 64-bit arches

[Chip Coldwell]

Hello emacs-devel,

May I draw your attention to

https://bugzilla.redhat.com/show_bug.cgi?id=253872

Basically, the problem is that the current definition of the autoconf
macro _AC_PATH_X_XMKMF causes the emacs build process to insert an
RPATH into the 64-bit binary.  Personally, I feel this is a bug in
autoconf, so perhaps this is the wrong forum to bring it up.  FWIW, I
have this patch to fix it:

--- autoconf-2.59/lib/autoconf/libs.m4  2008-04-21 11:26:31.954460000 -0400
+++ autoconf-2.59.new/lib/autoconf/libs.m4      2008-04-21 11:27:25.552368000 -0400
@@ -206,7 +206,7 @@ _ACEOF
        *) test -f "$ac_im_incroot/X11/Xos.h" && ac_x_includes=$ac_im_incroot;;
     esac
     case $ac_im_usrlibdir in
-       /usr/lib | /lib) ;;
+       /usr/lib64 | /usr/lib | /lib) ;;
        *) test -d "$ac_im_usrlibdir" && ac_x_libraries=$ac_im_usrlibdir ;;
     esac
   fi

Chip

-- 
Charles M. "Chip" Coldwell
Senior Software Engineer
Red Hat, Inc
978-392-2426

GPG ID:  852E052F
GPG FPR: 77E5 2B51 4907 F08A 7E92  DE80 AFA9 9A8F 852E 052F

Re: RPATH on 64-bit arches

[Glenn Morris]

Chip Coldwell wrote:

> https://bugzilla.redhat.com/show_bug.cgi?id=253872
>
> Basically, the problem is that the current definition of the autoconf
> macro _AC_PATH_X_XMKMF causes the emacs build process to insert an
> RPATH into the 64-bit binary.  Personally, I feel this is a bug in
> autoconf, so perhaps this is the wrong forum to bring it up.  FWIW, I
> have this patch to fix it:

Can't we add a workaround for this in configure.in (see below)?
Patching configure is a nuisance, and almost guaranteed to get lost
after it gets regenerated a few times.

This doesn't seem to cause any real harm (?), so is probably not worth
fixing in Emacs 22.


*** configure.in	23 Apr 2008 05:55:32 -0000	1.524
--- configure.in	25 Apr 2008 22:19:19 -0000
***************
*** 1339,1344 ****
--- 1339,1353 ----
    window_system=x11
  fi
  
+ ## Workaround for bug in autoconf <= 2.62.
+ ## http://lists.gnu.org/archive/html/emacs-devel/2008-04/msg01551.html
+ ## No need to do anything special for these standard directories.
+ if test -n "${x_libraries}" && test x"${x_libraries}" != xNONE; then
+    
+    x_libraries=`echo :${x_libraries}: | sed -e 's|:/usr/lib64:|:|g' -e 's|:/lib64:|:|g' -e 's|^:||' -e 's|:$||' -e 's|::||'`
+ 
+ fi
+ 
  if test "${x_libraries}" != NONE; then
    if test -n "${x_libraries}"; then
      LD_SWITCH_X_SITE=-L`echo ${x_libraries} | sed -e "s/:/ -L/g"`

Re: RPATH on 64-bit arches

[Brad Walker]

> Chip Coldwell wrote:
>
> > https://bugzilla.redhat.com/show_bug.cgi?id=253872
> >
> > Basically, the problem is that the current definition of the autoconf
> > macro _AC_PATH_X_XMKMF causes the emacs build process to insert an
> > RPATH into the 64-bit binary.  Personally, I feel this is a bug in
> > autoconf, so perhaps this is the wrong forum to bring it up.  FWIW, I
> > have this patch to fix it:
>
> Can't we add a workaround for this in configure.in (see below)?
> Patching configure is a nuisance, and almost guaranteed to get lost
> after it gets regenerated a few times.
>
> This doesn't seem to cause any real harm (?), so is probably not worth
> fixing in Emacs 22.

If another 22 point release is planned, and the patch committed on
Saturday to HEAD fixes the problem without causing others, can it be included
in the next Emacs 22? An upstream package without the fix won't cause
any problems, but Fedora wouldn't need to carry the patch as long, and who
knows when Emacs 23 will come out.

Brad Walker