From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: master 8c81818673a 6/7: Tune volatile in read_char Date: Mon, 19 Aug 2024 12:43:54 -0700 Organization: UCLA Computer Science Department Message-ID: References: <172386820621.30556.15409337288904485218@vcs2.savannah.gnu.org> <87f24fac-aa71-499f-a398-2bad70a0ca42@cs.ucla.edu> <8634n0y2th.fsf@gnu.org> <87plq4cyuj.fsf@protonmail.com> <861q2ky0tg.fsf@gnu.org> <87le0scxig.fsf@protonmail.com> <86y14swksj.fsf@gnu.org> <871q2kcp0a.fsf@protonmail.com> <86r0akwbuk.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="30005"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: acorallo@gnu.org, emacs-devel@gnu.org, stefankangas@gmail.com To: Eli Zaretskii , Pip Cet Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Aug 19 21:44:58 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sg8JF-0007dX-PN for ged-emacs-devel@m.gmane-mx.org; Mon, 19 Aug 2024 21:44:58 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sg8IU-0003Kb-30; Mon, 19 Aug 2024 15:44:10 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sg8IL-0003KG-K1 for emacs-devel@gnu.org; Mon, 19 Aug 2024 15:44:02 -0400 Original-Received: from mail.cs.ucla.edu ([131.179.128.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sg8IJ-00010g-U6; Mon, 19 Aug 2024 15:44:01 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id C85A13C00E8B0; Mon, 19 Aug 2024 12:43:55 -0700 (PDT) Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10032) with ESMTP id dUnGh7QKlK7w; Mon, 19 Aug 2024 12:43:55 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 3E2093C00E400; Mon, 19 Aug 2024 12:43:55 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 3E2093C00E400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1724096635; bh=vApYvcrtiQEKRQAWCevlxyG8NKnyUAb/9lYe06Yf3HQ=; h=Message-ID:Date:MIME-Version:To:From; b=ZeM1WFMKWLnvZVIb1MM5la+5DcrFdVw859HOvaiyd3SjLM2PFGPAfJUeW9l5amM+6 TM5I4MuFHkIZrixBKikGhMsCUtJTivKBchYMGENAy5qOh3qHWnKgZBzg7mlsuzStEj VU4vsW+nRPdtEyRkwStThzZIviemsGIQzG8pAccEkGhXfzh4O3mCWRplfxQdxDKnXF NHrnHu24FQoPjnfzLRai2HKNboAwqPhNsd87dlDXtcybnH4x91HY9V+TunBsBzxuLM wW8xBxn/yMGj7kQLc8KQtHz5IcJvhv2MJKStJgYiADT9zMLDYGEibb9+QGByI5HvBP sbng6V1ByfHXQ== X-Virus-Scanned: amavis at mail.cs.ucla.edu Original-Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavis, port 10026) with ESMTP id yky4XpxWO7Ev; Mon, 19 Aug 2024 12:43:55 -0700 (PDT) Original-Received: from [192.168.254.12] (unknown [47.150.137.250]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id 1B52F3C00E8B0; Mon, 19 Aug 2024 12:43:55 -0700 (PDT) Content-Language: en-US In-Reply-To: <86r0akwbuk.fsf@gnu.org> Received-SPF: pass client-ip=131.179.128.66; envelope-from=eggert@cs.ucla.edu; helo=mail.cs.ucla.edu X-Spam_score_int: -19 X-Spam_score: -2.0 X-Spam_bar: -- X-Spam_report: (-2.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:322944 Archived-At: On 2024-08-19 12:29, Pip Cet wrote: > now we reset the quit counter to the value it had when we > registered the handler, which might reduce it, and thus lead to missed > quits (though I haven't found a bytecode object that causes that bug > yet) I don't see how that could lead to missed quits. Can you explain? (Are you thinking of dealing with corrupted bytecode objects? But I don't see it even then.) quit_counter is merely a heuristic: it merely needs to increase if the current bytecode object loops forever. If I understand things correctly this increase should happen (albeit perhaps more slowly) regardless of whether your proposed patch is applied, which means the patch shouldn't be needed.