From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>, Pip Cet <pipcet@protonmail.com>
Cc: acorallo@gnu.org, emacs-devel@gnu.org, stefankangas@gmail.com
Subject: Re: master 8c81818673a 6/7: Tune volatile in read_char
Date: Mon, 19 Aug 2024 12:43:54 -0700 [thread overview]
Message-ID: <cebd3613-697a-4cb8-9c49-fc9f5c67df0f@cs.ucla.edu> (raw)
In-Reply-To: <86r0akwbuk.fsf@gnu.org>
On 2024-08-19 12:29, Pip Cet wrote:
> now we reset the quit counter to the value it had when we
> registered the handler, which might reduce it, and thus lead to missed
> quits (though I haven't found a bytecode object that causes that bug
> yet)
I don't see how that could lead to missed quits. Can you explain? (Are
you thinking of dealing with corrupted bytecode objects? But I don't see
it even then.)
quit_counter is merely a heuristic: it merely needs to increase if the
current bytecode object loops forever. If I understand things correctly
this increase should happen (albeit perhaps more slowly) regardless of
whether your proposed patch is applied, which means the patch shouldn't
be needed.
next prev parent reply other threads:[~2024-08-19 19:43 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <172386820621.30556.15409337288904485218@vcs2.savannah.gnu.org>
[not found] ` <20240817041648.A6687C2BC66@vcs2.savannah.gnu.org>
2024-08-17 15:04 ` master 8c81818673a 6/7: Tune volatile in read_char Andrea Corallo
2024-08-17 17:03 ` Pip Cet
2024-08-17 18:16 ` Paul Eggert
2024-08-17 18:17 ` Paul Eggert
2024-08-18 7:39 ` Andrea Corallo
2024-08-18 21:39 ` Paul Eggert
2024-08-18 21:57 ` Sam James
2024-08-18 22:03 ` Paul Eggert
2024-08-19 14:43 ` Andrea Corallo
2024-08-19 15:01 ` Eli Zaretskii
2024-08-19 15:32 ` Pip Cet
2024-08-19 15:44 ` Eli Zaretskii
2024-08-19 16:01 ` Pip Cet
2024-08-19 16:15 ` Eli Zaretskii
2024-08-19 18:59 ` Paul Eggert
2024-08-19 19:27 ` Eli Zaretskii
2024-08-19 19:05 ` Pip Cet
2024-08-19 19:29 ` Eli Zaretskii
2024-08-19 19:43 ` Paul Eggert [this message]
2024-08-19 20:08 ` Pip Cet
2024-08-19 22:20 ` Paul Eggert
2024-08-19 23:40 ` Pip Cet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cebd3613-697a-4cb8-9c49-fc9f5c67df0f@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=acorallo@gnu.org \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=pipcet@protonmail.com \
--cc=stefankangas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).