From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] EWW - use revert--buffer-function to reload, and allow reload in eww-list-buffer Date: Sun, 13 Oct 2024 21:05:23 -0700 Message-ID: References: <86y12tycdy.fsf@gnu.org> <87v7xvh4rd.fsf@sebasmonia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33945"; mail-complaints-to="usenet@ciao.gmane.io" Cc: adam@alphapapa.net, emacs-devel@gnu.org To: =?UTF-8?B?U2ViYXN0acOhbiBNb27DrWE=?= , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 14 06:06:28 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t0CLi-0008f5-Dq for ged-emacs-devel@m.gmane-mx.org; Mon, 14 Oct 2024 06:06:26 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0CL6-0003Xx-D5; Mon, 14 Oct 2024 00:05:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0CKn-0003WU-N1 for emacs-devel@gnu.org; Mon, 14 Oct 2024 00:05:30 -0400 Original-Received: from mail-pg1-x52a.google.com ([2607:f8b0:4864:20::52a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0CKk-0001Mj-N8; Mon, 14 Oct 2024 00:05:29 -0400 Original-Received: by mail-pg1-x52a.google.com with SMTP id 41be03b00d2f7-7ea7e2ff5ceso452703a12.2; Sun, 13 Oct 2024 21:05:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728878724; x=1729483524; darn=gnu.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=ZWNkHX+aSY7VWjdAtDj4549JTB4FJNF2Rk01VoOom4M=; b=JZBluEbakaUs7hmHZicHKokbetlvX0CkcIjMXt7A6mjpTdjzCSKiqraupeJhAdo5He 6EjYZr9wdsRKBFF4f621n+cfp+rcOABG6FfOFDiqkouxQtL+zPl+FdwZNYq/SmzmjXNQ zALydZxRyvf3u7oq4Y0Ox6yKw5Nhly9+6R0EX0khvAotMb5M8ljS7G4oVQfu2BkFBGG3 vQy2PdnD+I3GjpTsOjwwd45iF2NI8AY9/gBSaQ9FgszJMCFqaJlnENP2ONyH+BbFbGQg FbZTkx8biUSzepo16n0iofsufSDWu3RJmJXVaEZM4te9QubliU94PWSwd0fTOlqls93d 8Fbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728878724; x=1729483524; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZWNkHX+aSY7VWjdAtDj4549JTB4FJNF2Rk01VoOom4M=; b=Wot7rQm6MkWa6/yOFuwdNniIWewhezY2idXpoP+JptGAjOJCkkQYLbVKBMV7Ilmry3 KNof/O27Gy8CcfT+TPbX/2UzqXN6plB9GCZT0YMvuBD3q7YmxWB0vkg3w5ibFKiax4sf fQk9b/DEEb00IWNZiYw/lIBx0Rg39AE45xcje0Iy4T8Qdfq75NmOEcCLccqJmJfGeU3q 9mj+rz+1Q71H/dzwdWmJEtg5PWSplF6QlKrgxZHhZ1lifITT0VFbipQ/0r6bagCkAb/e xnF7Bu6SRowZE/Ny2fx7oPdpkZdRoAAkcRMYyl4e70cyMjjJPsTNCcW6QduJWtPJ3ZhK ReMw== X-Forwarded-Encrypted: i=1; AJvYcCUA1XfsgkAdykv5cE4dTYEh+032EFAqHSnnzUgJ7ypQu20OliRnC9aKJ9+mKQcctBq7S7KDlNDzSoVdLRw=@gnu.org, AJvYcCXZRz4cz95PHBZOXHdP1+gF8azAO6ZzaN6IiIlViniis7uSbi/D3OQtyBJtdSiWLs7MxqC7@gnu.org X-Gm-Message-State: AOJu0YzpaTfZRQHh3HL0WzGWZipg0cifjA1oJRQp6cnZ+FLxb7qR2lNX UjjA8NECf0KRtWzLODciSvkU5SkVQyZnU8ruk5xhfdxH4IRAnJMiQF13Sw== X-Google-Smtp-Source: AGHT+IH0THZMkz0roNg8GZTxMj0BGNTIGwsJH7hx1gTh6H+CxHFwlApU+Ptf30m6jNVRjB9gdzCQHQ== X-Received: by 2002:a05:6a21:1807:b0:1d6:e55f:53d5 with SMTP id adf61e73a8af0-1d8bcf1735amr15093367637.11.1728878724318; Sun, 13 Oct 2024 21:05:24 -0700 (PDT) Original-Received: from [192.168.1.2] (syn-023-240-098-037.res.spectrum.com. [23.240.98.37]) by smtp.googlemail.com with ESMTPSA id 41be03b00d2f7-7ea677587bfsm3845444a12.76.2024.10.13.21.05.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 13 Oct 2024 21:05:23 -0700 (PDT) Content-Language: en-US In-Reply-To: <87v7xvh4rd.fsf@sebasmonia.com> Received-SPF: pass client-ip=2607:f8b0:4864:20::52a; envelope-from=jporterbugs@gmail.com; helo=mail-pg1-x52a.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:324555 Archived-At: On 10/13/2024 6:06 PM, Sebastián Monía wrote: > Attached a new patch that used vtable, and also adds the > (eww-buffer-list) function that Jim mentioned before. > Once this one is merged (after review & corrections :) etc.) I can take > the same vtable approach for eww-bookmarks. Thanks for the updated patch. Aside from the things Adam has already mentioned, this looks good to me. Just one small comment: > +(defun eww--list-buffers-display-table (&optional ignore-auto noconfirm) > + "Display a table with the list of eww buffers. > +Will remove all buffer contents first. The parameters IGNORE-AUTO and > +NOCONFIRM are ignored, they are for compatibility with > +`revert-buffer-function'." > + (let ((inhibit-read-only t)) > + (erase-buffer) > + (make-vtable > + :columns '((:name "Title" :width 30) Maybe something like ':min-width "25%" :max-width "50%"' here? That way users can see longish page titles, and if all the titles are short, we give most of the space to the URLs. (As an aside, I wonder how hard it would be to add support for 'auto-revert-mode' to the EWW buffer list.)