Bad usage of pgg-gpg-* functions in allout.el

Bad usage of pgg-gpg-* functions in allout.el

[Daiki Ueno]

>>>>> In <2cd46e7f0604061550j44c97f68v4c6cffda79a4e0ce@mail.gmail.com> 
>>>>>	"Ken Manheimer" <ken.manheimer@gmail.com> wrote:
> thank you!  allout's encryption seems to be working with your reversion.

Aside from the reversion of pgg-gpg.el, when I looked into allout.el's
encryption stuff, I found that 4 undocumented non-interface functions
of pgg-gpg are used:

pgg-gpg-lookup-key-owner
pgg-gpg-symmetric-key-p
pgg-gpg-select-matching-key
pgg-gpg-key-id-from-key-owner 

Fortunately, the latter 3 functions do _not_ call "gpg".  Ken, would you
please copy these functions from pgg-gpg.el into allout.el and replace
s/pgg-gpg/allout/?  Otherwise, these functions may be abolished again in
the future version of PGG.

pgg-gpg-lookup-key-owner needs to be implemented as an interface
function.  I'm now working on this.

Regards,
-- 
Daiki Ueno

Bad usage of pgg-gpg-* functions in allout.el

[Daiki Ueno]

>>>>> In <2595ece8-1a2b-48e5-a905-b37bd890ecae_-_@well-done.deisui.org> 
>>>>>	Daiki Ueno <ueno@unixuser.org> wrote:
> >>>>> In <2cd46e7f0604061550j44c97f68v4c6cffda79a4e0ce@mail.gmail.com> 
> >>>>>	"Ken Manheimer" <ken.manheimer@gmail.com> wrote:
> > thank you!  allout's encryption seems to be working with your reversion.

> Aside from the reversion of pgg-gpg.el, when I looked into allout.el's
> encryption stuff, I found that 4 undocumented non-interface functions
> of pgg-gpg are used:

> pgg-gpg-lookup-key-owner

> pgg-gpg-lookup-key-owner needs to be implemented as an interface
> function.  I'm now working on this.

>>>>> In <5451ce4a-1627-439f-9cba-308911539eae@well-done.deisui.org> 
>>>>>	Daiki Ueno <ueno@unixuser.org> wrote:
> Patch from Gnus' trunk is attached.  Major changes are listed below.

> * Added new interface function pgg-list-keys.  This function returns
> more information about keys than pgg-lookup-key.  For example:

With this function, a function which does the same thing as
pgg-gpg-lookup-key-owner can be implemented.

(defun allout-lookup-key-owner (string &optional all)
  "Search keys associated with STRING and return owner of identified key.

The value may be just the bare key id, or it may be a combination of the
user name associated with the key and the key id, with the key id enclosed
in \"<...>\" angle brackets.

Optional ALL non-nil means search all keys, including secret keys."
  (let ((keys (pgg-gpg-list-keys string all))
	entry)
    (while keys
      (setq entry (assq 'user-id (assq 'uid (car keys))))
      (if entry
	  (setq keys nil)
	(setq keys (cdr keys))))
    (cdr entry)))

(allout-lookup-key-owner "ueno")
=> "Daiki Ueno <ueno@unixuser.org>"

Regards,
-- 
Daiki Ueno