From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata Date: Mon, 26 Apr 2021 12:01:56 +0200 Message-ID: References: <39c93100-a352-538d-717a-663bcc5de296@yandex.ru> <23ebdd80-3ca2-4166-beab-e2535b6cc646@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40207"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Protesilaos Stavrou , Gregory Heytings , Dmitry Gutov , "emacs-devel@gnu.org" To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 26 12:03:56 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lay5r-000AHP-5K for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Apr 2021 12:03:55 +0200 Original-Received: from localhost ([::1]:49688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lay5q-0004JR-6s for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Apr 2021 06:03:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47346) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lay48-000301-Bz for emacs-devel@gnu.org; Mon, 26 Apr 2021 06:02:08 -0400 Original-Received: from server.qxqx.de ([2a01:4f8:121:346::180]:59607 helo=mail.qxqx.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lay42-0000gt-RT for emacs-devel@gnu.org; Mon, 26 Apr 2021 06:02:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QBB6nSyLN9hPjwZhtcWMmXQYcQC05psYYDJ5hiiTTDY=; b=I1X0zG69pxkEVgWsHv48A1muA4 AjyszzMxzq6wT0ZumAWpplZKL0hgGWZTIKEzIPMDsEGpToj07oDNew/dqc5/CZ3V0ZiCa+evvfZpV 8gBvhYBPJfIF8VNRxO9ObksOm+OluC6hb+CUJMthneZsVqHh2pmCOLU5rjal8QcFGgeI=; In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a01:4f8:121:346::180; envelope-from=mail@daniel-mendler.de; helo=mail.qxqx.de X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268449 Archived-At: On 4/26/21 1:33 AM, Stefan Monnier wrote: >> So it's better if at least icomplete-mode is enabled, preferably with an >> option which shows the completions right away with no input. And the >> vertical style should be even better. > > Maybe we could accommodate this in the default UI by adding an option to > eagerly popup the *Completions* buffer (and keep it updated as long as > it's displayed) and to keep it disabled by default but make it possible > to enable it via completion-category-(overrides|defaults). Yes, this sounds useful. It is similar to the configuration by Protesilaos Stavrou, as he described in his other mail. However Protesilaos' solution is more feature-rich and is always turned on. Maybe it makes sense to integrate such enhancements directly in minibuffer.el. An alternative is a small package providing a minor-mode in the style of Icomplete. All in all, the default completion UI should not be neglected when adding new metadata like a `group-function`. Daniel