From: Drew Adams <drew.adams@oracle.com>
To: Pierre-Yves Luyten <py@luyten.fr>, emacs-devel@gnu.org
Cc: Karl Fogel <kfogel@red-bean.com>
Subject: RE: [PATCH] open bookmark in other frame
Date: Wed, 10 Oct 2018 22:06:24 +0000 (UTC) [thread overview]
Message-ID: <cd629f00-aa1d-4ec6-84bd-b8c760820940@default> (raw)
In-Reply-To: <9d4a9ab3-d802-447e-3c74-81373b7e6101@luyten.fr>
> people sometimes use several frames, so i would like to make opening
> bookmark one shot. Attached patch adds two funcs,
> "bookmark-jump-other-frame" and the equivalent from the bookmarks menu,
> "bookmark-bmenu-other-frame"
My suggestions in this regard, FWIW:
1. Don't use `view-buffer-other-frame'.
Select the buffer, and not just read-only. Jumping to a bookmark
typically puts you at its location (hence select), and the buffer is
typically not put in a read-only mode. IOW, do the equivalent of
this, or similar:
(let ((pop-up-frames t)) (bookmark-jump-other-window bookmark)
2. Don't use `F' as the key binding in the bookmark-list buffer.
`F' is more often used for files than for frames. Maybe use `5'.
(I use `J 5' in Bookmark+. `J' is a prefix for the jump commands
in the bookmark-list buffer. The `5' is from `C-x 5' bindings for
other-frame. I bind the command to `C-x 5 B' and `C-x j 5' globally.
`C-x j' is a global prefix key for bookmark jump commands.)
next prev parent reply other threads:[~2018-10-10 22:06 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-10 20:14 [PATCH] open bookmark in other frame Pierre-Yves Luyten
2018-10-10 20:16 ` Marcin Borkowski
2018-10-10 21:35 ` Karl Fogel
2018-10-11 11:42 ` Pierre-Yves Luyten
2018-10-10 22:06 ` Drew Adams [this message]
2018-10-11 7:19 ` Karl Fogel
2018-10-11 11:30 ` Pierre-Yves Luyten
2018-10-11 13:35 ` Drew Adams
2018-10-11 21:50 ` Pierre-Yves Luyten
2018-10-11 22:04 ` Drew Adams
2018-10-12 19:45 ` Pierre-Yves Luyten
2018-10-12 21:23 ` Karl Fogel
2018-10-14 19:45 ` Pierre-Yves Luyten
2018-10-16 2:09 ` Karl Fogel
2018-10-16 9:51 ` Pierre-Yves Luyten
2018-10-16 2:10 ` Karl Fogel
2018-11-02 18:55 ` Karl Fogel
2018-11-04 21:10 ` Pierre-Yves Luyten
2018-11-09 0:54 ` Karl Fogel
2018-10-13 15:04 ` Stephen Leake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cd629f00-aa1d-4ec6-84bd-b8c760820940@default \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=kfogel@red-bean.com \
--cc=py@luyten.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).