From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master ff3f17ca3cd: choose-completion: Retain the suffix after completion boundary Date: Wed, 29 May 2024 13:37:01 +0300 Message-ID: References: <171522198055.22327.4428936546182324178@vcs2.savannah.gnu.org> <20240509023301.A25B3C1F9DE@vcs2.savannah.gnu.org> <7be03e7e-6b8a-420c-b0d8-a512d7917cf2@gutov.dev> <8f3b86fa-a7ee-4ef0-8953-944efb65f9df@gutov.dev> <418c5f45-9f89-43dd-b8b8-00f0aab9192b@gutov.dev> <5baa5d54-2fff-4cc6-8bb5-a46976cb8b33@gutov.dev> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11016"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: emacs-devel@gnu.org To: Eshel Yaron Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Wed May 29 12:38:00 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sCGgv-0002ca-Cu for ged-emacs-devel@m.gmane-mx.org; Wed, 29 May 2024 12:37:57 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sCGgB-0007oq-0t; Wed, 29 May 2024 06:37:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCGg9-0007od-1W for emacs-devel@gnu.org; Wed, 29 May 2024 06:37:09 -0400 Original-Received: from wfhigh5-smtp.messagingengine.com ([64.147.123.156]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sCGg7-0008PI-6c for emacs-devel@gnu.org; Wed, 29 May 2024 06:37:08 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfhigh.west.internal (Postfix) with ESMTP id 66FFE180015A; Wed, 29 May 2024 06:37:04 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 29 May 2024 06:37:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1716979024; x=1717065424; bh=xLDvIxTsRDRCsXT1BMCb0N/zYDad2VdyvBEGditAPyY=; b= AOWcSrYbBBNbRryHVIPeVOlaOJ5PkfoYt5XUYziuTVnmh2C1TQnE3hhFPw0BNfDI 2d2QcI6fKsiUDxpqTaIqoSZVhBsnaOLBN5oeIcC7gKg968si0L85p21mentEdREn ldQ11e3z4aDUQY8W7TK6jpQ3AtmRz0ohZvXH11rZ6LZhAI3UryYGxi81byvj9F+O w8MJ+/1LPebeLBHtjsTQCKGBvbhot9s/sxSqE2bMRa5+HykiCFXxgCQ7vadzDtbs 45U2h5WO/9KGC0x+KmBY1skFIH3cZ1LT5Utmu3YNjOYetAQ7XQU3xPsKUDuv0qwh 4cLVgbAhwafwVch/qnS/8g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1716979024; x= 1717065424; bh=xLDvIxTsRDRCsXT1BMCb0N/zYDad2VdyvBEGditAPyY=; b=Y 31uArNjJODAwDDFsVcq6nS82HFU0ji4BS3vZQONBQZs39ZgJpqxPTRwTew7HMYZ+ kDCp7B1Kbzc6sM33mFdi6brs2FbhfcaoMN7n5KJbU1ruEyxeEYNyssyAHm4lMY+D yRFTbB0sOZSWQe6oPQUoMC4GfYgZVDbBim2b7zO92XkJDTgFDBxbznLeNFJGGWHZ rovoUHg1JRiLnxqQVX8LIAIJ/C3zYjIEY341X9F+CBKpUPJja+Gv/ijNenrMlD2U exEFQZ1PhOD925GH0ydzCWK17PB/aW+uREUgj0FoR6Gli4bzf1b0fOl/Y2cEChMj WVTOKAdUkE5h+SABMW94Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrvdekuddgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfevfhfhjggtgfesth ejredttddvjeenucfhrhhomhepffhmihhtrhihucfiuhhtohhvuceoughmihhtrhihsehg uhhtohhvrdguvghvqeenucggtffrrghtthgvrhhnpeetudeljeegheetgfehgeejkeeuhe dvveeikeeufedtvddtveefhfdvveegudejheenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpegumhhithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 29 May 2024 06:37:02 -0400 (EDT) Content-Language: en-US In-Reply-To: Received-SPF: pass client-ip=64.147.123.156; envelope-from=dmitry@gutov.dev; helo=wfhigh5-smtp.messagingengine.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01, URIBL_SBL_A=0.1 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319679 Archived-At: On 29/05/2024 13:05, Eshel Yaron wrote: >>> I agree. The default completion UI supports various interactions >>> that >>> can break in subtle ways, and that's without even configuring stuff. >>> I'll try to code a couple of test cases when I have the time. >> That would be very welcome, thanks. > I've now added basic regression tests for the issues we discussed here > to minibuffer-tests.el (commit a9af70849d2). Nice! Thank you.