From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Checking in files with trailing white space Date: Mon, 12 Dec 2016 14:57:42 -0800 Organization: UCLA Computer Science Department Message-ID: References: <20161211133110.GB14084@acm.fritz.box> <20161212221642.GA4361@acm.fritz.box> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------4BEC020EF2F0F6B2A93BD0BC" X-Trace: blaine.gmane.org 1481586670 5283 195.159.176.226 (12 Dec 2016 23:51:10 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 12 Dec 2016 23:51:10 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 Cc: emacs-devel@gnu.org To: Alan Mackenzie , Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Dec 13 00:51:06 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cGaN4-00008c-SE for ged-emacs-devel@m.gmane.org; Tue, 13 Dec 2016 00:51:02 +0100 Original-Received: from localhost ([::1]:34280 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGaN9-00019y-0e for ged-emacs-devel@m.gmane.org; Mon, 12 Dec 2016 18:51:07 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46045) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cGZXZ-0006eY-NX for emacs-devel@gnu.org; Mon, 12 Dec 2016 17:57:50 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cGZXU-0007fv-QX for emacs-devel@gnu.org; Mon, 12 Dec 2016 17:57:49 -0500 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:53828) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1cGZXU-0007fe-G6 for emacs-devel@gnu.org; Mon, 12 Dec 2016 17:57:44 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 07B9316006E; Mon, 12 Dec 2016 14:57:43 -0800 (PST) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id jc5lsKzZsyPw; Mon, 12 Dec 2016 14:57:42 -0800 (PST) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 4F2D8160075; Mon, 12 Dec 2016 14:57:42 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id Ct-Cjz0SESR9; Mon, 12 Dec 2016 14:57:42 -0800 (PST) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 337C016006E; Mon, 12 Dec 2016 14:57:42 -0800 (PST) In-Reply-To: <20161212221642.GA4361@acm.fritz.box> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:210386 Archived-At: This is a multi-part message in MIME format. --------------4BEC020EF2F0F6B2A93BD0BC Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/12/2016 02:16 PM, Alan Mackenzie wrote: > However, this absolute prohibition on trailing spaces is fascistic. > Some files (for example, test files) have essential trailing spaces in > them I added a comment to the pre-commit file to help out others in your situation; see the attached patch. As it is all too easy to overlook trailing white space when reading source code, I'd rather avoid having significant whitespace in committed files. If I were writing those test cases, I'd commit files that didn't have trailing whitespace, and convert them to files-with-trailing-whitespace while running the test. Similarly, I'd rather avoid committing binary data. It's easier to read and review text files, given the tools we have. Any tests that require binary data can generate the data when the test is run. --------------4BEC020EF2F0F6B2A93BD0BC Content-Type: application/x-patch; name="0001-build-aux-git-hooks-pre-commit-Add-whitespace-commen.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-build-aux-git-hooks-pre-commit-Add-whitespace-commen.pa"; filename*1="tch" RnJvbSBlNGIyNjM4YzY1MjNjZTE4NGY1ZjE4M2U5YzU3YjNjZTBiYmVmMzdjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBNb24sIDEyIERlYyAyMDE2IDE0OjU0OjMwIC0wODAwClN1YmplY3Q6IFtQQVRD SF0gKiBidWlsZC1hdXgvZ2l0LWhvb2tzL3ByZS1jb21taXQ6IEFkZCB3aGl0ZXNwYWNlIGNv bW1lbnQuCgotLS0KIGJ1aWxkLWF1eC9naXQtaG9va3MvcHJlLWNvbW1pdCB8IDggKysrKysr KysKIDEgZmlsZSBjaGFuZ2VkLCA4IGluc2VydGlvbnMoKykKCmRpZmYgLS1naXQgYS9idWls ZC1hdXgvZ2l0LWhvb2tzL3ByZS1jb21taXQgYi9idWlsZC1hdXgvZ2l0LWhvb2tzL3ByZS1j b21taXQKaW5kZXggNWE1MTI0NC4uMzcwOTc4NCAxMDA3NTUKLS0tIGEvYnVpbGQtYXV4L2dp dC1ob29rcy9wcmUtY29tbWl0CisrKyBiL2J1aWxkLWF1eC9naXQtaG9va3MvcHJlLWNvbW1p dApAQCAtNDUsNCArNDUsMTIgQEAgbmJhZGNoYXJzPQogICBlc2FjCiBkb25lCiAKKyMgVGhl ICctLWNoZWNrJyBvcHRpb24gb2YgZ2l0IGRpZmYtaW5kZXggbWFrZXMgR2l0IGNvbXBsYWlu IGlmIGNoYW5nZXMKKyMgaW50cm9kdWNlIHdoaXRlc3BhY2UgZXJyb3JzLiAgVGhpcyBjYW4g YmUgYSBwYWluIHdoZW4gZWRpdGluZyB0ZXN0CisjIGZpbGVzIHRoYXQgZGVsaWJlcmF0ZWx5 IGNvbnRhaW4gbGluZXMgd2l0aCB0cmFpbGluZyB3aGl0ZXNwYWNlLgorIyBUbyB3b3JrIGFy b3VuZCB0aGUgcHJvYmxlbSB5b3UgY2FuIHJ1biBhIGNvbW1hbmQgbGlrZSAnZ2l0IGNvbmZp ZworIyBjb3JlLndoaXRlc3BhY2UgLXRyYWlsaW5nLXNwYWNlJy4gIEl0IG1heSBiZSBiZXR0 ZXIgdG8gcmV2YW1wIHRoZQorIyB0ZXN0cyBzbyB0aGF0IHRyYWlsaW5nIHNwYWNlcyBhcmUg Z2VuZXJhdGVkIG9uIHRoZSBmbHkgcmF0aGVyIHRoYW4KKyMgYmVpbmcgY29tbWl0dGVkIGFz IHNvdXJjZS4KKwogZXhlYyBnaXQgZGlmZi1pbmRleCAtLWNoZWNrIC0tY2FjaGVkIEhFQUQg LS0KLS0gCjIuNy40Cgo= --------------4BEC020EF2F0F6B2A93BD0BC--