From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master cc5325b: Pacify -Wcast-function-type warnings in GCC 8.1 Date: Mon, 20 Aug 2018 10:45:40 -0400 Message-ID: References: <20180817143134.25638.77810@vcs0.savannah.gnu.org> <20180817143136.6E89A209C7@vcs0.savannah.gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1534776262 3333 195.159.176.226 (20 Aug 2018 14:44:22 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 20 Aug 2018 14:44:22 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 To: Andy Moreton , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 20 16:44:18 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1frlPl-0000jG-Od for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 16:44:17 +0200 Original-Received: from localhost ([::1]:47524 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frlRs-0004kk-4D for ged-emacs-devel@m.gmane.org; Mon, 20 Aug 2018 10:46:28 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58250) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frlRF-0004kU-95 for emacs-devel@gnu.org; Mon, 20 Aug 2018 10:45:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1frlRC-0008RP-In for emacs-devel@gnu.org; Mon, 20 Aug 2018 10:45:49 -0400 Original-Received: from limerock04.mail.cornell.edu ([128.84.13.244]:45650) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1frlRC-0008Qx-E4 for emacs-devel@gnu.org; Mon, 20 Aug 2018 10:45:46 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite3.serverfarm.cornell.edu [10.16.197.8]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id w7KEjiiI007132; Mon, 20 Aug 2018 10:45:44 -0400 Original-Received: from [192.168.0.15] (mta-68-175-129-7.twcny.rr.com [68.175.129.7] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id w7KEjgSA012619 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 20 Aug 2018 10:45:43 -0400 In-Reply-To: Content-Language: en-US X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 128.84.13.244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:228726 Archived-At: On 8/20/2018 10:18 AM, Andy Moreton wrote: > On Mon 20 Aug 2018, Ken Brown wrote: > >> On 8/17/2018 10:31 AM, Eli Zaretskii wrote: >>> branch: master >>> commit cc5325b0bea13bd93478fcee0b035877b3a72290 >>> Author: Andy Moreton >>> Commit: Eli Zaretskii >>> >>> Pacify -Wcast-function-type warnings in GCC 8.1 >>> * src/w32.h: (get_proc_addr): New function. >>> * src/w32fns.c (setup_w32_kbdhook, Ffile_system_info) >>> * src/w32uniscribe.c (syms_of_w32uniscribe): Use get_proc_addr. >> >> This breaks the Cygwin-w32 build because w32fns.c and w32uniscribe.c don't >> include w32.h on Cygwin, so get_proc_addr is undefined. Could the definition >> of get_proc_addr be moved to a different header that gets included in the >> Cygwin build? Maybe w32common.h? > > Sorry Ken, I forgot to test this Cygwin as well as mingw32 and mingw64. > Does something like this patch work for you ? Yes, that fixes it. Thanks. Ken