From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 82ccc3a: ; Mention the previous change in NEWS Date: Tue, 8 Jun 2021 17:46:16 +0300 Message-ID: References: <83lf7lfwc8.fsf@gnu.org> <835yyoft5k.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28206"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Jun 08 16:48:30 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lqd1q-0007AE-JC for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Jun 2021 16:48:30 +0200 Original-Received: from localhost ([::1]:49744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lqd1p-0003vP-GZ for ged-emacs-devel@m.gmane-mx.org; Tue, 08 Jun 2021 10:48:29 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39476) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lqczo-0001iY-3K for emacs-devel@gnu.org; Tue, 08 Jun 2021 10:46:24 -0400 Original-Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:36509) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lqczm-0004rh-2Y; Tue, 08 Jun 2021 10:46:23 -0400 Original-Received: by mail-wm1-x330.google.com with SMTP id h11-20020a05600c350bb02901b59c28e8b4so1657989wmq.1; Tue, 08 Jun 2021 07:46:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=L9TRouET+AdLXObQorEW+tKlpXm6dNY7wwAijyA9JBI=; b=ETOAP4h2LTwHHRQ4XhQsmJHD8V/GU+XvT3W2+8AVfUCOeO/ZuzV9fkY+Ks3fiONfdX MmcG/rQTxhSKdZa6eUYWEGUtXjAj/AP6rbz8+FS96s49QVR/wthtSFdN457sQhAZn+JG DffF87e49ipIHaq2+paKQZOAJ9tBVvfrKEbGq/QGn9SNRnrDvmAUxgicimyibWmd0S6D GWlZ3kzCNvcoJTUCycKtjUNGLMB/PUDZd1jRnIqq7qLPNGIchdF/xJ3c3KHkUIxxIfiD T6qgGf9NCTlxblszJ+VPUDrT7jebr7dVXug5SBz9MkO8XQIzhM7iYFPO57WwYSmjDdaH Ls5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=L9TRouET+AdLXObQorEW+tKlpXm6dNY7wwAijyA9JBI=; b=GYywudJeye6LVjEkhpJQVVtNDmYqut0p3l9Z9RgNwh1ERpr1tlNXqzkJp7+INpGLY0 8T9ahOXy7PRB9K0qOKKlYdgDqhIdgCwNGqaYWPLCQWAboFJlF6qUH5q68VzLtXCWJEC1 9CBbfK5xgcP4dNIORjPj6B6eItfTWfEPepZPGMP6WuYFtvWWvZGr6/RCI3xUwm520th1 /7c7th86BBAAbW+zOBTh2xjyXty4f3V79yJa5tsrXeqAsQeogDW1fUOJLqoY4Nlpmo+k FG1bByHmq/bZK5rK8d8F/01HmcWnDQikfBob4UJ+k8sWPn5hF5Y9L57wuY9ba1PzWu8Q qF8w== X-Gm-Message-State: AOAM532yjT456c3zF1Bg7zKfuwaZiUidpByEKxMsUqXZTLKGesbsa5zA 5VTUOU41agIyq233KNW4TtBSoGYtt18= X-Google-Smtp-Source: ABdhPJyclIuWYrx+aYhxnvqJl4NSCTpNtDZDA+L6514r4qCOrO+8napv13RJrJqrurMuzvquHW3BCw== X-Received: by 2002:a05:600c:22d9:: with SMTP id 25mr4792973wmg.152.1623163579683; Tue, 08 Jun 2021 07:46:19 -0700 (PDT) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id g17sm15356976wrp.61.2021.06.08.07.46.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 08 Jun 2021 07:46:18 -0700 (PDT) In-Reply-To: <835yyoft5k.fsf@gnu.org> Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=raaahh@gmail.com; helo=mail-wm1-x330.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.248, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.248, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270563 Archived-At: On 08.06.2021 15:16, Eli Zaretskii wrote: >> Cc: emacs-devel@gnu.org >> From: Dmitry Gutov >> Date: Tue, 8 Jun 2021 03:48:46 +0300 >> >> On 07.06.2021 19:55, Eli Zaretskii wrote: >>> I think it would be better to say something like >>> >>> *** Commands that use 'grep-find' now follow symlinks by default. >> >> Not exactly: going by the option's description in the manual, it follows >> symlinks for all arguments passed from the command line > > That's easily fixed, and isn't the main point of my message. Just helping get the details right. >>> This affects the following commends: 'rgrep', ... >>> >>> This describes the change in terms of user commands, but can you help >>> me comping up with the list of affected commands? >> >> I don't think there's any visible change in behavior because of that >> change. It mostly mirrored the one in 2e55201b8085 for better/uniform >> approach to the problem. > > If there's no visible change in behavior, why have this NEWS entry at > all? It's a prominent variable, and the change can affect other users of it, ones we don't control. It also might be handy to know of if some user does encounter a compatibility problem (as we discussed, it's unlikely, but still). >> The latter change fixed ignore entries not being applied by the default >> implementation of project-files with certain old versions of 'find'. >> >> rgrep, which also has some ignores to handle, uses "." as the DIR >> argument, so it should see no change. > > That's just the default, right? No, that's what it does: it passes for directory to search in through the value of default-directory. The argument to 'find' is always ".". >> xref-matches-in-directory has no known callers anymore, but any >> third-party code should see the IGNORES honored better with those old >> versions of 'find'. > > So we could say that any command which uses xref-matches-in-directory > is affected. Is that better than saying that the variable changed? Possibly affecting any code that uses it is an obvious implication. We can say that about xref-matches-in-directory, noting that the change is likely to only be noticeable with old versions of 'find'. Which apparently includes macOS systems, but I'm not sure which ones, and whether using "Homebrew" or not matters for this case. Also, we'll probably mark xref-matches-in-directory as obsolete sooner or later (xref-matches-in-files is generally a better, more composable choice), so I'm not sure how much attention we should bring to it. >> And as for following the symlinks, the existing users of >> grep-find-template, which were changed, previously used a different >> approach: having DIR end with '/' (hence the file-name-as-directory >> calls which were replaced with directory-file-name calls). > > Once again, if nothing's changed, why did you decide to add this > entry? I guess you thought it had some importance. I just think we > should better explain what have really changed, and doing that in the > terms of a not-so-simple value of an option doesn't make that clear. I figured you wanted to enumerate the exact commands that were affected. Hence the reply.