From: Paul Eggert <eggert@cs.ucla.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Emacs release branch warnings with GCC 8
Date: Mon, 30 Apr 2018 12:52:59 -0700 [thread overview]
Message-ID: <c991404b-7075-fc74-619e-302fc639bfbf@cs.ucla.edu> (raw)
In-Reply-To: <83y3h4qybl.fsf@gnu.org>
On 04/30/2018 12:38 PM, Eli Zaretskii wrote:
> But a release tarball is not built with --enable-gcc-warnings by
> default, right?
Right. This is about people who build from a release tarball with
--enable-gcc-warnings, and about people who build from Git (the latter
appear to be a growing number....).
>
>> I've patched the master to fix this problem in commits
>> 2b9ab8c8fba849da8bf2aa45e65b122bb937a6b3 and
>> 8c3215e7a47e3caaa005bf573765ed63e0739b89, and could backport these
>> patches (or a subset) to emacs-26 if there's interest.
> I'm okay with the first one, but I don't understand how the warnings
> you've shown are related to the ATTRIBUTE_MALLOC changes in the second
> commit.
The first commit enables -Wsuggest-attribute=malloc, and the
ATTRIBUTE_MALLOC changes in the second commit then pacifies GCC in that
area. We could change the first commit to not enable
-Wsuggest-attribute=malloc and this would simplify the second commit,
though we'd then be differing from Gnulib in the first commit.
next prev parent reply other threads:[~2018-04-30 19:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 17:12 Emacs release branch warnings with GCC 8 Paul Eggert
2018-04-30 19:38 ` Eli Zaretskii
2018-04-30 19:52 ` Paul Eggert [this message]
2018-04-30 19:58 ` Eli Zaretskii
2018-05-01 0:22 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c991404b-7075-fc74-619e-302fc639bfbf@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).