From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Experimental regexp check: repetition of empty-matching expression Date: Fri, 19 Apr 2019 08:24:56 -0700 Organization: UCLA Computer Science Department Message-ID: References: <30C4697B-B2C4-48F3-B01E-B17C00C152B4@acm.org> <6820fa9a-b99d-d2ad-ee28-1145f545ebda@cs.ucla.edu> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------189F4B9A0EEF1CCD0DBC4452" Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="142388"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 Cc: Emacs developers To: =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Apr 19 17:34:51 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hHVXO-000auq-Kw for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 17:34:50 +0200 Original-Received: from localhost ([127.0.0.1]:57914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHVXN-0007Rd-Mf for ged-emacs-devel@m.gmane.org; Fri, 19 Apr 2019 11:34:49 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:41986) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hHVVq-0006aY-Jj for emacs-devel@gnu.org; Fri, 19 Apr 2019 11:33:15 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hHVNs-0003tf-6j for emacs-devel@gnu.org; Fri, 19 Apr 2019 11:25:01 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60846) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1hHVNr-0003rx-Ng for emacs-devel@gnu.org; Fri, 19 Apr 2019 11:25:00 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id E220016179B; Fri, 19 Apr 2019 08:24:57 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 6UKsSD-sjFEq; Fri, 19 Apr 2019 08:24:56 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6FE2B161777; Fri, 19 Apr 2019 08:24:56 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id E789-jlo1pxP; Fri, 19 Apr 2019 08:24:56 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 52DB9160F1A; Fri, 19 Apr 2019 08:24:56 -0700 (PDT) Openpgp: preference=signencrypt Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= xsFNBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABzSBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PsLBfgQTAQIAKAUCTIByZAIbAwUJEswDAAYLCQgHAwIG FQgCCQoLBBYCAwECH In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:235663 Archived-At: This is a multi-part message in MIME format. --------------189F4B9A0EEF1CCD0DBC4452 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 4/13/19 1:09 AM, Mattias Engdeg=C3=A5rd wrote: > > --- a/lisp/mail/mail-extr.el > +++ b/lisp/mail/mail-extr.el > @@ -383,7 +383,7 @@ mail-extr-initial-pattern > ;; Matches telephone extensions. > (defconst mail-extr-telephone-extension-pattern > (purecopy > - "\\(\\([Ee]xt\\|\\|[Tt]ph\\|[Tt]el\\|[Xx]\\).?\\)? *\\+?[0-9][- 0-9= ]+")) > + "\\(\\([Ee]xt\\|[Tt]ph\\|[Tt]el\\|[Xx]\\).?\\)? *\\+?[0-9][- 0-9]+"= )) > ^ > Doesn't it look like the dot is meant to be escaped? Yes, and I installed the attached patch to fix that. Thanks. > =20 > --- a/lisp/net/tramp-adb.el > +++ b/lisp/net/tramp-adb.el > @@ -53,7 +53,7 @@ tramp-adb-method > "When this method name is used, forward all calls to Android Debug B= ridge.") > =20 > (defcustom tramp-adb-prompt > - "^\\(?:[[:digit:]]*|?\\)?\\(?:[[:alnum:]\e;[]*@?[[:alnum:]]*[^#\\$]*= \\)?[#\\$][[:space:]]" > + "^[[:digit:]]*|?\\(?:[[:alnum:]\e;[]*@?[[:alnum:]]*[^#\\$]*\\)?[#\\$= ][[:space:]]" > ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^ > There is a second one a bit later in the same regexp. > Michael already fixed this. --------------189F4B9A0EEF1CCD0DBC4452 Content-Type: text/x-patch; name="0001-Fix-mail-extr-regexp-typo-with.patch" Content-Disposition: attachment; filename="0001-Fix-mail-extr-regexp-typo-with.patch" Content-Transfer-Encoding: quoted-printable >From 938a6c6fa8e8685539590df402e749428d04ca06 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Fri, 19 Apr 2019 08:23:15 -0700 Subject: [PATCH] Fix mail-extr regexp typo with ".". MIME-Version: 1.0 Content-Type: text/plain; charset=3DUTF-8 Content-Transfer-Encoding: 8bit Problem reported by Mattias Engdeg=C3=A5rd in: https://lists.gnu.org/r/emacs-devel/2019-04/msg00543.html * lisp/mail/mail-extr.el (mail-extr-telephone-extension-pattern): Escape the trailing optional period after an abbreviation. --- lisp/mail/mail-extr.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/mail/mail-extr.el b/lisp/mail/mail-extr.el index a0b9688650..c1e90c3dcb 100644 --- a/lisp/mail/mail-extr.el +++ b/lisp/mail/mail-extr.el @@ -383,7 +383,7 @@ mail-extr-initial-pattern ;; Matches telephone extensions. (defconst mail-extr-telephone-extension-pattern (purecopy - "\\(\\([Ee]xt\\|[Tt]ph\\|[Tt]el\\|[Xx]\\).?\\)? *\\+?[0-9][- 0-9]+")) + "\\(\\([Ee]xt\\|[Tt]ph\\|[Tt]el\\|[Xx]\\)\\.?\\)? *\\+?[0-9][- 0-9]+"= )) =20 ;; Matches ham radio call signs. ;; Help from: Mat Maessen N2NJZ , Mark Feit --=20 2.20.1 --------------189F4B9A0EEF1CCD0DBC4452--