* Is emacsclient --eval broken?
@ 2016-08-03 15:32 Clément Pit--Claudel
2016-08-06 10:09 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Clément Pit--Claudel @ 2016-08-03 15:32 UTC (permalink / raw)
To: Emacs developers
[-- Attachment #1.1.1: Type: text/plain, Size: 2756 bytes --]
Hey emacs-dev,
I'm seeing surprising behaviour from emacsclient --eval:
$ emacs -Q --daemon
…
Starting Emacs daemon.
$ emacsclient --eval '(progn (find-file "emacsclient-input") (buffer-string))'
"\\EEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEEE EEEEEEEEEEEEE EEE EEEEEE EEEEE\n\\EEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEE EEEEE\n\n\\EEEEEEEEEEE\\EEEEEEEEE\\EEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEE\\EEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEE\\EEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEE\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEE\n\n\n\\EEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEEEEEEE\n\\EEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEE\\EEEEEEEEE\n\\EEEEEEEEEEEEEEE\\EEEEEEEEEEE\\EEEEEEEEE E EEEEE\n\n\\EEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEE\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEEEEE\n\\EEEEEEEEEEE\n\nEE EEE-EEEEEEE \\EEEEEEEEEEEEEEEEEE\nEE EEE-EEEEEEE \\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEE\n\nEEEEEE EEEE
*ERROR*: Unknown message: E EE EEEEE\n"
This error message isn't in emacsclient-input. Worse, it is not even deterministic:
$ emacsclient --eval '(progn (find-file "emacsclient-input") (buffer-string))'
"\\EEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEEE EEEEEEEEEEEEE EEE EEEEEE EEEEE\n\\EEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEE EEEEE\n\n\\EEEEEEEEEEE\\EEEEEEEEE\\EEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEE\\EEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEE\\EEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEE\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEE\n\n\n\\EEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEEEEEEE\n\\EEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEE\\EEEEEEEEE\n\\EEEEEEEEEEEEEEE\\EEEEEEEEEEE\\EEEEEEEEE E EEEEE\n\n\\EEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEE\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEEEEE\n\\EEEEEEEEEEE\n\nEE EEE-EEEEEEE \\EEEEEEEEEEEEEEEEEE\nEE EEE-EEEEEEE \\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEE\n\nEEEEEE EEEE_EEEEE EE EEEEE\n"
(the output is still corrupted: there's no ‘_’ in the source file either).
I've attached emacsclient-input. Can someone help me figure what's going wrong? The error doesn't appear if I modify any of the backslashes, dashes, or newlines in the input...
Cheers,
Clément.
[-- Attachment #1.1.2: emacsclient-input --]
[-- Type: text/plain, Size: 935 bytes --]
\EEEEEEEEEEEEEEEEEEEEEE
\EEEEEEEEEEEEEEEEEEEE
\EEEEEEEEEEEEEE\EEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEEE EEEEEEEEEEEEE EEE EEEEEE EEEEE
\EEEEEEEEEEEEEE\EEEEEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEE EEEEE
\EEEEEEEEEEE\EEEEEEEEE\EEEEEEEEEEE
\EEEEEEEEEEEEEEEEEEEEEEE\EEEEEEEEEEE\EEEEEEEEEEE
\EEEEEEEEEEEEEEEEEEEEEEE\EEEEEEEEEEEEEEEE\EEEEEEEE
\EEEEEEEEEEEEEEEEEEEEEEEEE\EEEEEEEEEE\EEEEEEEEEEEEEEE\EEEEEEEEE\EEEE
\EEEEEEEEEEEEEEEEEEEEEE
\EEEEEEEEEEEEEEEEEEEEEEEE
\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEE
\EEEEEEEEEEEEEEE\EEEEEEEEE\EEEEEEEEE
\EEEEEEEEEEEEEEE\EEEEEEEEEEEEEEEE\EEEEEEEEE
\EEEEEEEEEEEEEEE\EEEEEEEEEEE\EEEEEEEEE E EEEEE
\EEEEEEEEEEEE
\EEEEEEEEEEEEEEEEEEEEEEE\EEEEEEEEEEEEEEEEEEEEEEEE\EEEEEEEEEE\EEEEEEEEEEEEEEE\EEEEEEEEE\EEEEEEE
\EEEEEEEEEEE
EE EEE-EEEEEEE \EEEEEEEEEEEEEEEEEE
EE EEE-EEEEEEE \EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE
\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE
\EEEEEEEEEEEEEEEEEEEE
\EEEEEEEEEEEEEEE
\EEEEEEEEEEEEE
EEEEEE EEEE EEEEE EE EEEEE
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Is emacsclient --eval broken?
2016-08-03 15:32 Is emacsclient --eval broken? Clément Pit--Claudel
@ 2016-08-06 10:09 ` Eli Zaretskii
2016-08-06 11:17 ` Johan Bockgård
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-08-06 10:09 UTC (permalink / raw)
To: Clément Pit--Claudel; +Cc: emacs-devel
> From: Clément Pit--Claudel <clement.pit@gmail.com>
> Date: Wed, 3 Aug 2016 11:32:33 -0400
>
> $ emacs -Q --daemon
> …
> Starting Emacs daemon.
>
> $ emacsclient --eval '(progn (find-file "emacsclient-input") (buffer-string))'
> "\\EEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEEE EEEEEEEEEEEEE EEE EEEEEE EEEEE\n\\EEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEE EEEEE\n\n\\EEEEEEEEEEE\\EEEEEEEEE\\EEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEE\\EEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEE\\EEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEE\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEE\n\n\n\\EEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEEEEEEE\n\\EEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEE\\EEEEEEEEE\n\\EEEEEEEEEEEEEEE\\EEEEEEEEEEE\\EEEEEEEEE E EEEEE\n\n\\EEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEE\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEEEEE\n\\EEEEEEEEEEE\n\
nEE EEE-EEEEEEE \\EEEEEEEEEEEEEEEEEE\nEE EEE-EEEEEEE \\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEE\n\nEEEEEE EEEE
> *ERROR*: Unknown message: E EE EEEEE\n"
>
> This error message isn't in emacsclient-input. Worse, it is not even deterministic:
>
> $ emacsclient --eval '(progn (find-file "emacsclient-input") (buffer-string))'
> "\\EEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEEE EEEEEEEEEEEEE EEE EEEEEE EEEEE\n\\EEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEEEEE-EEEEEEEEEEEE EEEEE\n\n\\EEEEEEEEEEE\\EEEEEEEEE\\EEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEE\\EEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEE\\EEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEE\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEE\n\n\n\\EEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEEEEEEE\n\\EEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEE\\EEEEEEEEE\n\\EEEEEEEEEEEEEEE\\EEEEEEEEEEE\\EEEEEEEEE E EEEEE\n\n\\EEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEEEEEEEEEEEEEEEE\\EEEEEEEEEE\\EEEEEEEEEEEEEEE\\EEEEEEEEE\\EEEEEEE\n\\EEEEEEEEEEE\n\
nEE EEE-EEEEEEE \\EEEEEEEEEEEEEEEEEE\nEE EEE-EEEEEEE \\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEEEEEEEEE\n\n\\EEEEEEEEEEEEEEE\n\\EEEEEEEEEEEEE\n\nEEEEEE EEEE_EEEEE EE EEEEE\n"
>
> (the output is still corrupted: there's no ‘_’ in the source file either).
>
> I've attached emacsclient-input. Can someone help me figure what's going wrong? The error doesn't appear if I modify any of the backslashes, dashes, or newlines in the input...
Put a breakpoint in Fsignal, and see who calls it and why.
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Is emacsclient --eval broken?
2016-08-06 10:09 ` Eli Zaretskii
@ 2016-08-06 11:17 ` Johan Bockgård
2016-08-06 11:21 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Johan Bockgård @ 2016-08-06 11:17 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Clément Pit--Claudel, emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
>> I've attached emacsclient-input. Can someone help me figure what's
>> going wrong? The error doesn't appear if I modify any of the
>> backslashes, dashes, or newlines in the input...
>
> Put a breakpoint in Fsignal, and see who calls it and why.
The error comes from the emacsclient side:
$ git grep 'Unknown message'
lib-src/emacsclient.c: printf ("*ERROR*: Unknown message: %s\n", p);
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Is emacsclient --eval broken?
2016-08-06 11:17 ` Johan Bockgård
@ 2016-08-06 11:21 ` Eli Zaretskii
2016-08-06 15:23 ` Clément Pit--Claudel
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-08-06 11:21 UTC (permalink / raw)
To: Johan Bockgård; +Cc: clement.pit, emacs-devel
> From: Johan Bockgård <bojohan@gnu.org>
> Cc: Clément Pit--Claudel <clement.pit@gmail.com>,
> emacs-devel@gnu.org
> Date: Sat, 06 Aug 2016 13:17:07 +0200
>
> Eli Zaretskii <eliz@gnu.org> writes:
>
> >> I've attached emacsclient-input. Can someone help me figure what's
> >> going wrong? The error doesn't appear if I modify any of the
> >> backslashes, dashes, or newlines in the input...
> >
> > Put a breakpoint in Fsignal, and see who calls it and why.
>
> The error comes from the emacsclient side:
>
> $ git grep 'Unknown message'
> lib-src/emacsclient.c: printf ("*ERROR*: Unknown message: %s\n", p);
Thanks. What is the message received from the server that triggers
this?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Is emacsclient --eval broken?
2016-08-06 11:21 ` Eli Zaretskii
@ 2016-08-06 15:23 ` Clément Pit--Claudel
2016-08-06 15:30 ` Eli Zaretskii
0 siblings, 1 reply; 10+ messages in thread
From: Clément Pit--Claudel @ 2016-08-06 15:23 UTC (permalink / raw)
To: Eli Zaretskii, Johan Bockgård; +Cc: emacs-devel
[-- Attachment #1.1: Type: text/plain, Size: 892 bytes --]
On 2016-08-06 07:21, Eli Zaretskii wrote:
>> From: Johan Bockgård <bojohan@gnu.org>
>> Cc: Clément Pit--Claudel <clement.pit@gmail.com>,
>> emacs-devel@gnu.org
>> Date: Sat, 06 Aug 2016 13:17:07 +0200
>>
>> Eli Zaretskii <eliz@gnu.org> writes:
>>
>>>> I've attached emacsclient-input. Can someone help me figure what's
>>>> going wrong? The error doesn't appear if I modify any of the
>>>> backslashes, dashes, or newlines in the input...
>>>
>>> Put a breakpoint in Fsignal, and see who calls it and why.
>>
>> The error comes from the emacsclient side:
>>
>> $ git grep 'Unknown message'
>> lib-src/emacsclient.c: printf ("*ERROR*: Unknown message: %s\n", p);
>
> Thanks. What is the message received from the server that triggers
> this?
The client print
*ERROR*: Unknown message: E EE EEEEE\n"
Is that the information you were looking for?
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Is emacsclient --eval broken?
2016-08-06 15:23 ` Clément Pit--Claudel
@ 2016-08-06 15:30 ` Eli Zaretskii
2016-08-15 19:08 ` Johan Bockgård
0 siblings, 1 reply; 10+ messages in thread
From: Eli Zaretskii @ 2016-08-06 15:30 UTC (permalink / raw)
To: Clément Pit--Claudel; +Cc: bojohan, emacs-devel
> Cc: emacs-devel@gnu.org
> From: Clément Pit--Claudel <clement.pit@gmail.com>
> Date: Sat, 6 Aug 2016 11:23:35 -0400
>
> >> $ git grep 'Unknown message'
> >> lib-src/emacsclient.c: printf ("*ERROR*: Unknown message: %s\n", p);
> >
> > Thanks. What is the message received from the server that triggers
> > this?
>
> The client print
>
> *ERROR*: Unknown message: E EE EEEEE\n"
>
> Is that the information you were looking for?
No, I wanted to know what came in from the server that caused this
message. See the code in emacsclient.c that follows the comment which
says "Wait for an answer." There must be something that the client
cannot interpret, or maybe we are not prepared to deal with strings
that span more than one packet returned by recv?
IOW, some more debugging is in order.
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: Is emacsclient --eval broken?
2016-08-06 15:30 ` Eli Zaretskii
@ 2016-08-15 19:08 ` Johan Bockgård
2016-08-18 19:39 ` Johan Bockgård
0 siblings, 1 reply; 10+ messages in thread
From: Johan Bockgård @ 2016-08-15 19:08 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Clément Pit--Claudel, emacs-devel
Eli Zaretskii <eliz@gnu.org> writes:
> There must be something that the client cannot interpret, or maybe we
> are not prepared to deal with strings that span more than one packet
> returned by recv?
The function in server.el that splits the reply has a bug:
diff --git a/lisp/server.el b/lisp/server.el
index 59fd973..650323d 100644
--- a/lisp/server.el
+++ b/lisp/server.el
@@ -782,7 +782,7 @@ (defun server-reply-print (qtext proc)
;; We have to split the string
(setq part (substring qtext 0 (- server-msg-size (length prefix) 1)))
;; Don't split in the middle of a quote sequence
- (if (string-match "\\(^\\|[^&]\\)\\(&&\\)+$" part)
+ (if (string-match "\\(^\\|[^&]\\)&\\(&&\\)*$" part)
;; There is an uneven number of & at the end
(setq part (substring part 0 -1)))
(setq qtext (substring qtext (length part)))
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: Is emacsclient --eval broken?
2016-08-15 19:08 ` Johan Bockgård
@ 2016-08-18 19:39 ` Johan Bockgård
2016-08-19 7:04 ` Eli Zaretskii
2016-08-22 15:25 ` Clément Pit--Claudel
0 siblings, 2 replies; 10+ messages in thread
From: Johan Bockgård @ 2016-08-18 19:39 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: Clément Pit--Claudel, emacs-devel
Fixed in master.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Is emacsclient --eval broken?
2016-08-18 19:39 ` Johan Bockgård
@ 2016-08-19 7:04 ` Eli Zaretskii
2016-08-22 15:25 ` Clément Pit--Claudel
1 sibling, 0 replies; 10+ messages in thread
From: Eli Zaretskii @ 2016-08-19 7:04 UTC (permalink / raw)
To: Johan Bockgård; +Cc: clement.pit, emacs-devel
> From: Johan Bockgård <bojohan@gnu.org>
> Cc: Clément Pit--Claudel <clement.pit@gmail.com>,
> emacs-devel@gnu.org
> Date: Thu, 18 Aug 2016 21:39:01 +0200
>
>
> Fixed in master.
Thanks.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: Is emacsclient --eval broken?
2016-08-18 19:39 ` Johan Bockgård
2016-08-19 7:04 ` Eli Zaretskii
@ 2016-08-22 15:25 ` Clément Pit--Claudel
1 sibling, 0 replies; 10+ messages in thread
From: Clément Pit--Claudel @ 2016-08-22 15:25 UTC (permalink / raw)
To: Johan Bockgård, Eli Zaretskii; +Cc: emacs-devel
[-- Attachment #1.1: Type: text/plain, Size: 88 bytes --]
On 2016-08-18 15:39, Johan Bockgård wrote:
> Fixed in master.
Brilliant, thanks!
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2016-08-22 15:25 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-08-03 15:32 Is emacsclient --eval broken? Clément Pit--Claudel
2016-08-06 10:09 ` Eli Zaretskii
2016-08-06 11:17 ` Johan Bockgård
2016-08-06 11:21 ` Eli Zaretskii
2016-08-06 15:23 ` Clément Pit--Claudel
2016-08-06 15:30 ` Eli Zaretskii
2016-08-15 19:08 ` Johan Bockgård
2016-08-18 19:39 ` Johan Bockgård
2016-08-19 7:04 ` Eli Zaretskii
2016-08-22 15:25 ` Clément Pit--Claudel
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).