From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: Proposing changes to adjust_frame_size Date: Thu, 6 May 2021 16:10:12 +0200 Message-ID: References: <69a5e928-2998-f776-fa0d-f35e6ab1e65d@gmx.at> <20210505.194756.2198057137743556501.masm@luna.pink.masm11.me> <20210505.230733.1330791046879877132.masm@luna.pink.masm11.me> <87a6p9knr9.fsf@gnu.org> <9712b3f0-c442-61fc-93a6-773ffcde1c2e@gmx.at> <87y2cswam6.fsf@gnu.org> <1b11ac72-6687-f2d4-1d9f-0619d6d2462c@gmx.at> <87v97ww8h4.fsf@gnu.org> <87eaa667-b3cd-0274-669c-3cb4e0076ce0@gmx.at> <87sg30vy7w.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------F277C38B500299547E4F39D4" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27816"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: Tassilo Horn Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu May 06 16:10:58 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1leeiQ-00077p-71 for ged-emacs-devel@m.gmane-mx.org; Thu, 06 May 2021 16:10:58 +0200 Original-Received: from localhost ([::1]:57468 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1leeiP-0000xv-2i for ged-emacs-devel@m.gmane-mx.org; Thu, 06 May 2021 10:10:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:37710) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leehn-0000Xp-Sy for emacs-devel@gnu.org; Thu, 06 May 2021 10:10:19 -0400 Original-Received: from mout.gmx.net ([212.227.17.22]:43379) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1leehl-0001hr-Ac; Thu, 06 May 2021 10:10:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620310214; bh=zzISsQpfRjA1evwi0OqWoLnDuds0xJYHvzDBKV6cOkM=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=ju20yAHh4SHZ9D0j7gSaPqxVLeqpvMEn6i9QWdIdB5QZp/evbQf/rwXIMT9OEeG2M B5CGhzUrdmEi2ALXz/AVn1LOot1z8Q2ysrumM+HGhCZWSGB9GUj6BnD14aBzG03Dfj yBuybo8KrQq2jddyu4/zUM/p+1ma0QUwk7ZYCew0= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.100] ([212.95.5.178]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mqb1c-1l9fU60J1c-00mXm2; Thu, 06 May 2021 16:10:14 +0200 In-Reply-To: <87sg30vy7w.fsf@gnu.org> Content-Language: en-US X-Provags-ID: V03:K1:XaUafQYU4K8zdlSVaBwsFNYOdxayBY9GbdT5fnZo61zzySXsDL5 avLpZGvHzQayL6Az0m9bhzBgK2S6mgaBuMSGGLp7oUNekLjnQRQvSpPnLPeUL/kIF6l2uDD 9/pifxUPRNE6nVXCrIwp7oTMKHeF+YIW6ctpoFl1jmjMgRW+LT9TTdcw7cIfp5zNDrHOhG+ 6/KACSmODRV7v7yVZPFYw== X-UI-Out-Filterresults: notjunk:1;V03:K0:CDlKApyba4c=:KOg7wFHV3X/kPMgR5pfOmN qT6zOEjt254HYtRZZVhP9uJ+iQ+OBabjW3X8FDGkklZiPQnwf61OxgxqO0Hn8fgpfHrxL1BNp lfDDVnvyNPedNsb5T9VOAs9ffvFMCCugS6UkM+C2WTMwRslBRkQLJrMNMsqPuTSOrnwYbaFZV ZWpg4VZ+vi1/TgqQVrtNewCJ+COoqcEmvOlqQtYY8506YMTe1UI3J4OujybL/TDSHiTb/9qP5 25sCOYiooq+spYfA/gkUl4Zpck3vt9pY8k5WgHFd7ly41VthdF06G8jXnTOWFvgCnh9i/UI2r W6l12HQczgi21KCh7uVZtMONasL3PUDQO9ksAfMiuub6vokpUAqmBXJnyCmwmIqCOWU8nUvgE kuKpT9S+3lof6zc2ucgApvNHpqCkw6sjtdCG3Vg5WBEhluLfo/EzlpxN5D9hsaNX+aKQyS0Ra gnSs/t62wi+3nU3JON8+AB3a1HRZNscKL4NDhc5TZVBpkQV1tcHNfo3Xy6Dp/eRvchA9JafeI TjodDo1nIjGtHp+Dm8mh3pJGonluZzPFyjanMsHcKhQgkwQ18MhWrpUDRJgjo170/RNa8tEee cdnsQafp++0/avMrWWHWGmg+9mIs8seeXGN5Y6ENP6pBjZLh2dT0/723pn/cI6mqFQLURKdim e96/cMn2O19qxQfiAUC348c0LOKaxKVrjeTue/3K84jHkxK3o1kgSGITocUbu36wg7P05o58k E4oPpkS27EOECfez9ikGxb+nX/O682CZ+BjFjh/9IsFeKcXPNPhp8kMRoh7p55DbU+pk905K Received-SPF: pass client-ip=212.227.17.22; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268967 Archived-At: This is a multi-part message in MIME format. --------------F277C38B500299547E4F39D4 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit >> in xterm.c please remove the two occurrences of >> >> #if defined USE_GTK && defined HAVE_GTK3 >> /* If GTK3 wants to impose some old size here (Bug#24526), >> tell it that the current size is what we want. */ >> xg_frame_set_char_size >> (f, FRAME_PIXEL_WIDTH (f), FRAME_PIXEL_HEIGHT (f)); >> #endif >> >> and tell me whether the problem persists. > > Nope, then the problem is gone and also toggling the toolbar and menubar > has immediate effect without need for resizing the frame. Please tell me whether it's necessary to remove both of these to make the problem go away. If removing the second one suffices, please try the attached patch and tell me whether it helps. martin --------------F277C38B500299547E4F39D4 Content-Type: text/x-patch; name="xterm.c.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="xterm.c.diff" diff --git a/src/xterm.c b/src/xterm.c index 9edaed9a34..b7958f0cd6 100644 =2D-- a/src/xterm.c +++ b/src/xterm.c @@ -8436,7 +8436,7 @@ handle_one_xevent (struct x_display_info *dpyinfo, x_set_z_group (f, Qbelow, Qnil); } - if (not_hidden) + if (not_hidden && iconified) { SET_FRAME_VISIBLE (f, 1); SET_FRAME_ICONIFIED (f, false); @@ -8447,11 +8447,8 @@ handle_one_xevent (struct x_display_info *dpyinfo, (f, FRAME_PIXEL_WIDTH (f), FRAME_PIXEL_HEIGHT (f)); #endif f->output_data.x->has_been_visible =3D true; - } - if (not_hidden && iconified) - { - inev.ie.kind =3D DEICONIFY_EVENT; + inev.ie.kind =3D DEICONIFY_EVENT; XSETFRAME (inev.ie.frame_or_window, f); } } --------------F277C38B500299547E4F39D4--