From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: master 95b1eacd47: Fix handling of UNCs in 'parse-colon-path Date: Thu, 25 Aug 2022 08:56:25 -0400 Message-ID: References: <166135805961.19216.9573795919733967151@vcs2.savannah.gnu.org> <20220824162100.7A8DFC0088A@vcs2.savannah.gnu.org> <1a7d3a5b-6022-906f-8bc3-9280ff1ad4c2@cornell.edu> <83v8qh4gw2.fsf@gnu.org> <72e69a8e-13ba-f36f-d6bd-c4ed4bb0e53e@cornell.edu> <83mtbs52b2.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21993"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Aug 25 14:57:21 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oRCQC-0005ZW-GG for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Aug 2022 14:57:20 +0200 Original-Received: from localhost ([::1]:49224 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oRCQB-0005Ec-Ck for ged-emacs-devel@m.gmane-mx.org; Thu, 25 Aug 2022 08:57:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42642) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRCPR-00041I-Ku for emacs-devel@gnu.org; Thu, 25 Aug 2022 08:56:33 -0400 Original-Received: from mail-mw2nam12on2122.outbound.protection.outlook.com ([40.107.244.122]:24545 helo=NAM12-MW2-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oRCPP-0004Dc-SB; Thu, 25 Aug 2022 08:56:33 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TfPuGX36VdkbCsMZHYhQXkXmxWwjyMbzKESyfhpvvOgbf9VZ2n1oedpvhdUXIu8jfOBQpeLzCGrLApPrr6akV9KJzAGEzSLfe/kLtJ2mkFt64sohaaJ68z7BtcCwaFwtSjXop/GE1hw54jU1MJItNg7sDrH0wLndhqbmLzYFXfRmZQUVnmpodO89tKioZmYN1xKOVNPpgryHno/1nsN5BcknflA97yvlW0+TcIE+zGhRgM/MhU+LsIKSZ0Nzzm4zdCswhrL3kM15oPfI5bYeJOwo2HdF8uojoLYErf/c9DZZ9bqpzWX4OTII6GoXCpi7480hZA1j2kCYDOyXsJUS0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=m9my317HV2ZXfIIAdN04pD5uXGRwosJ7SUKwMfmUyuQ=; b=YZ2OPGVOx9xytXEpgscvdKZ69J3ZyDSj4+K9xxVHUY+en0HKS7Qqa/CuwKO6j6nr2LSxLBBVX0PGzE+3r5bWSIW0FlRkfNXM0Y7M0o0S8DfyOOMG6KnTjH3BHWIFoxrcHs9vPaql+hUV85gYlVz7qepYs3tsFWg14X4NLd8VnXrl5o/vZ22y0q1kcjme3CdKE77V8Lfs/0d2GRx/L1+ExTACYwMCMWlq/2rOtAODjRwj3N16EveRmKsdwRQ6tpDmQSvR9ZwKfj40NdzWQPnpF3F0D56vtxQB3iGJqMouaFVnKRAgrnmO5FttCHIPphsa5cKbS0ceAsOMLsWwDgs2cA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cornell.edu; dmarc=pass action=none header.from=cornell.edu; dkim=pass header.d=cornell.edu; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cornell.edu; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=m9my317HV2ZXfIIAdN04pD5uXGRwosJ7SUKwMfmUyuQ=; b=W6oJXdnIfbIlJL4KJMcXtKNwx16mWZbRtpmsQ/6SkRhieGpsDGgSePd3l5jbhSDv0EI2pEGh2xIwU6WxO8xWMszvDRI42UJA5ybsovdYT6fPM+fZ+qUY1zi5kQJ8DXxmgdqvICE45+VX+mjHYXUu6xBroPUiqfY3TduRzeH1JMk= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=cornell.edu; Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) by CH2PR04MB7032.namprd04.prod.outlook.com (2603:10b6:610:92::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5566.15; Thu, 25 Aug 2022 12:56:28 +0000 Original-Received: from BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::4417:167:d80b:6dcd]) by BN7PR04MB4388.namprd04.prod.outlook.com ([fe80::4417:167:d80b:6dcd%5]) with mapi id 15.20.5546.022; Thu, 25 Aug 2022 12:56:28 +0000 Content-Language: en-US In-Reply-To: <83mtbs52b2.fsf@gnu.org> X-ClientProxiedBy: MN2PR05CA0047.namprd05.prod.outlook.com (2603:10b6:208:236::16) To BN7PR04MB4388.namprd04.prod.outlook.com (2603:10b6:406:f8::19) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8e3ef582-9b22-445d-517a-08da8699397e X-MS-TrafficTypeDiagnostic: CH2PR04MB7032:EE_ X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Zyvc4EvdTwWLdG4t/SSIZv+xuTILOn8r6EwdELaU2J+3TkMPwhDWD1Sk7F6mqfYH+EkajqBCY3eXb9/dNJhw6p0fSuHixZ0hv83eQ6P2vEB2qzP2+m2CSentxNO0vkPaclMn3LYatbt1IVh81t4lDCmDA+bWhkBPJWTUn736PMk1ZEYpQqJRLZDfRygD9gtzmDvvguxMlWSlt51U2Gj6IJB+aqEYyB6cVvuPA4eehRN5BvKTKBnyupXnX/ER5KV4UhKeZXOnsXjzAnUUcgugUEcKUmB9pK2t5dbNcJ8Yo9x5DZVruxGh5kBdwSuEtjuce1g/EfVV6YLCLh9orqHZgxLOyUIpaNAD1If/bjpwysuZdb+GYngzYxcJJ9kJJnQMGyHxd6KvkrlRMWP9J7whC7u42aedj6y257TOfz3KRAfdZWt58hpXRK65ekZcDZo0Hldx6BvJZ9jF5jcTtJENQxiTj/I38gUH7XWIjpmlDCR4kU2kaI00BlvUdO1lIoImwZRrPriPBhlapDAo6kcYdljbWvHZNe13RZFyMZwHUXN3pRjBF1izy4/GzWTf7t6MDq4scCiRr/mgNiKhPbUEZoRL8JIDFBi7fDPr17JeRQGPMYniFTQk9gfpdzN96c90v3TwVB2wViXNBayPwAG3XDaDTLeRJDYSuV9TFY7i0KWwPkxev5fa9n+1HYRU/Sktd60G8qk7WRn+vX7nzCgFsqLvF/vtejFDSxTKTswpyKkXSKCtpk2W4hOq/AcwQ ZSjo5QtPymj5gVwm+kcFzeLes6uNQ8M32ZNhSaMsAyDnM8= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN7PR04MB4388.namprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230016)(4636009)(39860400002)(376002)(346002)(366004)(136003)(396003)(2616005)(6512007)(36756003)(786003)(316002)(38100700002)(6916009)(31686004)(41320700001)(66946007)(66556008)(66476007)(8676002)(4326008)(478600001)(75432002)(8936002)(450100002)(2906002)(5660300002)(53546011)(6506007)(6486002)(6666004)(41300700001)(186003)(83380400001)(31696002)(86362001)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SW4wVXNJZjVjSVkwa3dPdzdJNm5rUnNXNHQ5M2JoMGRUWUVYZ2FwMzNGaTky?= =?utf-8?B?VytTSnBLRHNjMDBNdkJhQ1F5S2syeEg5ZXdQdDZuVUE1K01YY2dseGQ3Z1E4?= =?utf-8?B?Wks0d3hBZXJnME9RUkdiRG9tRE50VEVic0dadklnUldZL1pGTDF1a3h1Z3lV?= =?utf-8?B?S0ZyZnVMTm54NkFrQ3BKTHlkaXUvWFVlMks2Z3BYb2FVVWFFeFA0Y0RkODE0?= =?utf-8?B?cFRTeUpTZnljKzhTTjdYTjNraThSUnJmY3EzMlRDQmNNVE4vaGJDVUVZNkpy?= =?utf-8?B?bXUwUHdWVjY2ZHJ0YVg0UlBhYzc4eGh6YldtUFZTalhtQVdLZ2JicGU1YmxJ?= =?utf-8?B?K2M2TDQzcFdZVUFMUVlQTmxGZDJucEFqRkVxTlJkTFF1TGhqNG0rcm95RXR6?= =?utf-8?B?dXlQOThmbzNadmNhV1ZBcDFQcmtpekszb1Y3YWVJNUpMaUlndFBycExyVTBk?= =?utf-8?B?L2tHNGM2UDdzRUtjdkY5WE80b2pPdFJkVCtVcWNVUHNzU21WdUFNYTMyVHQv?= =?utf-8?B?VFZSLzdseGhGdk8xbS9mbVJBY1JMNTM1Nk9ZYmpvUXlKajM1cERSOXovRXU3?= =?utf-8?B?aElXTVhYZUF5RmFXVEtqV0tTNVdaYmJxTGVWRHp4clpqMFpOenowRS9ZVHF3?= =?utf-8?B?YUgrNzBYVGtxZDFHZWpKL0cyV05BRUsvZDRtUE X-OriginatorOrg: cornell.edu X-MS-Exchange-CrossTenant-Network-Message-Id: 8e3ef582-9b22-445d-517a-08da8699397e X-MS-Exchange-CrossTenant-AuthSource: BN7PR04MB4388.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2022 12:56:28.0763 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 5d7e4366-1b9b-45cf-8e79-b14b27df46e1 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dhMYh2pQ8AIJyts+wuvdoHzw3j2dVOOGXEkjPeosSgNSS2hDET62xidL1/tiWdp8vXPgD6yz6CSGwq9GrLf1pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR04MB7032 Received-SPF: pass client-ip=40.107.244.122; envelope-from=kbrown@cornell.edu; helo=NAM12-MW2-obe.outbound.protection.outlook.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:294085 Archived-At: On 8/25/2022 1:18 AM, Eli Zaretskii wrote: >> Date: Wed, 24 Aug 2022 18:03:35 -0400 >> Cc: emacs-devel@gnu.org >> From: Ken Brown >> >>> Ugh, it means the test data needs to be split three-way: one for >>> MS-Windows/MS-DOS, another for Cygwin, and one more for the rest. >>> Because Cygwin is like Posix systems, but it does want to support >>> UNCs. >> >> It's not just the test data that's wrong on Cygwin, but parse-colon-path is >> wrong: It always collapses multiple leading slashes to two. > > That's what substitute-in-file-name does as well (in the Cygwin and > MS-Windows/MS-DOS builds), and the change I made was meant to restore > backward compatibility with what parse-colon-path did as result of > using substitute-in-file-name. > >> Posix says that multiple leading slashes are equivalent to one slash *except* in >> the case of exactly two leading slashes. In that case, the interpretation is >> implementation-dependent. > > This is not about Posix, this is about the Emacs-specific feature of > handling multiple consecutive slashes. In particular, in Emacs, > "/foo//bar" yields "/bar", not "/foo/bar" per Posix. OK, I completely missed the point. >> Cygwin follows Posix and chooses to interpret precisely two leading slashes as >> referring to a UNC path. In particular, 3 or more slashes should be collapsed >> to 1 slash, as on other Posix systems, while exactly 2 leading slashes should be >> left alone. > > I'm not against changing the behavior of substitute-in-file-name and > parse-colon-path in this regard, but it would be a separate change, > and of a long-standing behavior. This particular change just restored > what parse-colon-path did back when it used substitute-in-file-name. I think you're right, and it's just a matter of fixing the test. Thanks for the explanation. Ken