From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Spyros Roum Newsgroups: gmane.emacs.devel Subject: Re: Add completion to compilation-read-command Date: Tue, 24 Dec 2024 11:57:15 +0000 Message-ID: References: <87ttatb9g0.fsf@posteo.net> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------4Qj9i0QLD00OGXWgsQ0lJBgP" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15275"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: philipk@posteo.net Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 24 12:58:47 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tQ3Yk-0003gd-NY for ged-emacs-devel@m.gmane-mx.org; Tue, 24 Dec 2024 12:58:46 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tQ3Xi-00008M-Nu; Tue, 24 Dec 2024 06:57:42 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ3XJ-0007qW-BT for emacs-devel@gnu.org; Tue, 24 Dec 2024 06:57:17 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tQ3XG-00017j-QG for emacs-devel@gnu.org; Tue, 24 Dec 2024 06:57:17 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 5642F240101 for ; Tue, 24 Dec 2024 12:57:05 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1735041426; bh=IOJyImk3alXWKhP2plB+Afm7jlnr1pxIKXVAeT/wpww=; h=Content-Type:Message-ID:Date:MIME-Version:Subject:To:Cc:From: From; b=CZsh5yEtwLC/rxIhLduLNSg6LTKeFuVUf6t9Q+nXP3uVc0TYIHbNR3tPwW++AGfw8 o7L/dENRceLw7HvAACUFDTCyaJD4YMTtYivcTPq91OZeZEEMFV2cJC8gsGbVpyTG58 11JEOv0imGMm9IzCkod61TVuWqbvUHMRA+N9FU6WaA8zNPC8Es5nI6WdsZRo8jidd5 6O9y1MLnuIc0kBhLw6868Er9PSWLtfRQbM5c4cCeoIpTe2GMnJL0c5rQ+lt3V1VLx1 a7YyIq/BoJ9HRUfgZ1Ebs8poSQshucF2P+ZGxOjprpYMklHYeNDgv6Wc5pHQTARe7Q NlZPjYMrpIJ/w== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4YHYKF25hlz9rxK; Tue, 24 Dec 2024 12:57:05 +0100 (CET) Content-Language: en-US, el, el-en In-Reply-To: <87ttatb9g0.fsf@posteo.net> Received-SPF: pass client-ip=185.67.36.66; envelope-from=spyros.roum@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, RCVD_IN_VALIDITY_SAFE_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326988 Archived-At: This is a multi-part message in MIME format. --------------4Qj9i0QLD00OGXWgsQ0lJBgP Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Philip Kaludercic wrote: > Spyros Roum writes: > >> Hello all, >> >> Recently, I started using `M-x compile` more but as I was used to my >> shell suggesting past commands as I type (and tools like atuin) > In case anyone else hasn't heard of this, it describes itself as > > Atuin replaces your existing shell history with a SQLite database, and > records additional context for your commands. Additionally, it > provides optional and fully encrypted synchronisation of your history > between machines, via an Atuin server. > > (https://github.com/atuinsh/atuin) Thanks for adding the description, I should have done that myself. >> , I was >> missing auto-complete a lot. >> I managed to add this functionality by writing a simple function based >> on compilation-read-command that uses completing-read instead of >> read-shell-command. > Do you know about the `bash-completion' package? It enhances > `read-shell-command' completion with completion data provided by bash. > It is very easy to set up, > > (use-package bash-completion :ensure t > :init (bash-completion-setup)) > > should do it. I was not aware of this, but it doesn't seem to do what I'm looking for. For once, I am not using bash, but even ignoring that it doesn't seem to have the effect I'm looking for. I'm trying to get the compile prompt to suggest completion based on past commands I've run. >> Then I used advice-add to overwrite the >> original compilation-read-command with mine. >> >> So far this works well, and as far as I can tell there is no good >> reason not to make compile auto-completing, it already has a history >> that you can navigate anyway. >> >> With that said, this is the first time I write here and the first time >> I'm trying to contribute to emacs, so I'm not sure what the best way >> to go from here would be. >> I think some decisions would need to be taken, for once I am not sure >> if it's acceptable to change the default and make it completing or if >> there should be an option for it. > I am not sure if you meant to attach any code, but that would probably > be the best place to start. > >> Looking forward to your feedback, thanks You are right I should have posted code, so here is what I have:   (defun compilation-read-command-with-autocomplete (command)     "Use `completing-read` to add autocomplete powers to compilation read"     (completing-read "Compile command: " compile-history       nil nil command       (if (equal (car compile-history) command)         '(compile-history . 1)         'compile-history)))   (advice-add     #'compilation-read-command     :override #'compilation-read-command-with-autocomplete) --------------4Qj9i0QLD00OGXWgsQ0lJBgP Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Philip Kaludercic wrote:
Spyros Roum <spyros.roum@posteo.net> writes:


Hello all,

Recently, I started using `M-x compile` more but as I was used to my
shell suggesting past commands as I type (and tools like atuin)

In case anyone else hasn't heard of this, it describes itself as

  Atuin replaces your existing shell history with a SQLite database, and
  records additional context for your commands. Additionally, it
  provides optional and fully encrypted synchronisation of your history
  between machines, via an Atuin server.

(https://github.com/atuinsh/atuin)

Thanks for adding the description, I should have done that myself.


                                                               , I was
missing auto-complete a lot.
I managed to add this functionality by writing a simple function based
on compilation-read-command that uses completing-read instead of
read-shell-command.

Do you know about the `bash-completion' package?  It enhances
`read-shell-command' completion with completion data provided by bash.
It is very easy to set up,

  (use-package bash-completion :ensure t
    :init (bash-completion-setup))

should do it.

I was not aware of this, but it doesn't seem to do what I'm looking for.
For once, I am not using bash, but even ignoring that it doesn't seem to have the effect I'm looking for.

I'm trying to get the compile prompt to suggest completion based on past commands I've run.


Then I used advice-add to overwrite the
original compilation-read-command with mine.

So far this works well, and as far as I can tell there is no good
reason not to make compile auto-completing, it already has a history
that you can navigate anyway.

With that said, this is the first time I write here and the first time
I'm trying to contribute to emacs, so I'm not sure what the best way
to go from here would be.
I think some decisions would need to be taken, for once I am not sure
if it's acceptable to change the default and make it completing or if
there should be an option for it.

I am not sure if you meant to attach any code, but that would probably
be the best place to start.


Looking forward to your feedback, thanks

You are right I should have posted code, so here is what I have:

  (defun compilation-read-command-with-autocomplete (command)
    "Use `completing-read` to add autocomplete powers to compilation read"
    (completing-read "Compile command: " compile-history
      nil nil command
      (if (equal (car compile-history) command)
        '(compile-history . 1)
        'compile-history)))
 
  (advice-add
    #'compilation-read-command
    :override #'compilation-read-command-with-autocomplete)

--------------4Qj9i0QLD00OGXWgsQ0lJBgP--