From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Colin Woodbury" Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] lisp/files.el: Add `file-name-set-extension` Date: Wed, 09 Jun 2021 17:42:53 -0700 Message-ID: References: <6ff4b7d7-03ac-48d1-8d49-de66431d4e5b@www.fastmail.com> <87lf82y9pv.fsf@tcd.ie> <3780a7f9-19f4-4216-baa9-ce00b3dbace9@www.fastmail.com> <6ba4668c-9b39-40e0-a155-f7e583fd33b6@www.fastmail.com> <87czteeyoc.fsf@igel.home> <9a92de1b-e313-468d-aa1f-7f969ed73688@www.fastmail.com> <87h7ipcs3j.fsf@igel.home> <392FB601-CF1D-482F-B373-B443C4131412@gmail.com> <26B660D9-AC76-4AFC-9FFD-2F5D4DCA16C1@acm.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary=12910fcd2b23428abec41752a2664a56 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11250"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.5.0-alpha0-519-g27a961944e-fm-20210531.001-g27a96194 Cc: =?UTF-8?Q?Mattias_Engdeg=C3=A5rd?= , Philipp , emacs-devel@gnu.org To: "Stefan Monnier" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jun 10 02:44:20 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lr8nz-0002YR-W2 for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Jun 2021 02:44:20 +0200 Original-Received: from localhost ([::1]:60968 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lr8nt-0007T5-G4 for ged-emacs-devel@m.gmane-mx.org; Wed, 09 Jun 2021 20:44:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:55018) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr8mz-0006og-0w for emacs-devel@gnu.org; Wed, 09 Jun 2021 20:43:17 -0400 Original-Received: from out1-smtp.messagingengine.com ([66.111.4.25]:46369) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lr8mw-0008EB-QQ for emacs-devel@gnu.org; Wed, 09 Jun 2021 20:43:16 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 1976F5C00A4; Wed, 9 Jun 2021 20:43:14 -0400 (EDT) Original-Received: from imap1 ([10.202.2.51]) by compute1.internal (MEProxy); Wed, 09 Jun 2021 20:43:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fosskers.ca; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=jXnbw7GkGhd9g6n1X896igZSLTSobWR RH/UAkpouUN8=; b=XoUeJOz4L0VfkXsGyhoYlczNablwwWTunL1/Y/jXl2c3g21 aMFuPvbKIAu0uLZaG0RgVD/VKfgDJjWpXL1ms+eTocorg8K+B9YBkc+u145Y584l 293rOVz1Lvxbu1eSWdeO79Yfys79srCwd4eWSf7BtoECKKUMepnLfgDHBhDUifn3 QTUxIiGgbA+P3zjQWkWb5cOJKcztMdO9PheCSaIbC4JbOdNmC1Qoo8Uc+pQ0k8Wn rtuRV1NoTVRwlJTpBQeZUsst93QC75qsT/5/SLUbd2jBVnr5Nb6L3bkVeLtYuPfv NXk8Nj1D4ce1prclJ9FCPNKEo0JHwc7ie4t6K8w== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=jXnbw7 GkGhd9g6n1X896igZSLTSobWRRH/UAkpouUN8=; b=pxs4eno+14L+2XyTFcIw3t 4Qd8kOqfOJjCNx5AK9e39guTFAQcYQaWOq+KwZ84RNH6lGENahOPULJKPxlbNCIS ynLOWvOGHW/ui+tEdOePZ3NMVtemNHhN4g9o14Ys2zdCMhkMY5BohNstOm+aqBKi aByxAtsVzmYJuZO0sw05O2c/Wr5Ea1mLF5991zAOCzEjqlEICfueZ1u4NXCyI6lc eHALljNB7L6lkQCRReilaEy7BZEAqeHVomDrILoNgycFMspah5S1jxGJeNpu4Xnn ezoJeWUnd4z0pGfGjB9iimRzlI4uLp/cOwj26Jvrc07K+UfLK7WFzE+7R7jT/txA == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeduvddgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesmhdtreerreertdenucfhrhhomhepfdevohhl ihhnucghohhouggsuhhrhidfuceotgholhhinhesfhhoshhskhgvrhhsrdgtrgeqnecugg ftrfgrthhtvghrnhepffffgfehgeefgeevvddtgeeuuefhudefteegtdehkeegvdeifeev vdefgeeileejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrh homheptgholhhinhesfhhoshhskhgvrhhsrdgtrg X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id CEB571300064; Wed, 9 Jun 2021 20:43:13 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: Received-SPF: none client-ip=66.111.4.25; envelope-from=colin@fosskers.ca; helo=out1-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_PASS=-0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:270622 Archived-At: --12910fcd2b23428abec41752a2664a56 Content-Type: multipart/alternative; boundary=c755ba986c5f4616b12b7075342e2dcf --c755ba986c5f4616b12b7075342e2dcf Content-Type: text/plain So be it! I've updated the patch. Colin On Wed, 9 Jun 2021, at 16:05, Stefan Monnier wrote: > > As for the naming of `set-extension`, the best I can think of as an > > alternative would be `with-extension` as a dual to `sans-extension`, > > `file-name-with-extension` sounds good to me (better than `...set...`). > > > Stefan > > --c755ba986c5f4616b12b7075342e2dcf Content-Type: text/html
So be it! I've updated the patch.

Colin

On Wed, 9 Jun 2021, at 16:05, Stefan Monnier wrote:
> As for the naming of `set-extension`, the best I can think of as an
> alternative would be `with-extension` as a dual to `sans-extension`,

`file-name-with-extension` sounds good to me (better than `...set...`).


        Stefan



--c755ba986c5f4616b12b7075342e2dcf-- --12910fcd2b23428abec41752a2664a56 Content-Disposition: attachment;filename="file-name-with-extension.patch" Content-Type: text/x-patch; name="file-name-with-extension.patch" Content-Transfer-Encoding: BASE64 ZGlmZiAtLWdpdCBhL2xpc3AvZmlsZXMuZWwgYi9saXNwL2ZpbGVzLmVsCmluZGV4IDI0NTBk YWY1YmYuLmFkMDQzODZjYzIgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZXMuZWwKKysrIGIvbGlz cC9maWxlcy5lbApAQCAtNDg5Miw2ICs0ODkyLDIwIEBAIGV4dGVuc2lvbiwgdGhlIHZhbHVl IGlzIFwiXCIuIgogICAgICAgICAoaWYgcGVyaW9kCiAgICAgICAgICAgICAiIikpKSkpCiAK KyhkZWZ1biBmaWxlLW5hbWUtd2l0aC1leHRlbnNpb24gKGZpbGVuYW1lIGV4dGVuc2lvbikK KyAgIlNldCB0aGUgRVhURU5TSU9OIG9mIGEgRklMRU5BTUUuCitDb25zb2xpZGF0ZXMgbGVh ZGluZy90cmFpbGluZyBkb3RzIHNvIHRoYXQgZWl0aGVyIGBmb28nIG9yIGAuZm9vJworY2Fu IGJlIHBhc3NlZCBhcyBhbiBFWFRFTlNJT04uCisKK1NlZSBhbHNvIGBmaWxlLW5hbWUtc2Fu cy1leHRlbnNpb24nLiIKKyAgKGxldCogKChwYXR0ICJbIC5dKyIpCisgICAgICAgICAoZmls ZSAoc3RyaW5nLXRyaW0tcmlnaHQgZmlsZW5hbWUgcGF0dCkpCisgICAgICAgICAoZXh0biAo c3RyaW5nLXRyaW0tbGVmdCBleHRlbnNpb24gcGF0dCkpKQorICAgIChjb25kICgoc3RyaW5n LWVtcHR5LXAgZmlsZSkgKGVycm9yICJNYWxmb3JtZWQgZmlsZW5hbWU6ICVzIiBmaWxlbmFt ZSkpCisgICAgICAgICAgKChzdHJpbmctZW1wdHktcCBleHRuKSAoZXJyb3IgIk1hbGZvcm1l ZCBleHRlbnNpb246ICVzIiBleHRlbnNpb24pKQorICAgICAgICAgICgoZXF1YWwgPy8gKHN0 cmluZy10by1jaGFyIChzdWJzdHJpbmcgZmlsZSAtMSkpKSAoZXJyb3IgIkZpbGVuYW1lIGlz IGEgZGlyZWN0b3J5OiAlcyIgZmlsZW5hbWUpKQorICAgICAgICAgICh0IChjb25jYXQgKGZp bGUtbmFtZS1zYW5zLWV4dGVuc2lvbiBmaWxlKSAiLiIgZXh0bikpKSkpCisKIChkZWZ1biBm aWxlLW5hbWUtYmFzZSAoJm9wdGlvbmFsIGZpbGVuYW1lKQogICAiUmV0dXJuIHRoZSBiYXNl IG5hbWUgb2YgdGhlIEZJTEVOQU1FOiBubyBkaXJlY3RvcnksIG5vIGV4dGVuc2lvbi4iCiAg IChkZWNsYXJlIChhZHZlcnRpc2VkLWNhbGxpbmctY29udmVudGlvbiAoZmlsZW5hbWUpICIy Ny4xIikpCmRpZmYgLS1naXQgYS90ZXN0L2xpc3AvZmlsZXMtdGVzdHMuZWwgYi90ZXN0L2xp c3AvZmlsZXMtdGVzdHMuZWwKaW5kZXggZGM5NmRmZjYzOS4uODBmNDdhNzhkYyAxMDA2NDQK LS0tIGEvdGVzdC9saXNwL2ZpbGVzLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9maWxlcy10 ZXN0cy5lbApAQCAtMTQ3OCw1ICsxNDc4LDI1IEBAIFRoZSBkb29yIG9mIGFsbCBzdWJ0bGV0 aWVzIQogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChidWZmZXItc3Vic3RyaW5n IChwb2ludC1taW4pIChwb2ludC1tYXgpKQogICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIG5pbCBuaWwpKSkpKQogCisoZXJ0LWRlZnRlc3QgZmlsZXMtdGVzdHMtZmlsZS1uYW1l LXdpdGgtZXh0ZW5zaW9uLWdvb2QgKCkKKyAgIlRlc3QgdGhhdCBgZmlsZS1uYW1lLXdpdGgt ZXh0ZW5zaW9uJyBzdWNjZWVkcyB3aXRoIHJlYXNvbmFibGUgaW5wdXQuIgorICAoc2hvdWxk IChzdHJpbmc9IChmaWxlLW5hbWUtd2l0aC1leHRlbnNpb24gIkphY2siICJjc3MiKSAiSmFj ay5jc3MiKSkKKyAgKHNob3VsZCAoc3RyaW5nPSAoZmlsZS1uYW1lLXdpdGgtZXh0ZW5zaW9u ICJKYWNrIiAiLmNzcyIpICJKYWNrLmNzcyIpKQorICAoc2hvdWxkIChzdHJpbmc9IChmaWxl LW5hbWUtd2l0aC1leHRlbnNpb24gIkphY2suc2NzcyIgImNzcyIpICJKYWNrLmNzcyIpKQor ICAoc2hvdWxkIChzdHJpbmc9IChmaWxlLW5hbWUtd2l0aC1leHRlbnNpb24gIkphY2suLi4i ICIuLi5jc3MiKSAiSmFjay5jc3MiKSkKKyAgKHNob3VsZCAoc3RyaW5nPSAoZmlsZS1uYW1l LXdpdGgtZXh0ZW5zaW9uICIvcGF0aC90by9KYWNrLm1kIiAib3JnIikgIi9wYXRoL3RvL0ph Y2sub3JnIikpKQorCisoZXJ0LWRlZnRlc3QgZmlsZXMtdGVzdHMtZmlsZS1uYW1lLXdpdGgt ZXh0ZW5zaW9uLWJhZCAoKQorICAiVGVzdCB0aGF0IGBmaWxlLW5hbWUtd2l0aC1leHRlbnNp b24nIGZhaWxzIG9uIG1hbGZvcm1lZCBpbnB1dC4iCisgIChzaG91bGQtZXJyb3IgKGZpbGUt bmFtZS13aXRoLWV4dGVuc2lvbiBuaWwgbmlsKSkKKyAgKHNob3VsZC1lcnJvciAoZmlsZS1u YW1lLXdpdGgtZXh0ZW5zaW9uICJKYWNrIiBuaWwpKQorICAoc2hvdWxkLWVycm9yIChmaWxl LW5hbWUtd2l0aC1leHRlbnNpb24gbmlsICJjc3MiKSkKKyAgKHNob3VsZC1lcnJvciAoZmls ZS1uYW1lLXdpdGgtZXh0ZW5zaW9uICIiICIiKSkKKyAgKHNob3VsZC1lcnJvciAoZmlsZS1u YW1lLXdpdGgtZXh0ZW5zaW9uICIiICJjc3MiKSkKKyAgKHNob3VsZC1lcnJvciAoZmlsZS1u YW1lLXdpdGgtZXh0ZW5zaW9uICJKYWNrIiAiIikpCisgIChzaG91bGQtZXJyb3IgKGZpbGUt bmFtZS13aXRoLWV4dGVuc2lvbiAiSmFjayIgIi4uLiIpKQorICAoc2hvdWxkLWVycm9yIChm aWxlLW5hbWUtd2l0aC1leHRlbnNpb24gIi4uLiIgImNzcyIpKQorICAoc2hvdWxkLWVycm9y IChmaWxlLW5hbWUtd2l0aC1leHRlbnNpb24gIi9pcy9hL2RpcmVjdG9yeS8iICJjc3MiKSkp CisKIChwcm92aWRlICdmaWxlcy10ZXN0cykKIDs7OyBmaWxlcy10ZXN0cy5lbCBlbmRzIGhl cmUK --12910fcd2b23428abec41752a2664a56--