From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' Date: Wed, 29 Dec 2021 00:37:24 +0200 Message-ID: References: <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org> <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21588"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 To: emacs-devel@gnu.org, Sam Steingold Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Dec 28 23:39:33 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2L80-0005RA-7y for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Dec 2021 23:39:32 +0100 Original-Received: from localhost ([::1]:50980 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2L7y-0000yl-O1 for ged-emacs-devel@m.gmane-mx.org; Tue, 28 Dec 2021 17:39:30 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50408) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2L7A-0000It-E8 for emacs-devel@gnu.org; Tue, 28 Dec 2021 17:38:40 -0500 Original-Received: from [2a00:1450:4864:20::431] (port=40869 helo=mail-wr1-x431.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2L78-00016I-Nw for emacs-devel@gnu.org; Tue, 28 Dec 2021 17:38:40 -0500 Original-Received: by mail-wr1-x431.google.com with SMTP id q16so40842751wrg.7 for ; Tue, 28 Dec 2021 14:38:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=pj3uFAjf4IpSpua/3EJ2zjXF2bcTKda1gOGeadVQyAo=; b=ViSd+Dddq1CXlvED6SBCYzkfZK+h6bKI4Lk5omfxqdBelFEBLO7LS9bIh8TBto1vy9 sHV96PK8nHQ3yeCOgUthjNjqOV0GsZG/Q69GnR5DS+q51tYbAUmSATrAouRIs8uA/PZm pJpJbIoH7LMWbxuKT8calKf/MgGTA20iIJOm2UvcKtxGC2UH0+3ExUTfh2lOn2Jyd+Nn TH/yePPXZ+vwEVWhj6q/5DIn2xiBfWeCF4YIKNqOjIzu0aPR92FivDqoK3KBH/7v/5zu 1bU8tv89kiuPRvlW+WWRATfSFlMaErUUoOpznWntDhVKIX0GSkEy9GZzVdcCr+lkDSRj n7rA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pj3uFAjf4IpSpua/3EJ2zjXF2bcTKda1gOGeadVQyAo=; b=Xo/Cdn2YjMYy02M9PkrfBcx22qtD7YqOA+x187UpmwgFoQzSLRIeOhCpQN+8u9T2Z0 aVNRcMrd6dV5lhhFyu8uTjf/maIcJxfQDr3/13Awh2Oe7MLhIlc9hx8v1XkpIU/qNzAu j2vGWfYQG9mfileZwzzSGFmwgX0EdEDs8eVDiCbKn9wepkIT6bfGeXZtdz7e7bCgpzmH jmq9cvAjc6rcBIVYICWohqs11rHC9gDiUw0sHCgpAKgd5/D8kLx4eVjxgcjIOC/tuhLD 7Ob+GSrfHZTWeovGtxzMnV8fgVH6s6iBOdHPmtftU9AamRGMx/zhRfMntQdUls80oKP5 nq7g== X-Gm-Message-State: AOAM532JSMtLky2iEdneCs5TFmIdMj51pD0HoO0vn74/SB3ltYf4UVns PEgtBUNnBBsB60LMfa6yK/Y= X-Google-Smtp-Source: ABdhPJz4wtUYMYPMHZuY0m52Cui9DP5Jmi1mfcDPoesFqPbMaNirJrPou++V6klyZ9F9wS1AUie8sw== X-Received: by 2002:a5d:64cc:: with SMTP id f12mr18135871wri.145.1640731116804; Tue, 28 Dec 2021 14:38:36 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id l12sm24577083wmq.2.2021.12.28.14.38.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Dec 2021 14:38:36 -0800 (PST) In-Reply-To: <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org> Content-Language: en-US X-Host-Lookup-Failed: Reverse DNS lookup failed for 2a00:1450:4864:20::431 (failed) Received-SPF: pass client-ip=2a00:1450:4864:20::431; envelope-from=raaahh@gmail.com; helo=mail-wr1-x431.google.com X-Spam_score_int: -36 X-Spam_score: -3.7 X-Spam_bar: --- X-Spam_report: (-3.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-3.024, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:283522 Archived-At: Hi Sam, On 29.12.2021 01:30, Sam Steingold wrote: > diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el > index 3b634471ac..62dba7b393 100644 > --- a/lisp/progmodes/project.el > +++ b/lisp/progmodes/project.el > @@ -1015,7 +1015,7 @@ if one already exists." > (default-project-shell-name (project-prefixed-buffer-name "shell")) > (shell-buffer (get-buffer default-project-shell-name))) > (if (and shell-buffer (not current-prefix-arg)) > - (pop-to-buffer-same-window shell-buffer) > + (pop-to-buffer shell-buffer display-comint-buffer-action) > (shell (generate-new-buffer-name default-project-shell-name))))) > > ;;;###autoload > @@ -1031,7 +1031,7 @@ if one already exists." > (eshell-buffer-name (project-prefixed-buffer-name "eshell")) > (eshell-buffer (get-buffer eshell-buffer-name))) > (if (and eshell-buffer (not current-prefix-arg)) > - (pop-to-buffer-same-window eshell-buffer) > + (pop-to-buffer eshell-buffer display-comint-buffer-action) Please add boundp fallbacks: project.el should retain compatibility with older Emacs releases.