From: Dmitry Gutov <dgutov@yandex.ru>
To: emacs-devel@gnu.org, Sam Steingold <sdsg@amazon.com>
Subject: Re: master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action'
Date: Wed, 29 Dec 2021 00:37:24 +0200 [thread overview]
Message-ID: <c6382e29-34ad-c5e8-9b3a-c799e5970ca2@yandex.ru> (raw)
In-Reply-To: <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org>
Hi Sam,
On 29.12.2021 01:30, Sam Steingold wrote:
> diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
> index 3b634471ac..62dba7b393 100644
> --- a/lisp/progmodes/project.el
> +++ b/lisp/progmodes/project.el
> @@ -1015,7 +1015,7 @@ if one already exists."
> (default-project-shell-name (project-prefixed-buffer-name "shell"))
> (shell-buffer (get-buffer default-project-shell-name)))
> (if (and shell-buffer (not current-prefix-arg))
> - (pop-to-buffer-same-window shell-buffer)
> + (pop-to-buffer shell-buffer display-comint-buffer-action)
> (shell (generate-new-buffer-name default-project-shell-name)))))
>
> ;;;###autoload
> @@ -1031,7 +1031,7 @@ if one already exists."
> (eshell-buffer-name (project-prefixed-buffer-name "eshell"))
> (eshell-buffer (get-buffer eshell-buffer-name)))
> (if (and eshell-buffer (not current-prefix-arg))
> - (pop-to-buffer-same-window eshell-buffer)
> + (pop-to-buffer eshell-buffer display-comint-buffer-action)
Please add boundp fallbacks: project.el should retain compatibility with
older Emacs releases.
next parent reply other threads:[~2021-12-28 22:37 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <164073060906.21430.4993248796177370312@vcs2.savannah.gnu.org>
[not found] ` <20211228223009.6D0BAC002EE@vcs2.savannah.gnu.org>
2021-12-28 22:37 ` Dmitry Gutov [this message]
2021-12-28 22:59 ` master 18b680cfd1: Fix bug#52467 by adding a new custom variable 'display-comint-buffer-action' jakanakaevangeli
2021-12-29 8:17 ` Juri Linkov
2021-12-29 15:00 ` Lars Ingebrigtsen
2021-12-29 16:57 ` Eli Zaretskii
2021-12-30 8:34 ` martin rudalics
2021-12-30 8:47 ` martin rudalics
2021-12-30 10:25 ` martin rudalics
2021-12-30 14:40 ` Stefan Monnier
2021-12-30 17:12 ` martin rudalics
2021-12-30 17:29 ` Lars Ingebrigtsen
2021-12-30 18:30 ` martin rudalics
2021-12-31 16:29 ` Lars Ingebrigtsen
2021-12-31 18:41 ` martin rudalics
2021-12-30 16:04 ` Juri Linkov
2021-12-30 17:14 ` martin rudalics
2021-12-31 16:47 ` Sam Steingold
2021-12-31 18:42 ` martin rudalics
2021-12-31 16:38 ` Sam Steingold
2021-12-31 18:42 ` martin rudalics
2021-12-31 18:55 ` Sam Steingold
2021-12-31 19:40 ` martin rudalics
2022-01-03 17:22 ` Sam Steingold
2021-12-30 17:24 ` Dmitry Gutov
2021-12-30 18:30 ` martin rudalics
2021-12-31 16:28 ` Lars Ingebrigtsen
2021-12-31 18:41 ` martin rudalics
2022-01-02 16:21 ` Madhu
2022-01-02 17:09 ` martin rudalics
2022-01-02 17:43 ` Juri Linkov
2022-01-02 18:40 ` martin rudalics
2022-01-02 20:52 ` Dmitry Gutov
2022-01-03 7:45 ` Juri Linkov
2022-01-03 18:21 ` martin rudalics
2022-01-03 18:38 ` Stefan Monnier
2022-01-04 10:25 ` martin rudalics
2022-01-04 15:48 ` Stefan Monnier
2022-01-03 21:07 ` Juri Linkov
2022-01-04 10:26 ` martin rudalics
2022-01-06 15:30 ` martin rudalics
2022-01-06 19:52 ` Juri Linkov
2022-01-07 10:36 ` martin rudalics
2022-01-07 18:49 ` Sam Steingold
2022-01-07 19:03 ` Eli Zaretskii
2022-01-07 19:16 ` Sam Steingold
2022-01-11 17:20 ` Juri Linkov
2022-01-11 18:02 ` martin rudalics
2022-01-11 18:15 ` Juri Linkov
2022-01-12 8:43 ` martin rudalics
2022-01-03 7:51 ` Juri Linkov
2021-12-29 17:29 ` Sam Steingold
2021-12-29 16:43 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6382e29-34ad-c5e8-9b3a-c799e5970ca2@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=sdsg@amazon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).