From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: "Tassilo Horn" Newsgroups: gmane.emacs.devel Subject: Re: policy regarding DEFUNs in subr-x.el Date: Sun, 22 Mar 2020 21:38:08 +0100 Message-ID: References: <87d0945r4z.fsf@gmail.com> <83bloocnzo.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="35858"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.1.7-1021-g152deaf-fmstable-20200319v1 To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Mar 22 21:39:26 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jG7NW-0009FB-PU for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Mar 2020 21:39:26 +0100 Original-Received: from localhost ([::1]:49600 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jG7NV-0005ZV-RT for ged-emacs-devel@m.gmane-mx.org; Sun, 22 Mar 2020 16:39:25 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39440) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jG7N1-00050F-L0 for emacs-devel@gnu.org; Sun, 22 Mar 2020 16:38:56 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:39851) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1jG7N1-0004pi-Hm for emacs-devel@gnu.org; Sun, 22 Mar 2020 16:38:55 -0400 Original-Received: from auth2-smtp.messagingengine.com ([66.111.4.228]:56521) by fencepost.gnu.org with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.82) (envelope-from ) id 1jG7N0-0002zM-6c for emacs-devel@gnu.org; Sun, 22 Mar 2020 16:38:54 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailauth.nyi.internal (Postfix) with ESMTP id C0BE327C0054 for ; Sun, 22 Mar 2020 16:38:53 -0400 (EDT) Original-Received: from imap34 ([10.202.2.84]) by compute7.internal (MEProxy); Sun, 22 Mar 2020 16:38:53 -0400 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedugedrudegiedgudegudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgfgse htqhertderreejnecuhfhrohhmpedfvfgrshhsihhlohcujfhorhhnfdcuoehtshguhhes ghhnuhdrohhrgheqnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepthhhohhrnhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqkeei jeefkeejkeegqdeifeehvdelkedqthhsughhpeepghhnuhdrohhrghesfhgrshhtmhgrih hlrdhfmh X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 694A51460061; Sun, 22 Mar 2020 16:38:53 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <83bloocnzo.fsf@gnu.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:245699 Archived-At: Didn't we decide that replace-region-contents is to be moved to replace.= el? Sorry, I didn't follow that past discussion/patch closely but from m= y pov that would make sense, and given that this function is new in emac= s 27, now is the best time doing so. Bye, Tassilo Am So, 22. M=C3=A4r 2020, um 18:12, schrieb Eli Zaretskii: > > From: =C5=A0t=C4=9Bp=C3=A1n N=C4=9Bmec > > Date: Sun, 22 Mar 2020 16:46:36 +0100 > >=20 > > Now, it does seem sensible for the function to be a normal, not inli= ne, > > function, but what about the commentary and all the other defsubsts,= > > including the other string utilities? > >=20 > > If the no-defun policy should be changed, or if I was mistaken in > > believing there was one to begin with, shouldn't the commentary > > recommending compile-time usage be removed, and at least some of the= > > other defsubsts turned into defuns, too? >=20 > I don't see that the commentary says the code in this file must be > inline. If something in the wording implies that, let's change the > wording so that it doesn't. >=20 > From my POV, there's no reason to require that everything in that file= > is inlined, and that single "outlier" is the evidence. >=20 >=20 >