From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: master@head: completing-read behavior change? Date: Thu, 23 Jan 2020 16:58:09 +0300 Message-ID: References: <24104.57455.730537.220936@retriever.mtv.corp.google.com> <24104.57963.869782.597096@retriever.mtv.corp.google.com> <24104.58069.333584.189273@retriever.mtv.corp.google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="54092"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 Cc: emacs-devel@gnu.org To: "T.V Raman" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Jan 23 18:34:52 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iugNY-000E25-9o for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 18:34:52 +0100 Original-Received: from localhost ([::1]:33582 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iugNW-0001Qr-TR for ged-emacs-devel@m.gmane-mx.org; Thu, 23 Jan 2020 12:34:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:54683) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iuczv-0000Rz-JG for emacs-devel@gnu.org; Thu, 23 Jan 2020 08:58:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iuczu-0006DU-74 for emacs-devel@gnu.org; Thu, 23 Jan 2020 08:58:15 -0500 Original-Received: from mail-lj1-x22b.google.com ([2a00:1450:4864:20::22b]:38782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iuczt-0006AR-VL for emacs-devel@gnu.org; Thu, 23 Jan 2020 08:58:14 -0500 Original-Received: by mail-lj1-x22b.google.com with SMTP id w1so3500947ljh.5 for ; Thu, 23 Jan 2020 05:58:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=gtDe8JTjdUiHdI9Jn5+SBTFRsmXGJyAE9JGIks4TaE0=; b=Qsk01+qZjv07JNfkOiZPdQs18EdIl/gpq9YNs12Vgn/ZtmNTST+q4b/j60ue2t0mtk 6J8KGSIR7ZECqXM5HYOtaOJet5OVPRxaBq/Dx4eKhj1sJFIQjHIx+poj+GQCDQZ6fFeY 6hus1+YziK0mSnDiat8rxI+GCkRSok0gbxmYtIC9pesPgaWO/zsTLJG7NltdO2b5LGuL 9KZcltj2OK1ViGwEOq6PG2pGUFF1WlIp31uphMPW/d18/PWDJqkuddIrbkDCbm5CDli7 9xm664ZBN7wiO3BcD8mtWUrdkKjBv4c9BKNgLX2gYEwdReRgUspS2os3LexL+lC+XCLf 2pmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=gtDe8JTjdUiHdI9Jn5+SBTFRsmXGJyAE9JGIks4TaE0=; b=HaaGiWmKd1I/5YRBl/E82qXSBLAviavSWYQtsd8JMy6evgWmsrUaEwP+4U3OaGSpKp 4OQ1wGPZENMKOGrm65CrvO4AiyAKA2s9k6eeEyDaI4VRdvNq8W3QLR9hjnUkkNEfCTKo a2+3V5rI7GyGOFTiwe6fv7UDgQ5OJH5VCj1LvT8P+9eWeTEkQbvYqUlKL1aBzE2ZkFDs pJEjcUf/81dC+61P0FlGlhYx50BMK40MEPc5Y/UVw42SCNDIIpqlKvx2ANkFhDRROnh+ 7hJe88pPgBemrgnY8AFa0v5zI6APvh5ZlPcXIBnbtbuT/PDPEibveoiMh6T8G7CHIWSB 6u5w== X-Gm-Message-State: APjAAAUPOeqPqlgA28D6NdcnaciOvwbb+SVmgz1Bq1IfxKgCaXFgPwOW g7m/SDyueCeCF0d+EyDmt3BLietZy6s= X-Google-Smtp-Source: APXvYqzljUcZMoIhzD3qp3In1qg/hFKLOhFXQYuysKPFHmCIHBlAAjN1CIvoJ28DXIfgl5zbH/90qg== X-Received: by 2002:a2e:3309:: with SMTP id d9mr23139393ljc.262.1579787891203; Thu, 23 Jan 2020 05:58:11 -0800 (PST) Original-Received: from [192.168.1.142] ([178.252.127.239]) by smtp.googlemail.com with ESMTPSA id f12sm1301643ljo.100.2020.01.23.05.58.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 23 Jan 2020 05:58:10 -0800 (PST) In-Reply-To: <24104.58069.333584.189273@retriever.mtv.corp.google.com> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::22b X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:244539 Archived-At: Hi T.V., On 23.01.2020 3:03, T.V Raman wrote: > Fix is here for the curious:-) > https://github.com/tvraman/emacspeak/blob/master/lisp/emacspeak-ido.el#L85 You haven't answered my question about support for icomplete-mode. Do you only support Ido? I'm happy you made it work, but I think it would be better to handle the general approach. Meaning, instead of hardcoding the names of (private) variables, scan the minibuffer, look for the overlays with after-string, order by 'priority', and read their contents one after another. The new set-minibuffer-message feature uses the same approach if minibuffer is active. Although, in that case, you could advise this function, or set an alternative handler via the set-message-function variable (also just added in Emacs 27).