From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: master 30dbdecd4a: * src/xterm.c: Add a small writeup on input handling on X. Date: Mon, 28 Feb 2022 16:50:29 +0100 Message-ID: References: <164216105411.7395.2418079616938679655@vcs2.savannah.gnu.org> <20220114115054.720EBC0DA2E@vcs2.savannah.gnu.org> <87r19afs1z.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="11509"; mail-complaints-to="usenet@ciao.gmane.io" To: Po Lu , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Feb 28 16:51:17 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nOiIt-0002qh-Hg for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Feb 2022 16:51:15 +0100 Original-Received: from localhost ([::1]:48574 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nOiIs-0005s9-2p for ged-emacs-devel@m.gmane-mx.org; Mon, 28 Feb 2022 10:51:14 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41524) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOiIF-00059C-EU for emacs-devel@gnu.org; Mon, 28 Feb 2022 10:50:35 -0500 Original-Received: from mout.gmx.net ([212.227.17.22]:43427) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nOiID-0006pF-Nd for emacs-devel@gnu.org; Mon, 28 Feb 2022 10:50:35 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1646063430; bh=VmVaxbWzZNwIyV+3uwJtyYlVYafXglUYjjJCQGbweKw=; h=X-UI-Sender-Class:Date:Subject:From:To:References:In-Reply-To; b=GeUJjPmTITzO8ntUJXYq4/knXhyxbLyxZZsYHGiOuNuI2yTIaHCbJIa66YcCDQjKV VqzQ9tSrqNo1m+mgfqM9hcTZh6rMfi/iXszMw8lwecQLl/q6zXBaaaJ+wdb3nCCAy0 gZ/SR+yEBhzRIqKhN2sEaifhNf+CD68tAR5Tgt1w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from [192.168.1.102] ([212.95.5.144]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MzhnN-1oBCBL0coT-00vhjM; Mon, 28 Feb 2022 16:50:30 +0100 Content-Language: en-US In-Reply-To: X-Provags-ID: V03:K1:T7vU+IVU8iGAem+BOB5qbj+hI5Ix2ifQ/VzGnIegj7xRYLdjs85 1vWHfdB5CT4xKikYPPD4DYjM3w0Zi+/qFnbdrXTP0ylz9bpxMt+oXEl2JniVHnGCaWiH8R3 2LdezogSl2UGP+2yAefiEFieLz/f5i/oz26HotYDnPkwPs9HI7isLEhs3nFDUUxvrCXMKxC PlneaXwozSB9RA3OO4Z7A== X-UI-Out-Filterresults: notjunk:1;V03:K0:haT99gMsBNc=:Q2ybqjRErdxbIBNP+ERsdt J31k42B27pMpx+tAcWBzt4gdIrDbISogpAUaqLQ1HmIYUn+PGrc2S0foGIDRHohLDYfaVI2HA SQVOz6UHB2g0+JZSnF2j2dBSzYf2ybjpAspmkVgiVfnzgyr230LdZZ+T5Uqdf/5JJwnK3RKzn Tnm9mlhB8S1JJhO9HnMcYMlnmEPy+A9BdvPPL1ZlSKqi8OnlgWMCE+HePUZWquUr863m3ZHcE c0FLtr18awRt14jkSejiOj44EkZ7zA0g+SUr+U7FEzT+KyWTEFcRyUdQlNSwVK/6U1050oCMX Pvs3dEJs5vGdXVN3CNj3yBBJjacdCzHLT1zdIKO7TDJqSGYvLh+S/Ljs/5WjrlF7vPheuo0jh rLh+ZPbLThndWyniIXx1L5HR95/6bLdUZKfqrJJ6rJ2XvWW1sT+30tVO+6YpfWIJOtuNNEuGl 5FODgUh95TKSGi8uaE2+wmSut4bawzRBu8Ra+xMmpbHDLpjDKbutwsy4jr4cDV+xz74oI2O2E obwLvYQQdn8eqmwGEZm88uDJMKU4YwNXopyijOMAHnmI5r7Y4sKUejGqewDAOdJlJP/IX08Fm 597KfTdC6X2MSzqIXzNNKlpiWBrA7yY9hb3A2XXXK9ZYJADuJEary0faw17mr1E2xPUr9zWUW bIyT6bEc6DvFENz7MnhBW0yJn+1eC4eKyPiMPDFPHiK9PEiQbaALOr7g3NXgJzpm3G2lE5XS4 vgqsW0HZF4fSUWoFU3kjGvIJJE4TX4DQkEWmBbwGu4hH8daIy+JD/kLnOx0TROY4am+sMhXC Received-SPF: pass client-ip=212.227.17.22; envelope-from=rudalics@gmx.at; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286729 Archived-At: While we're there: If I'm not mistaken, xg_frame_set_char_size now has three instances of #ifndef HAVE_PGTK gtk_window_resize (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)), outer_width, outer_height); #else if (FRAME_GTK_OUTER_WIDGET (f)) { gtk_window_resize (GTK_WINDOW (FRAME_GTK_OUTER_WIDGET (f)), outer_width, outer_height); } else { gtk_widget_set_size_request (FRAME_GTK_WIDGET (f), outer_width, outer_height); } #endif Could you please refactor these into a separate routine and/or at least remove those extra braces. TIA, martin