From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.devel Subject: Re: Poll: Change xref-show-definitions-function's default? Date: Fri, 1 Jan 2021 15:33:27 +0200 Message-ID: References: <9af40a30-8964-3142-aadf-6592605720ec@yandex.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10439"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 Cc: emacs-devel To: =?UTF-8?Q?Daniel_Mart=c3=adn?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jan 01 14:34:41 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kvKZl-0002cm-D2 for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Jan 2021 14:34:41 +0100 Original-Received: from localhost ([::1]:44556 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kvKZk-0001DU-FQ for ged-emacs-devel@m.gmane-mx.org; Fri, 01 Jan 2021 08:34:40 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36200) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kvKYg-0000mZ-IK for emacs-devel@gnu.org; Fri, 01 Jan 2021 08:33:34 -0500 Original-Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]:44907) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kvKYe-0007Rf-KJ for emacs-devel@gnu.org; Fri, 01 Jan 2021 08:33:34 -0500 Original-Received: by mail-ej1-x631.google.com with SMTP id w1so28011971ejf.11 for ; Fri, 01 Jan 2021 05:33:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=nxQAdHmqsDlmGGfPu2mpTGsB/yE4MK16vS1p1j7BrHc=; b=IrhVi3r12ZQ6Qvk01Vjv13Hn+84njOWbTKC3fat83pDDrRli2/Yg3/4Bf8wysS5aiG 2A7u2YIpl+pv+340dO+7yLoGz7cb8Aa+AsnIhiuOQDFJnCtVIgZZFTgjs142mfTY+FOW kfJFPQjurjQIs4FjPeDoSYYcy47Ln849cqHWXOrTriZWGi6lhL3z5dQZPb+ns6a/J5QT qrf3gFl5DLk3oC6yt9YaMndZ97b6EFNsovPgcafRIquCeMNqWmS/yvZOVMcQYRTYMePw 5IoReLYMoQ5rzpa9IYGfdzWTzpAQo+41DN0241Z64+zjpwSQc7SOhupsFd5iLQHlbM6+ dK6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=nxQAdHmqsDlmGGfPu2mpTGsB/yE4MK16vS1p1j7BrHc=; b=VG4wOimVflIQ8Kx7XXHjsWsR2+DG7XWi/zkMmy22BNiOPbQ1gPOsi4mkqEnuRORnch mpHP96JwlW4+/0oMkNg79Gl5A4kjDelckMo7vdv+gM45KVGVRflB2sunrmiRHCPa1xCI YpZvvq36Y/1rYkep6/TyZYM6hOEV8dVhBvbUvEYBmgpcSEDIyjBivYc2tNMIS/45o72a F+nQtpoaqY5evnaWnU3/tetJyvkcn9owdr1OpDd/SuqNA/KnyDFBZ/5aXVlSqkUvn792 zkXnfPzF0cba88NNMf4dpR0kGFjGt3o9jd2YcannBLLoQZFjcgSx1v3VJk4/GFkPKvPT O0QQ== X-Gm-Message-State: AOAM5327CbxBN7i9aCafv+RaujktQ5qV8/R5dJy6R5O09Fv1aa3w/d+S wgT9dEaAY0/N55EED96sg0B0xuBuVVh78Q== X-Google-Smtp-Source: ABdhPJwCP3e1xMOj6FHcIDn6D9EWmYvOlUHofNE+qfs3zK/bMOWH318t/DI/Ig+O3VxFy/3aAwgM+Q== X-Received: by 2002:a17:906:d93c:: with SMTP id rn28mr56611819ejb.50.1609508010623; Fri, 01 Jan 2021 05:33:30 -0800 (PST) Original-Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id bn21sm21048456ejb.47.2021.01.01.05.33.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 01 Jan 2021 05:33:29 -0800 (PST) In-Reply-To: Content-Language: en-US Received-SPF: pass client-ip=2a00:1450:4864:20::631; envelope-from=raaahh@gmail.com; helo=mail-ej1-x631.google.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.249, NICE_REPLY_A=-2.749, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:262249 Archived-At: On 31.12.2020 15:06, Daniel Martín wrote: > I've given a spin to the new options and I think I'd prefer the > transient option first, followed by choosing the definition from a > buffer (like it is now). The completing-read option feels a little bit > akward to me because you first have to press TAB to see your options, > and then have to TAB complete on the "artificial" syntax that xref uses > for definitions (eg. "compile.el:(defun compile)"). The "transient" > option feels more natural. That's a fair criticism: the completing-read one works best when at least either icomplete-mode is on (preferably with icomplete-show-matches-on-no-input=t) so you see the options right away, or with Ivy completion (then you can easily choose among the options with C-n and C-p). I'm fine with the "transient" version if we'll have some consensus on that, but I wonder what can be done to make xref-show-definitions-completing-read "friendlier" even with stock completing-read. If we showed the default in the prompt, it would be easier to see what's going on. These can be pretty long lines, though, so the result might turn out to be clunkier, since the prompt will still be showing it even after you start typing, press TAB, etc.