From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Really prevent quitting in sensitive contexts Date: Mon, 13 Apr 2020 23:56:14 -0700 Message-ID: References: <20200312020554.194607-1-dancol@dancol.org> <7eced910-43dd-5e62-a864-beded660a07e@dancol.org> <87tv2tga3i.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="43452"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 Cc: Stefan Monnier , emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 14 08:58:24 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jOFWZ-000BBq-KP for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 08:58:23 +0200 Original-Received: from localhost ([::1]:53284 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOFWY-0005d3-JB for ged-emacs-devel@m.gmane-mx.org; Tue, 14 Apr 2020 02:58:22 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40423) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jOFUc-0004Z6-RF for emacs-devel@gnu.org; Tue, 14 Apr 2020 02:56:24 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jOFUb-00034Q-Pp for emacs-devel@gnu.org; Tue, 14 Apr 2020 02:56:22 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:44446) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jOFUb-00033l-7q for emacs-devel@gnu.org; Tue, 14 Apr 2020 02:56:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=42w4g3jkAkT/ORarSqg8FjWl2FkZGye800UP6ybjAL8=; b=ffe9m4lhfawJYtCoFULtXkx3tq 6Dg9aJr0+oGapCfWGNRbIlXcRWSuonSN/QQxm4Gnx0+8MMnzpfPv9VWz692mVt+ADZdlWQxtRQVFw QlqaGkJH18mBOcF9MhG1NmS8MoAvr3wpSGfTfbSdiicupofT6d9fLy7Y4gQOVdmsFrH4kbDwezSYE +DY1AsYpf6YT4duc71u2jPbg3wpAI49VVQ8CCI+m6yiyavrceX4IIkx+wUC6TEoIzrhyjeHOtLk6E YmOb5QLJ6dDxA9gRFnOUuIn53HNM/DkBNtoWIpyxyPXLWR/4mp44atDfOL7ReCn1UB1q4zdOC2WCP YFRWLOpg==; Original-Received: from [2604:4080:1321:9a00:7d81:7dd5:971d:ee46] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1jOFUV-0002iC-5R; Mon, 13 Apr 2020 23:56:15 -0700 In-Reply-To: <87tv2tga3i.fsf@gmx.de> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:246928 Archived-At: On 3/12/20 3:07 AM, Michael Albinus wrote: > Daniel Colascione writes: > >>> Are there bug#NNN where these are discussed? >> >> No. The motiviation is Tramp inflooping after a quit because it uses >> with-local-quit inside tramp-accept-process-output, which causes >> tramp-wait-for-regexp to retry infinitely and quickly. >> >> I found *that* behavior trying to figure out why M-x compile over >> Tramp was hanging not only Emacs, but also the SSH connection more >> generally. I *think* it has something to do with compilation-filter >> calling file-truename, which invokes Tramp's handler, which wants to >> talk over the same SSH connection that's spewing compilation messages, >> deadlocking something somewhere. > > Please write a bug report, it should be solved in Tramp. No, it shouldn't. This use of with-local-quit can *never* be correct because a stray C-g can *always* interfere with a filter. Don't do long-running operations in process filters. Period. The fix isn't to make quitting these operations possible in some defined manner. The fix is not to do them in the first place.