From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Cl=c3=a9ment_Pit-Claudel?= Newsgroups: gmane.emacs.devel Subject: Re: Patch to vertically center line content when using line-spacing variable Date: Mon, 26 Apr 2021 10:00:22 -0400 Message-ID: References: <1398d749303cdc2a490cd9eb35f88fcf@johnmuhl.me> <87sg3ei23u.fsf@gnus.org> <6b523482-4420-e162-a41e-f178813779c2@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37516"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 To: Stefan Kangas , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 26 16:01:50 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lb1o6-0009Tm-5Q for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Apr 2021 16:01:50 +0200 Original-Received: from localhost ([::1]:56368 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lb1o5-0006CM-A3 for ged-emacs-devel@m.gmane-mx.org; Mon, 26 Apr 2021 10:01:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45936) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lb1mo-0005g5-Lt for emacs-devel@gnu.org; Mon, 26 Apr 2021 10:00:30 -0400 Original-Received: from mail-qk1-x72f.google.com ([2607:f8b0:4864:20::72f]:37853) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lb1mj-000250-3W for emacs-devel@gnu.org; Mon, 26 Apr 2021 10:00:30 -0400 Original-Received: by mail-qk1-x72f.google.com with SMTP id t17so28036503qkg.4 for ; Mon, 26 Apr 2021 07:00:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-language:content-transfer-encoding; bh=14u+xIGalE4e1y4zPiAjkzRjxo4HIMEML0Zq2k4H/LY=; b=WbAuAZ+NpA0vfybUWB0Nv+bJzisEjv5dv7FoZmFaoO/dvfnhzA8eJyeNmlcxd3Grew j0lXAithiAcglG/6ZQoFJdasjH3gXfudPVeS8HY72hMuqoAI1eMKRtFNj7k5U/JpkBmX WPYNyjqX85U98BmOp6qW/LkibQR6SW16P+7Z4vgVt2XOS2nuuVNhmjvBPN9wP0s4dEnX Nv24MC45GtRbZwCmMRoKsA5NlkFaSFjRcZy354LfWsD9n5vvw7cz0smo91LsGorWDb1c SHaI4oikLaGF9YCIsx4a+9/iFUE4SuNbe7v//ph8JW39JV1FqpYIQe+awAsS+LlpIND/ ECXg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=14u+xIGalE4e1y4zPiAjkzRjxo4HIMEML0Zq2k4H/LY=; b=NxUNmx4fq4eh9IjdPEiCYLCH5v+Sqg0xPNAuA9uNfOk846SLiRdtzpuct0h8u833JE jVUPbT01yfl1AWyTov2kOzN+yRL8kIx0auQeyxKkatvEk+G8ZmWFYdF7vUK/eVYWWwTD qd9+ZjFANbdqnJwCehnyh/mbPGVVETMmKxvNIvZ/ZwIbtTVUmgvUZid9YFCUaYGVaEBQ 56jANs+KCKljZTva9pPi1rSemHlZAI5f6pzwEK1pzxhQO99XlznHPvJwtPHm11/uPD6j SlPC2bAR78AXXnSY+gKaafP/uzEfAHKlA7QbfVu19NWtEnIMkaDDUxJje2nh9+HRMxlP pYQw== X-Gm-Message-State: AOAM530xRwZ++eEEcTxUEmkxH4+kxihCngVqhjIvByLzKc3YBUl+WzGl ymBl0Hl/haCtuNufZtSu9INmzna9zP4= X-Google-Smtp-Source: ABdhPJw9Lu3njLIyqq9sWgYQOFb27eVfrGiW2K4vCn0UKA2rRvwnnGxLb83pHO8Q4JPPhqVxuvn21g== X-Received: by 2002:a37:270d:: with SMTP id n13mr17611668qkn.495.1619445623714; Mon, 26 Apr 2021 07:00:23 -0700 (PDT) Original-Received: from [192.168.1.11] (c-24-61-240-80.hsd1.ma.comcast.net. [24.61.240.80]) by smtp.googlemail.com with ESMTPSA id o23sm15548qka.16.2021.04.26.07.00.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Apr 2021 07:00:23 -0700 (PDT) In-Reply-To: Content-Language: en-GB Received-SPF: pass client-ip=2607:f8b0:4864:20::72f; envelope-from=cpitclaudel@gmail.com; helo=mail-qk1-x72f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:268473 Archived-At: On 4/25/21 9:00 PM, Stefan Kangas wrote: > Clément Pit-Claudel writes: > >> On 4/25/21 7:28 PM, Stefan Kangas wrote: >>> (I would just treat the old behavior as a bug and not even add a >>> variable for it, but that's me. Perhaps there is some rationale for >>> why someone would want to set this to nil?) >> >> Does this patch change the behavior of the line-spacing text property, >> too, or just the line-spacing variable? > > It seems to affect the 'line-spacing' text property too. > >> I use the line property in multiple packages, and it would break these >> packages is line-spacing suddenly added space above the line, not just >> below. > > I'll take your word for it. It sounds like I was wrong and there should > be a variable that you could set buffer locally to nil. I'm not sure that would be sufficient: the user might want vertical centering for some instances of 'line-spacing and not others. > Out of curiosity, could you briefly explain how this would break your > use of this text property? I use it in combination with other properties to achieve specific spacing around certain elements or lines; it would change the way the result looks. Right now we have a property that adds space above a line and one that adds space below, and with the change enabled it becomes impossible to add space just below the line, right? > And/or could you link one of your packages? https://github.com/FStarLang/fstar-mode.el Another package that's not mine: https://github.com/aaronbieber/sunshine.el