From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.devel Subject: RE: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region Date: Sun, 28 Feb 2016 07:53:45 -0800 (PST) Message-ID: References: <1456189471-18273-1-git-send-email-mitch.special@gmail.com> <87egbxid4e.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1456674865 20790 80.91.229.3 (28 Feb 2016 15:54:25 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Feb 2016 15:54:25 +0000 (UTC) Cc: Kristoffer Gronlund To: Mitchel Humpherys , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Feb 28 16:54:13 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aa3fg-0003dV-TU for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2016 16:54:13 +0100 Original-Received: from localhost ([::1]:59494 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aa3fg-0005WB-0l for ged-emacs-devel@m.gmane.org; Sun, 28 Feb 2016 10:54:12 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42687) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aa3fR-0005W2-Tq for emacs-devel@gnu.org; Sun, 28 Feb 2016 10:53:58 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aa3fO-0001xo-Lk for emacs-devel@gnu.org; Sun, 28 Feb 2016 10:53:57 -0500 Original-Received: from userp1040.oracle.com ([156.151.31.81]:40422) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aa3fO-0001xf-EF for emacs-devel@gnu.org; Sun, 28 Feb 2016 10:53:54 -0500 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id u1SFrnPN021070 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sun, 28 Feb 2016 15:53:49 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.13.8) with ESMTP id u1SFrnLT029853 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sun, 28 Feb 2016 15:53:49 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id u1SFrljB014340; Sun, 28 Feb 2016 15:53:47 GMT In-Reply-To: <87egbxid4e.fsf@gmail.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9 (901082) [OL 12.0.6691.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] X-Received-From: 156.151.31.81 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200760 Archived-At: > > Setting a foreground color on the `region' face is slightly > > annoying. > > This is subjective, of course, but the consensus among other > > themes and around the web is to *not* set a foreground color > > on the region face. > > Any objections to this? I should have mentioned that the reason > it's slightly annoying is because setting a foreground color hides > existing syntax highlighting within the region text. A particular theme can do anything its authors and users want, of course. But wrt the general question of whether region (aka selection) highlighting should override other highlighting, see Emacs bug #15899. http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D15899 IMO, selection highlighting should, at least by default, visibly cover the entire selection. Otherwise, it is not always clear what the region limits are. When other highlighting takes precedence over region highlighting a user can miss the fact that there is more than one (or more than N) region pieces highlighted, and so mistake the region limits. Whether region highlighting has higher precedence (priority) should always be a user choice. Users can at least customize face `region' (including to specify its foreground), but that is not enough to give region highlighting priority.