From: Drew Adams <drew.adams@oracle.com>
To: Mitchel Humpherys <mitch.special@gmail.com>, emacs-devel@gnu.org
Cc: Kristoffer Gronlund <krig@koru.se>
Subject: RE: [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region
Date: Sun, 28 Feb 2016 07:53:45 -0800 (PST) [thread overview]
Message-ID: <c37db131-57cf-4c32-885f-975e0b21a2be@default> (raw)
In-Reply-To: <87egbxid4e.fsf@gmail.com>
> > Setting a foreground color on the `region' face is slightly
> > annoying.
> > This is subjective, of course, but the consensus among other
> > themes and around the web is to *not* set a foreground color
> > on the region face.
>
> Any objections to this? I should have mentioned that the reason
> it's slightly annoying is because setting a foreground color hides
> existing syntax highlighting within the region text.
A particular theme can do anything its authors and users want,
of course. But wrt the general question of whether region (aka
selection) highlighting should override other highlighting, see
Emacs bug #15899.
http://debbugs.gnu.org/cgi/bugreport.cgi?bug=15899
IMO, selection highlighting should, at least by default, visibly
cover the entire selection. Otherwise, it is not always clear
what the region limits are.
When other highlighting takes precedence over region highlighting
a user can miss the fact that there is more than one (or more than
N) region pieces highlighted, and so mistake the region limits.
Whether region highlighting has higher precedence (priority)
should always be a user choice. Users can at least customize face
`region' (including to specify its foreground), but that is not
enough to give region highlighting priority.
next prev parent reply other threads:[~2016-02-28 15:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-23 1:04 [PATCH] * etc/themes/wombat-theme.el: Don't set foreground on region Mitchel Humpherys
2016-02-28 6:05 ` Mitchel Humpherys
2016-02-28 6:21 ` Lars Ingebrigtsen
2016-02-28 8:13 ` Kristoffer Grönlund
2016-02-28 15:53 ` Drew Adams [this message]
2016-03-14 17:22 ` Mitchel Humpherys
2016-03-14 17:31 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c37db131-57cf-4c32-885f-975e0b21a2be@default \
--to=drew.adams@oracle.com \
--cc=emacs-devel@gnu.org \
--cc=krig@koru.se \
--cc=mitch.special@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).