From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: Tramp and fixnum Date: Tue, 28 Aug 2018 08:18:39 -0700 Organization: UCLA Computer Science Department Message-ID: References: <29f933ac-a6bf-8742-66a7-0a9d6d3e5a88@disroot.org> <765767b2-d2e5-a9a6-f724-d58ecf4847bb@cs.ucla.edu> <76081b5d-8c10-0a37-2c97-d4864c0faa80@cs.ucla.edu> <09153aed-361d-4f82-d9ac-b502314769ae@cs.ucla.edu> <83lg91dqd4.fsf@gnu.org> <87pny59tz9.fsf_-_@gmx.de> <81bdf4a7-cfa7-40c6-af17-f4f6d6fd8518@cs.ucla.edu> <87h8jh9ipp.fsf@gmx.de> <684c41b6-137e-484d-d4fe-36d4dc06cff7@cs.ucla.edu> <87zhx690cp.fsf@gmx.de> <87r2iiy31c.fsf@gmx.de> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1535470703 8700 195.159.176.226 (28 Aug 2018 15:38:23 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 28 Aug 2018 15:38:23 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 Cc: emacs-devel@gnu.org To: Michael Albinus Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Aug 28 17:38:19 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fug4P-00026w-0Q for ged-emacs-devel@m.gmane.org; Tue, 28 Aug 2018 17:38:17 +0200 Original-Received: from localhost ([::1]:38754 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fug6V-0004gY-5F for ged-emacs-devel@m.gmane.org; Tue, 28 Aug 2018 11:40:27 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44812) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fug1N-0007YO-J1 for emacs-devel@gnu.org; Tue, 28 Aug 2018 11:35:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fuflT-0000ps-PT for emacs-devel@gnu.org; Tue, 28 Aug 2018 11:18:46 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:60198) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fuflT-0000o2-Iw for emacs-devel@gnu.org; Tue, 28 Aug 2018 11:18:43 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A5A081609A0; Tue, 28 Aug 2018 08:18:41 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id AkoowMEjIolU; Tue, 28 Aug 2018 08:18:40 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 43EBF160CCA; Tue, 28 Aug 2018 08:18:40 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id avO_P7YGMZWw; Tue, 28 Aug 2018 08:18:40 -0700 (PDT) Original-Received: from [192.168.1.9] (cpe-23-242-74-103.socal.res.rr.com [23.242.74.103]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id D01B01609A0; Tue, 28 Aug 2018 08:18:39 -0700 (PDT) In-Reply-To: <87r2iiy31c.fsf@gmx.de> Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:229016 Archived-At: Michael Albinus wrote: > And for the inode number conversion, I check whether function `bignump' > is available. If yes, I don't convert. I must be slow this morning, but I don't see why that test needs to know whether bignums are supported. That is, for this change: - ;; Convert inode. - (unless (listp (nth 10 attr)) + ;; Convert inode. Big numbers have been added to Emacs 27. + (unless (or (fboundp 'bignump) (listp (nth 10 attr))) How about changing to the following instead? (let ((inode (nth 10 attr))) (unless (or (integerp inode) (listp inode)) ... That is, if the inode number is already an integer, leave it alone. This should work regardless of whether bignums are supported.