unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: "Clément Pit-Claudel" <cpitclaudel@gmail.com>
To: emacs-devel@gnu.org
Subject: Re: How can I undo a change from a modification-hook?
Date: Thu, 27 Apr 2017 08:58:53 -0400	[thread overview]
Message-ID: <c3749131-ecd2-e342-1f21-999bada4420c@gmail.com> (raw)
In-Reply-To: <jwvinlqrpc3.fsf-monnier+gmane.emacs.devel@gnu.org>

On 2017-04-27 08:48, Stefan Monnier wrote:
>> Of course, I could rewrite the queuing logic to be more resilient to this
>> kind of changes.  But the question is about ways to prevent edits, and
>> I think it's more general than this particular example.
>
> Then I woulnd't worry too much about it: the cases where the after-hook
> is called "outside" of the before hook's beg/end are basically bugs and
> IIUC there are no known remaining cases in Emacs-26 (IIRC there are some
> known cases in Emacs-25 where this occurs, mostly in
> insert-file-contents (i.e. revert-buffer)).

Got it, thanks.  I already have specialized code for revert-buffer, so that should be fine.
What happens if a deletion causes an overlay to evaporate? The undo list doesn't record that, does it? Or will the evaporation be delayed until all modification hooks have run?

Clément.



  reply	other threads:[~2017-04-27 12:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-26  7:02 How can I undo a change from a modification-hook? Clément Pit--Claudel
2017-04-26 12:26 ` Stefan Monnier
2017-04-26 13:45   ` Clément Pit-Claudel
2017-04-26 13:52     ` Stefan Monnier
2017-04-26 14:23       ` Clément Pit-Claudel
2017-04-26 14:51         ` Stefan Monnier
2017-04-26 16:38           ` Clément Pit-Claudel
2017-04-26 18:43             ` Stefan Monnier
2017-04-26 19:02               ` Clément Pit-Claudel
2017-04-27 12:48                 ` Stefan Monnier
2017-04-27 12:58                   ` Clément Pit-Claudel [this message]
2017-04-27 17:36                     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3749131-ecd2-e342-1f21-999bada4420c@gmail.com \
    --to=cpitclaudel@gmail.com \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).