From: Dmitry Gutov <dgutov@yandex.ru>
To: Tom Tromey <tom@tromey.com>
Cc: Emacs discussions <emacs-devel@gnu.org>
Subject: Re: html, css, and js modes working together
Date: Mon, 6 Feb 2017 05:46:48 +0200 [thread overview]
Message-ID: <c2418584-25da-9986-011b-6a7b43cd0b73@yandex.ru> (raw)
In-Reply-To: <87fujs80fk.fsf@tromey.com>
On 06.02.2017 05:26, Tom Tromey wrote:
> I'm not sure what you're referring to here. Do some of the existing
> mixed mode things piggyback on the existing html mode?
Both https://github.com/purcell/mmm-mode/ and
https://github.com/vspinu/polymode/ do.
> I guess my view is that it is always ok to make things in-tree work
> better with each other, even at the expense of some code that is
> out-of-tree and presumably relying on implementation details to do its
> work.
Still, defining a new major mode instead of directly reusing an existing
one shouldn't take a lot of effort. Especially while the result is
functional but not ideal.
And breaking packages that worked fine for many years is not nice,
especially when it can be avoided.
> Dmitry> So far it's only used in python-mode, I think.
>
> grep shows no users in-tree, so maybe this never went in? Or is this
> one of the various out-of-tree python modes?
lisp/progmodes/python.el uses prog-first-column and prog-widen, both of
which refer to prog-indentation-context.
> Yeah, what I mean is that font-locking does not occur, but it would be
> good to have. I couldn't find anything saying how this might be solved.
> I haven't come up with any really good ideas myself. Maybe font-lock
> could also look at text properties to decide what keywords to use?
Here's one way to do it:
https://github.com/purcell/mmm-mode/blob/master/mmm-region.el#L768-L787
> Dmitry> - Both css-mode and js-mode call syntax-ppss in their indentation
> Dmitry> code. Luckily, their syntax tables are fairly compatible. But
> Dmitry> sgml-syntax-propertize-rules calls syntax-ppss as well.
>
> I thought that a syntax-table property on the characters would make
> syntax-ppss do the "right" thing; namely, notice where the syntax table
> changes and change its parsing method accordingly.
That seems orthogonal to the possibility of breaking the cache after
calling syntax-ppss while a different syntax table is in effect.
The characters with the syntax-table text property set should be the
same in both "world views", but they are usually a minority.
> I didn't try your example yet. Thanks for providing that, that's very
> helpful.
No problem. BTW, I've worked around it with a hack like this:
https://github.com/purcell/mmm-mode/blob/master/mmm-erb.el#L93-L98
next prev parent reply other threads:[~2017-02-06 3:46 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-31 20:34 html, css, and js modes working together Tom Tromey
2017-02-01 7:29 ` Clément Pit-Claudel
2017-02-07 4:33 ` Tom Tromey
2017-02-10 2:31 ` Tom Tromey
2017-02-02 14:19 ` Stefan Monnier
[not found] ` <87mvdy7f2g.fsf@tromey.com>
2017-02-07 14:33 ` Stefan Monnier
2017-02-06 3:08 ` Dmitry Gutov
2017-02-06 3:26 ` Tom Tromey
2017-02-06 3:46 ` Dmitry Gutov [this message]
2017-02-06 6:50 ` Clément Pit-Claudel
2017-02-06 14:17 ` Stefan Monnier
2017-02-06 20:25 ` Tom Tromey
2017-02-06 20:58 ` Dmitry Gutov
2017-02-06 22:42 ` Stefan Monnier
2017-02-06 23:51 ` Lennart Borgman
2017-02-07 3:40 ` Tom Tromey
2017-02-07 11:28 ` Dmitry Gutov
2017-02-09 23:45 ` Tom Tromey
2017-02-10 20:05 ` Stefan Monnier
2017-02-10 21:15 ` Tom Tromey
2017-02-10 23:45 ` Stefan Monnier
2017-02-11 17:46 ` Tom Tromey
2017-02-11 20:20 ` Stefan Monnier
2017-02-12 16:17 ` Dmitry Gutov
2017-02-12 16:20 ` Dmitry Gutov
2017-02-12 16:52 ` Tom Tromey
2017-02-13 1:12 ` Dmitry Gutov
2017-02-13 1:59 ` Dmitry Gutov
2017-02-13 2:48 ` Tom Tromey
2017-02-14 1:34 ` Dmitry Gutov
2017-03-19 17:30 ` Tom Tromey
2017-03-21 9:15 ` Dmitry Gutov
2017-03-24 3:18 ` Tom Tromey
2017-03-24 12:02 ` Stefan Monnier
2017-03-24 12:08 ` Toon Claes
2017-03-24 12:59 ` Noam Postavsky
2017-03-24 14:17 ` Tom Tromey
2017-04-05 22:01 ` Tom Tromey
2017-04-06 2:28 ` Leo Liu
2017-04-06 14:12 ` Dmitry Gutov
2017-02-11 17:39 ` Tom Tromey
2017-02-11 19:48 ` Stefan Monnier
2017-02-12 3:49 ` Tom Tromey
2017-02-12 5:26 ` Stefan Monnier
2017-02-12 6:14 ` Tom Tromey
2017-02-12 7:02 ` Stefan Monnier
2017-02-12 7:22 ` Tom Tromey
2017-02-12 11:14 ` martin rudalics
2017-02-12 16:01 ` Eli Zaretskii
2017-02-12 16:32 ` Tom Tromey
2017-02-12 17:14 ` Stefan Monnier
2017-02-12 17:36 ` Tom Tromey
2017-02-12 18:17 ` Eli Zaretskii
2017-02-12 16:59 ` Stefan Monnier
2017-02-11 0:28 ` Please ack Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2418584-25da-9986-011b-6a7b43cd0b73@yandex.ru \
--to=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).