From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 2f5e0b1: Improve case-insensitive checks (Bug#24441) Date: Mon, 14 Nov 2016 17:33:18 -0500 Message-ID: References: <83twb9hnba.fsf@gnu.org> <2cee3b57-fbda-a604-699b-23a06a982f3b@cornell.edu> <83shqthjxm.fsf@gnu.org> <1468a431-78a8-7fbc-f937-14f54a55721e@cs.ucla.edu> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------6C3ADBE830DCA657FF0AA3A8" X-Trace: blaine.gmane.org 1479162901 30751 195.159.176.226 (14 Nov 2016 22:35:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 14 Nov 2016 22:35:01 +0000 (UTC) User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 Cc: emacs-devel@gnu.org To: Paul Eggert , Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 14 23:34:53 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1c6PpI-0001DJ-Nn for ged-emacs-devel@m.gmane.org; Mon, 14 Nov 2016 23:34:08 +0100 Original-Received: from localhost ([::1]:43001 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6PpK-0003QZ-8K for ged-emacs-devel@m.gmane.org; Mon, 14 Nov 2016 17:34:10 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37895) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6Pog-0003QU-On for emacs-devel@gnu.org; Mon, 14 Nov 2016 17:33:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1c6Pob-0000TU-MR for emacs-devel@gnu.org; Mon, 14 Nov 2016 17:33:30 -0500 Original-Received: from limerock04.mail.cornell.edu ([128.84.13.244]:60103) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1c6Pob-0000TL-Il; Mon, 14 Nov 2016 17:33:25 -0500 X-CornellRouted: This message has been Routed already. Original-Received: from authusersmtp.mail.cornell.edu (granite4.serverfarm.cornell.edu [10.16.197.9]) by limerock04.mail.cornell.edu (8.14.4/8.14.4_cu) with ESMTP id uAEMXJhC011336; Mon, 14 Nov 2016 17:33:20 -0500 Original-Received: from [192.168.1.9] (mta-68-175-148-36.twcny.rr.com [68.175.148.36] (may be forged)) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id uAEMXIli011080 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Mon, 14 Nov 2016 17:33:19 -0500 In-Reply-To: X-PMX-Cornell-Gauge: Gauge=XXXXX X-PMX-CORNELL-AUTH-RESULTS: dkim-out=none; X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 128.84.13.244 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:209401 Archived-At: This is a multi-part message in MIME format. --------------6C3ADBE830DCA657FF0AA3A8 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 11/14/2016 4:07 PM, Ken Brown wrote: > On 11/14/2016 3:54 PM, Paul Eggert wrote: >> On 11/14/2016 12:43 PM, Eli Zaretskii wrote: >>> I'd be glad to see the solution improved, of course. >> >> I thought those changes were relatively minor technical improvements. >> Evidently they were taken as intrusive and stepping on other peoples' >> toes. Sorry about that; that was certainly not the intent. Please feel >> free to ignore the changes. > > I don't want to ignore the changes. I'll send a new patch that > incorporates some of your changes. Here it is. Ken --------------6C3ADBE830DCA657FF0AA3A8 Content-Type: text/plain; charset=UTF-8; name="0001-Simplify-case-insensitivity-checks-on-Mac-OS-X.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename*0="0001-Simplify-case-insensitivity-checks-on-Mac-OS-X.patch" RnJvbSA5M2NkNGVlMWZjMjYxYmNhNWQ5ZDU0ZjZlMTM2NmU3NDY2OGNjYzI5IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBLZW4gQnJvd24gPGticm93bkBjb3JuZWxsLmVkdT4K RGF0ZTogTW9uLCAxNCBOb3YgMjAxNiAxNzoyNjoxMiAtMDUwMApTdWJqZWN0OiBbUEFUQ0hd IFNpbXBsaWZ5IGNhc2UtaW5zZW5zaXRpdml0eSBjaGVja3Mgb24gTWFjIE9TIFgKCiogc3Jj L2ZpbGVpby5jIChmaWxlX25hbWVfY2FzZV9pbnNlbnNpdGl2ZV9wKTogVHJ5IHNraXBwaW5n IHRoZQpEYXJ3aW4gY29kZSBhbmQgaW5zdGVhZCB1c2luZyBwYXRoY29uZiB3aXRoIF9QQ19D QVNFX1NFTlNJVElWRS4KTGVhdmUgaW4gdHdvIGFsdGVybmF0aXZlcyBjb25kaXRpb25hbGx5 IGNvbXBpbGVkIGJhc2VkIG9uCkRBUldJTl9PU19DQVNFX1NFTlNJVElWRV9GSVhNRSBpbiBj YXNlIHBhdGhjb25mIGRvZXNuJ3Qgd29yay4KLS0tCiBzcmMvZmlsZWlvLmMgfCA4MSArKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0t LS0KIDEgZmlsZSBjaGFuZ2VkLCA1NyBpbnNlcnRpb25zKCspLCAyNCBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9zcmMvZmlsZWlvLmMgYi9zcmMvZmlsZWlvLmMKaW5kZXggZjNmOGY0 Mi4uNzA3OTllYiAxMDA2NDQKLS0tIGEvc3JjL2ZpbGVpby5jCisrKyBiL3NyYy9maWxlaW8u YwpAQCAtMjI1MSwzMyArMjI1MSw2NiBAQCBpbnRlcm5hbF9kZWxldGVfZmlsZSAoTGlzcF9P YmplY3QgZmlsZW5hbWUpCiBzdGF0aWMgYm9vbAogZmlsZV9uYW1lX2Nhc2VfaW5zZW5zaXRp dmVfcCAoY29uc3QgY2hhciAqZmlsZW5hbWUpCiB7Ci0jaWZkZWYgRE9TX05UCi0gIHJldHVy biAxOwotI2VsaWYgZGVmaW5lZCBDWUdXSU4KLS8qIEFzIG9mIEN5Z3dpbi0yLjYuMSwgcGF0 aGNvbmYgc3VwcG9ydHMgX1BDX0NBU0VfSU5TRU5TSVRJVkUuICAqLwotIyBpZmRlZiBfUENf Q0FTRV9JTlNFTlNJVElWRQorICAvKiBVc2UgcGF0aGNvbmYgd2l0aCBfUENfQ0FTRV9JTlNF TlNJVElWRSBvciBfUENfQ0FTRV9TRU5TSVRJVkUgaWYKKyAgICAgdGhvc2UgZmxhZ3MgYXJl IGF2YWlsYWJsZS4gIEFzIG9mIHRoaXMgd3JpdGluZyAoMjAxNi0xMS0xNCksCisgICAgIEN5 Z3dpbiBpcyB0aGUgb25seSBwbGF0Zm9ybSBrbm93biB0byBzdXBwb3J0IHRoZSBmb3JtZXIg KHN0YXJ0aW5nCisgICAgIHdpdGggQ3lnd2luLTIuNi4xKSwgYW5kIE1hYyBPUyBYIGlzIHRo ZSBvbmx5IHBsYXRmb3JtIGtub3duIHRvCisgICAgIHN1cHBvcnQgdGhlIGxhdHRlci4KKwor ICAgICBUaGVyZSBoYXZlIGJlZW4gcmVwb3J0cyB0aGF0IHBhdGhjb25mIHdpdGggX1BDX0NB U0VfU0VOU0lUSVZFCisgICAgIGRvZXMgbm90IHdvcmsgcmVsaWFibHkgb24gTWFjIE9TIFgu ICBJZiB5b3UgaGF2ZSBhIHByb2JsZW0sCisgICAgIHBsZWFzZSByZWNvbXBpbGUgRW1hY3Mg d2l0aCAtRERBUldJTl9PU19DQVNFX1NFTlNJVElWRV9GSVhNRT0xIG9yCisgICAgIC1EREFS V0lOX09TX0NBU0VfU0VOU0lUSVZFX0ZJWE1FPTIsIGFuZCBmaWxlIGEgYnVnIHJlcG9ydCBz YXlpbmcKKyAgICAgd2hldGhlciB0aGlzIGZpeGVkIHlvdXIgcHJvYmxlbS4gICovCisKKyNp ZmRlZiBfUENfQ0FTRV9JTlNFTlNJVElWRQogICBpbnQgcmVzID0gcGF0aGNvbmYgKGZpbGVu YW1lLCBfUENfQ0FTRV9JTlNFTlNJVElWRSk7Ci0gIGlmIChyZXMgPCAwKQotICAgIHJldHVy biAxOwotICByZXR1cm4gcmVzID4gMDsKLSMgZWxzZQotICByZXR1cm4gMTsKKyAgaWYgKHJl cyA+PSAwKQorICAgIHJldHVybiByZXMgPiAwOworI2VsaWYgZGVmaW5lZCBfUENfQ0FTRV9T RU5TSVRJVkUgJiYgIWRlZmluZWQgREFSV0lOX09TX0NBU0VfU0VOU0lUSVZFX0ZJWE1FCisg IGludCByZXMgPSBwYXRoY29uZiAoZmlsZW5hbWUsIF9QQ19DQVNFX1NFTlNJVElWRSk7Cisg IGlmIChyZXMgPj0gMCkKKyAgICByZXR1cm4gcmVzID09IDA7CisjZW5kaWYKKworI2lmZGVm IERBUldJTl9PUworIyBpZm5kZWYgREFSV0lOX09TX0NBU0VfU0VOU0lUSVZFX0ZJWE1FCisg IGludCBEQVJXSU5fT1NfQ0FTRV9TRU5TSVRJVkVfRklYTUUgPSAwOwogIyBlbmRpZgotI2Vs aWYgZGVmaW5lZCBEQVJXSU5fT1MKLSAgLyogVGhlIGZvbGxvd2luZyBpcyBiYXNlZCBvbgot ICAgICBodHRwOi8vbGlzdHMuYXBwbGUuY29tL2FyY2hpdmVzL2Rhcndpbi1kZXYvMjAwNy9B cHIvbXNnMDAwMTAuaHRtbC4gICovCi0gIHN0cnVjdCBhdHRybGlzdCBhbGlzdDsKLSAgdW5z aWduZWQgY2hhciBidWZmZXJbc2l6ZW9mICh2b2xfY2FwYWJpbGl0aWVzX2F0dHJfdCkgKyBz aXplb2YgKHNpemVfdCldOwotCi0gIG1lbXNldCAoJmFsaXN0LCAwLCBzaXplb2YgKGFsaXN0 KSk7Ci0gIGFsaXN0LnZvbGF0dHIgPSBBVFRSX1ZPTF9DQVBBQklMSVRJRVM7Ci0gIGlmIChn ZXRhdHRybGlzdCAoZmlsZW5hbWUsICZhbGlzdCwgYnVmZmVyLCBzaXplb2YgKGJ1ZmZlciks IDApCi0gICAgICB8fCAhKGFsaXN0LnZvbGF0dHIgJiBBVFRSX1ZPTF9DQVBBQklMSVRJRVMp KQotICAgIHJldHVybiAwOwotICB2b2xfY2FwYWJpbGl0aWVzX2F0dHJfdCAqdmNhcHMgPSBi dWZmZXI7Ci0gIHJldHVybiAhKHZjYXBzLT5jYXBhYmlsaXRpZXNbMF0gJiBWT0xfQ0FQX0ZN VF9DQVNFX1NFTlNJVElWRSk7CisKKyAgaWYgKERBUldJTl9PU19DQVNFX1NFTlNJVElWRV9G SVhNRSA9PSAxKQorICAgIHsKKyAgICAgIC8qIFRoaXMgaXMgYmFzZWQgb24gZGV2ZWxvcGVy LmFwcGxlLmNvbSdzIGdldGF0dHJsaXN0IG1hbiBwYWdlLiAgKi8KKyAgICAgIHN0cnVjdCBh dHRybGlzdCBhbGlzdCA9IHsudm9sYXR0ciA9IEFUVFJfVk9MX0NBUEFCSUxJVElFU307Cisg ICAgICBzdHJ1Y3Qgdm9sX2NhcGFiaWxpdGllc19hdHRyX3QgdmNhcHM7CisgICAgICBpZiAo Z2V0YXR0cmxpc3QgKGZpbGVuYW1lLCAmYWxpc3QsICZ2Y2Fwcywgc2l6ZW9mIHZjYXBzLCAw KSA9PSAwKQorCXsKKwkgIGlmICh2Y2Fwcy52YWxpZFtWT0xfQ0FQQUJJTElUSUVTX0ZPUk1B VF0gJiBWT0xfQ0FQX0ZNVF9DQVNFX1NFTlNJVElWRSkKKwkgICAgcmV0dXJuICEgKHZjYXBz LmNhcGFiaWxpdGllc1tWT0xfQ0FQQUJJTElUSUVTX0ZPUk1BVF0KKwkJICAgICAgJiBWT0xf Q0FQX0ZNVF9DQVNFX1NFTlNJVElWRSk7CisJfQorICAgIH0KKyAgZWxzZSBpZiAoREFSV0lO X09TX0NBU0VfU0VOU0lUSVZFX0ZJWE1FID09IDIpCisgICAgeworICAgICAgLyogVGhlIGZv bGxvd2luZyBpcyBiYXNlZCBvbgorCSBodHRwOi8vbGlzdHMuYXBwbGUuY29tL2FyY2hpdmVz L2Rhcndpbi1kZXYvMjAwNy9BcHIvbXNnMDAwMTAuaHRtbC4gICovCisgICAgICBzdHJ1Y3Qg YXR0cmxpc3QgYWxpc3Q7CisgICAgICB1bnNpZ25lZCBjaGFyIGJ1ZmZlcltzaXplb2YgKHZv bF9jYXBhYmlsaXRpZXNfYXR0cl90KSAgc2l6ZW9mIChzaXplX3QpXTsKKworICAgICAgbWVt c2V0ICgmYWxpc3QsIDAsIHNpemVvZiAoYWxpc3QpKTsKKyAgICAgIGFsaXN0LnZvbGF0dHIg PSBBVFRSX1ZPTF9DQVBBQklMSVRJRVM7CisgICAgICBpZiAoZ2V0YXR0cmxpc3QgKGZpbGVu YW1lLCAmYWxpc3QsIGJ1ZmZlciwgc2l6ZW9mIChidWZmZXIpLCAwKQorCSAgfHwgIShhbGlz dC52b2xhdHRyICYgQVRUUl9WT0xfQ0FQQUJJTElUSUVTKSkKKwlyZXR1cm4gMDsKKyAgICAg IHZvbF9jYXBhYmlsaXRpZXNfYXR0cl90ICp2Y2FwcyA9IGJ1ZmZlcjsKKyAgICAgIHJldHVy biAhKHZjYXBzLT5jYXBhYmlsaXRpZXNbMF0gJiBWT0xfQ0FQX0ZNVF9DQVNFX1NFTlNJVElW RSk7CisgICAgfQorI2VuZGlmCS8qIERBUldJTl9PUyAqLworCisjaWYgZGVmaW5lZCBDWUdX SU4gfHwgZGVmaW5lZCBET1NfTlQKKyAgcmV0dXJuIHRydWU7CiAjZWxzZQotICByZXR1cm4g MDsKKyAgcmV0dXJuIGZhbHNlOwogI2VuZGlmCiB9CiAKLS0gCjIuOC4zCgo= --------------6C3ADBE830DCA657FF0AA3A8--