From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Daniel Colascione Newsgroups: gmane.emacs.devel Subject: Re: Why is custom--inhibit-theme-enable not t by default? Date: Tue, 19 Jun 2018 07:49:05 -0700 Message-ID: References: <10b7bd657091b074d8da1bf1ae35b1f4.squirrel@dancol.org> <83h8m8owp2.fsf@gnu.org> <48a7bd1277a18dd0a68d06cd8b022062.squirrel@dancol.org> <86vaahgkvz.fsf@gmail.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1529419638 32751 195.159.176.226 (19 Jun 2018 14:47:18 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 19 Jun 2018 14:47:18 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 To: Andy Moreton , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Jun 19 16:47:14 2018 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fVHuc-0008P6-CR for ged-emacs-devel@m.gmane.org; Tue, 19 Jun 2018 16:47:14 +0200 Original-Received: from localhost ([::1]:43090 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVHwj-0006e2-Cn for ged-emacs-devel@m.gmane.org; Tue, 19 Jun 2018 10:49:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:47471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fVHwX-0006cn-I3 for emacs-devel@gnu.org; Tue, 19 Jun 2018 10:49:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fVHwW-00009b-IW for emacs-devel@gnu.org; Tue, 19 Jun 2018 10:49:13 -0400 Original-Received: from dancol.org ([2600:3c01::f03c:91ff:fedf:adf3]:54456) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fVHwW-00008h-9R for emacs-devel@gnu.org; Tue, 19 Jun 2018 10:49:12 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=dancol.org; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:To:Subject; bh=8foCyYbA/YGYsjJUzH2GTLAmvELqg0RwNNbBR9+F6n4=; b=cI1WusgvWGeUhk/EZR9PwSVnoxDw/HANSMJMO8/ArUBv10KUPZpVUN1rmDUflMgxIXru0NsNXKOi4xboIYQPvN6i30qmAP7mfxJq5ZpdcbgnhgajNvcGp66diwTk9nOPfDFhngReIENxoWKhOqi7RgItf6PbdH2InXgGJP0SXcw+6x8jzq289j3/aRQjM+PivJ3ksycFUU62RY1v/a0rDUwhfHxTRthM9SCwK1oFmGQVZovZfv5s/AwwsyprCz0h9PgVPC0y5HAYiziu8cL9GixH8SyUU7lxe1OrtC/ntWhGaDm9xz8mimxUyEd+PpVV4jvcnXlDdVTRildDOkZ+4Q==; Original-Received: from [2604:4080:1321:8c20:d991:ea76:d225:59a1] by dancol.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1fVHwV-0002Tq-6U; Tue, 19 Jun 2018 07:49:11 -0700 In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2600:3c01::f03c:91ff:fedf:adf3 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:226510 Archived-At: On 06/18/2018 07:07 AM, Andy Moreton wrote: > On Sun 17 Jun 2018, Andy Moreton wrote: > >> On Tue 12 Jun 2018, dancol@dancol.org wrote: >> >>>>> Date: Mon, 11 Jun 2018 21:14:49 -0700 >>>>> From: dancol@dancol.org >>>>> >>>>> A simple require of a package shouldn't have side effects, especially >>>>> not >>>>> ones as drastic as changing the entire appearance of the program. >>>> >>>> I think themes are special in this regard: loading a theme activates >>>> it. >>>> >>> >>> Why did we do it that way? Is it too late to change it? Loading _anything_ >>> shouldn't activate it. I don't see a need to carve out a special case for >>> themes. >>> >>> At the very least, we should make custom--inhibit-theme-enable a public >>> variable so people can let-binding something that lets them load theme >>> code normally without the expectation of serious side effects. >> >> The changes you made in commit aabaa9f8c8b7 ("Apply non-user themes only >> when asked") break use of custom faces with use-package. E.g. in gnus: >> >> (use-package gnus >> :custom-face >> (gnus-summary-selected >> ((((class color)) :foreground "Black" :background "PaleGoldenrod"))) >> :config >> ;; other setup >> ) >> >> The observed symptom is that the faces are not set correctly as specified >> after the :custom-face keyword. However if the same buffer is viewed in >> a new frame then it is displayed with the correct customised faces. >> >> This is a regression introduced by this commit - please take a look. > > It appears that the change in cus-face.el in commit aabaa9f8c8b7 did not > match the other hunks and invert the test when changing from > `custom--inhibit-theme-enable' to `custom--should-apply-setting'. > > The following patch fixes it: Thanks. I've applied your patch.