From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-26 3db388b: Speed up (format "%s" STRING) and the like Date: Fri, 6 Oct 2017 11:06:20 -0700 Organization: UCLA Computer Science Department Message-ID: References: <20171004214511.1405.22257@vcs0.savannah.gnu.org> <20171004214513.6A40E2041C@vcs0.savannah.gnu.org> <4fc424a0-fc11-2565-5bdb-c8691bf0323d@cs.ucla.edu> <83h8vexd94.fsf@gnu.org> <83k209whwr.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: blaine.gmane.org 1507313234 9738 195.159.176.226 (6 Oct 2017 18:07:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Fri, 6 Oct 2017 18:07:14 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 Cc: Eli Zaretskii , emacs-devel@gnu.org, monnier@iro.umontreal.ca, oleh@oremacs.com To: Kaushal Modi Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 06 20:07:10 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e0X1Z-000190-PE for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 20:07:01 +0200 Original-Received: from localhost ([::1]:46658 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0X1h-0006gm-10 for ged-emacs-devel@m.gmane.org; Fri, 06 Oct 2017 14:07:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48210) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e0X13-0006gT-UH for emacs-devel@gnu.org; Fri, 06 Oct 2017 14:06:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e0X13-0000Pm-5r for emacs-devel@gnu.org; Fri, 06 Oct 2017 14:06:29 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:42860) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e0X0x-0000ME-Lv; Fri, 06 Oct 2017 14:06:23 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id D9C7016018B; Fri, 6 Oct 2017 11:06:21 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id pAK9uptM5plD; Fri, 6 Oct 2017 11:06:21 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 329C6160E5D; Fri, 6 Oct 2017 11:06:21 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id vUkGn9zlDN8j; Fri, 6 Oct 2017 11:06:21 -0700 (PDT) Original-Received: from Penguin.CS.UCLA.EDU (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 18ED016018B; Fri, 6 Oct 2017 11:06:21 -0700 (PDT) In-Reply-To: Content-Language: en-US X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:219204 Archived-At: On 10/06/2017 10:49 AM, Kaushal Modi wrote: > what would be the simplest way to explain why it worked using the > Makefile in hydra pkg, but not when installed via pacakge.el? Inspite > of same (right?) .elc files? The .elc files were not the same. However, I think that was a blind alley, as .elc differences can be benign. The diagnostic was output only when (format FOO) was called with a long FOO (greater than 235 chars, roughly) without any % directives in it, and where the (format FOO) call was either directly from bytecode or indirectly via channels that never used unbind_to. The Makefile approach didn't byte-compile one of the files that the package.el approach compiled, and I suspect that the different path to (lv-message "long format with no % directives") explained why I didn't reproduce the bug at first.