unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dmitry@gutov.dev>
To: Eli Zaretskii <eliz@gnu.org>, philipk@posteo.net
Cc: monnier@iro.umontreal.ca, emacs-devel@gnu.org
Subject: Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change.
Date: Sun, 7 May 2023 12:50:31 +0300	[thread overview]
Message-ID: <c0b00b98-61c2-3212-bb3d-0739ead3ea9b@gutov.dev> (raw)
In-Reply-To: <83v8h4elki.fsf@gnu.org>

On 07/05/2023 08:51, Eli Zaretskii wrote:
>> Date: Sat, 6 May 2023 23:31:31 +0300
>> Cc: philipk@posteo.net, monnier@iro.umontreal.ca, emacs-devel@gnu.org
>> From: Dmitry Gutov <dmitry@gutov.dev>
>>
>> On 06/05/2023 22:38, Eli Zaretskii wrote:
>>>> package-menu-mark-upgrades ('U') is not affected by
>>>> package-install-upgrade-built-in. It won't.
>>>
>>> Shouldn't it?
>>
>> Maybe, maybe not.
> 
> I think it better did, because using "U" would upgrade Eglot and
> use-package in Emacs 28 and before.  So we should give users who want
> that the capability of keeping that workflow in Emacs 29, if only as
> opt-in behavior.
> 
> Also, "/ u" should ideally show built-in packages as well, when
> package-install-upgrade-built-in is non-nil.

So we think upgrading built-in packages could be dangerous, but if the 
user wants to upgrade Eglot, then upgrading all built-ins is suddenly fine?

> Philip, can these two changes be implemented safely for Emacs 29?
> 
>> A user that customized that option to have (package-install 'eglot)
>> ensure that a version from ELPA is installed might not want or expect
>> for it to affect package-menu-mark-upgrades and/or package-upgrade-all.
> 
> That is true, but denying them the possibility of upgrading would be
> worse, I think.  And since this is opt-in behavior, the user is less
> likely to be tripped by that without realizing it.
> 
>> Or anticipate the full consequences anyway.
> 
> Documentation should solve this aspect.

If the only way to get a basic scenario to work is to toggle a pref, we 
won't be able to go back and say "you shouldn't have toggled it".

If we don't actually consider upgrading of all built-ins to be a 
problem, and are just hesitant to enable it in Emacs 29, then I guess it 
is fine.

Otherwise, we've had a pretty good idea posted previously: patch where a 
variable holds the list of builtins that should be upgraded automatically.




  parent reply	other threads:[~2023-05-07  9:50 UTC|newest]

Thread overview: 52+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <168335548287.8529.4912240840977468283@vcs2.savannah.gnu.org>
     [not found] ` <20230506064443.56C75C22F15@vcs2.savannah.gnu.org>
2023-05-06 10:14   ` emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change Dmitry Gutov
2023-05-06 10:35     ` Eli Zaretskii
2023-05-06 10:46       ` Dmitry Gutov
2023-05-06 10:53         ` Eli Zaretskii
2023-05-06 13:03           ` João Távora
2023-05-06 13:22             ` Eli Zaretskii
2023-05-06 13:48               ` João Távora
2023-05-06 14:11                 ` Eli Zaretskii
2023-05-06 14:45                   ` Eli Zaretskii
2023-05-06 15:28                 ` Dmitry Gutov
2023-05-06 15:26               ` Dmitry Gutov
2023-05-06 15:44                 ` Eli Zaretskii
2023-05-06 15:54                   ` Dmitry Gutov
2023-05-06 16:40                     ` Eli Zaretskii
2023-05-06 18:44                       ` Philip Kaludercic
2023-05-06 19:08                         ` Eli Zaretskii
2023-05-07  7:43                           ` Philip Kaludercic
2023-05-06 19:15                         ` Dmitry Gutov
2023-05-06 19:14                       ` Dmitry Gutov
2023-05-06 19:38                         ` Eli Zaretskii
2023-05-06 20:31                           ` Dmitry Gutov
2023-05-06 20:52                             ` João Távora
2023-05-07  5:51                             ` Eli Zaretskii
2023-05-07  8:46                               ` Philip Kaludercic
2023-05-07  9:32                                 ` Eli Zaretskii
2023-05-07 17:16                                   ` Philip Kaludercic
2023-05-07 18:32                                     ` Eli Zaretskii
2023-05-07 19:24                                       ` Philip Kaludercic
2023-05-07 19:32                                         ` Eli Zaretskii
2023-05-07 19:44                                           ` Philip Kaludercic
2023-05-08 11:19                                             ` Eli Zaretskii
2023-05-12 12:35                                               ` Eli Zaretskii
2023-05-08 11:20                                             ` Eli Zaretskii
2023-05-08 13:34                                               ` Philip Kaludercic
2023-05-08 13:44                                                 ` Eli Zaretskii
2023-05-10  6:59                                                   ` Philip Kaludercic
2023-05-10 11:03                                                     ` Philip Kaludercic
2023-05-10 14:06                                                       ` Eli Zaretskii
2023-05-10 15:02                                                       ` Ruijie Yu via Emacs development discussions.
2023-05-11  7:29                                                         ` Philip Kaludercic
2023-05-10 22:19                                                       ` Dmitry Gutov
2023-05-11  7:26                                                         ` Philip Kaludercic
2023-05-11  9:43                                                           ` Dmitry Gutov
2023-05-11 10:46                                                             ` Eli Zaretskii
2023-05-12  6:43                                                             ` Philip Kaludercic
2023-05-07 20:36                                           ` Dmitry Gutov
2023-05-08 11:24                                             ` Eli Zaretskii
2023-05-08 21:39                                               ` Dmitry Gutov
2023-05-12 12:34                                               ` Eli Zaretskii
2023-05-07  9:50                               ` Dmitry Gutov [this message]
2023-05-07 10:55                                 ` Eli Zaretskii
2023-05-06 16:58                 ` João Távora

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c0b00b98-61c2-3212-bb3d-0739ead3ea9b@gutov.dev \
    --to=dmitry@gutov.dev \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=monnier@iro.umontreal.ca \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).