unofficial mirror of emacs-devel@gnu.org 
 help / color / mirror / code / Atom feed
From: Miles Bader <miles@lsi.nec.co.jp>
Cc: Andreas Schwab <schwab@suse.de>, David Kastrup <dak@gnu.org>,
	emacs-devel@gnu.org
Subject: Re: [PATCH] Delayed loading of image libraries
Date: Fri, 02 Jul 2004 16:56:51 +0900	[thread overview]
Message-ID: <buosmcaalks.fsf@mctpc71.ucom.lsi.nec.co.jp> (raw)
In-Reply-To: <20040702093521.CF34.JMBARRANQUERO@wke.es> (Juanma Barranquero's message of "Fri, 02 Jul 2004 09:41:53 +0200")

Juanma Barranquero <jmbarranquero@wke.es> writes:
> Sure.  But currently, an Emacs supporting PNG *will* display a PNG if
> the library is made available (either statically or dynamically).  Miles
> thinks (or so I understand) that the responsability of making the
> library available rests on lookup_image_type.

I have no particular opinion about which exact function does it, but it
_should_ be done `transparently' -- that is any place where a lisp value
is used to compute deeper information (for display or otherwise).

Two important functions for that are `valid_image_p' (called by all
sorts of image-manipulation functions), and `lookup_image' (called by
the display engine).  Both of those call `lookup_image_type', and thus
my placing a call to image-type-validation there.

If I omitted an argument, obviously my change was flawed, but the
location seems reasonable.

-Miles
-- 
We are all lying in the gutter, but some of us are looking at the stars.
-Oscar Wilde

  reply	other threads:[~2004-07-02  7:56 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-06-10 12:38 [PATCH] Delayed loading of image libraries Juanma Barranquero
2004-06-30 10:15 ` Andreas Schwab
2004-06-30 11:13   ` Juanma Barranquero
2004-06-30 11:24     ` Andreas Schwab
2004-06-30 11:34       ` Juanma Barranquero
2004-06-30 11:41         ` Andreas Schwab
2004-06-30 13:00           ` Juanma Barranquero
2004-06-30 15:42         ` Miles Bader
2004-07-01  9:30           ` Juanma Barranquero
2004-07-01  9:48             ` Miles Bader
2004-07-01 10:13               ` Juanma Barranquero
2004-07-02  1:16                 ` Miles Bader
2004-07-02  7:02                   ` Juanma Barranquero
2004-07-02  7:10                     ` David Kastrup
2004-07-02  7:41                       ` Juanma Barranquero
2004-07-02  7:56                         ` Miles Bader [this message]
2004-07-02  8:10                           ` Juanma Barranquero
2004-07-02  8:20                             ` Miles Bader
2004-07-02  8:45                               ` Juanma Barranquero
2004-07-02  8:59                                 ` Miles Bader
2004-07-02  9:02                                   ` Miles Bader
2004-07-02  8:11                         ` David Kastrup
2004-07-02  8:34                           ` Juanma Barranquero
2004-07-03 18:21                     ` Richard Stallman
2004-06-30 14:19       ` Stefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=buosmcaalks.fsf@mctpc71.ucom.lsi.nec.co.jp \
    --to=miles@lsi.nec.co.jp \
    --cc=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=miles@gnu.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).