From: Miles Bader <miles@gnu.org>
To: Chong Yidong <cyd@stupidchicken.com>
Cc: Juri Linkov <juri@jurta.org>,
ams@gnu.org, Stefan Monnier <monnier@iro.umontreal.ca>,
emacs-devel@gnu.org
Subject: Re: C-x C-b and C-x C-f bugging about confirmation
Date: Tue, 25 Nov 2008 13:03:54 +0900 [thread overview]
Message-ID: <buor650v4d1.fsf@dhapc248.dev.necel.com> (raw)
In-Reply-To: <87y6z9k8cj.fsf@cyd.mit.edu> (Chong Yidong's message of "Mon, 24 Nov 2008 00:21:00 -0500")
Patch seems to work well.
I have a few of my own custom completion commands which I'd like to be
treated like`minibuffer-complete' for purposes of confirmation; any
objections to the following additional patch?
Thanks,
-Miles
2008-11-25 Miles Bader <miles@gnu.org>
* minibuffer.el (minibuffer-confirm-exit-commands): New variable.
(minibuffer-complete-and-exit): Use it.
--- orig/lisp/minibuffer.el
+++ mod/lisp/minibuffer.el
@@ -542,6 +542,10 @@
;; through the previous possible completions.
(setq completion-all-sorted-completions (cdr all)))))
+(defvar minibuffer-confirm-exit-commands '(minibuffer-complete)
+ "A list of commands which cause an immediately following
+`minibuffer-complete-and-exit' to ask for extra confirmation.")
+
(defun minibuffer-complete-and-exit ()
"Exit if the minibuffer contains a valid completion.
Otherwise, try to complete the minibuffer contents. If
@@ -595,7 +599,7 @@
((eq minibuffer-completion-confirm 'confirm-after-completion)
;; Similar to the above, but only if trying to exit immediately
;; after typing TAB (this catches most minibuffer typos).
- (if (eq last-command 'minibuffer-complete)
+ (if (memq last-command minibuffer-confirm-exit-commands)
(progn (minibuffer-message "Confirm")
nil)
(exit-minibuffer)))
--
Learning, n. The kind of ignorance distinguishing the studious.
next prev parent reply other threads:[~2008-11-25 4:03 UTC|newest]
Thread overview: 59+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-21 13:33 C-x C-b and C-x C-f bugging about confirmation Alfred M. Szmidt
2008-11-21 14:35 ` Stefan Monnier
2008-11-21 15:46 ` Chong Yidong
2008-11-21 15:51 ` Chong Yidong
2008-11-21 16:08 ` Sam Steingold
2008-11-21 17:07 ` Chong Yidong
2008-11-21 21:23 ` Alan Mackenzie
2008-11-22 16:12 ` Miles Bader
2008-11-21 18:40 ` Eli Zaretskii
2008-11-22 3:23 ` Stefan Monnier
2008-11-22 10:13 ` Eli Zaretskii
2008-11-23 3:39 ` Stefan Monnier
2008-11-23 11:25 ` Eli Zaretskii
2008-11-24 3:08 ` Stefan Monnier
2008-11-24 7:24 ` Stephen J. Turnbull
2008-11-24 15:50 ` Stefan Monnier
2008-11-22 12:18 ` Alfred M. Szmidt
2008-11-22 13:51 ` Ulrich Mueller
2008-11-23 3:50 ` Stefan Monnier
2008-11-22 11:35 ` Alfred M. Szmidt
2008-11-21 18:03 ` Stefan Monnier
2008-11-21 18:51 ` Eli Zaretskii
2008-11-21 19:29 ` Chong Yidong
2008-11-21 23:58 ` Tassilo Horn
2008-11-22 3:30 ` Stefan Monnier
2008-11-22 10:13 ` Eli Zaretskii
2008-11-22 1:54 ` Miles Bader
2008-11-22 7:08 ` mail
2008-11-22 8:24 ` Miles Bader
2008-11-21 18:37 ` Ted Zlatanov
2008-11-22 11:26 ` Alfred M. Szmidt
2008-11-23 3:49 ` Stefan Monnier
2008-11-23 4:44 ` Chong Yidong
2008-11-23 11:24 ` Romain Francoise
2008-11-23 12:45 ` Juri Linkov
2008-11-23 13:45 ` Miles Bader
2008-11-23 15:27 ` Juri Linkov
2008-11-23 22:17 ` Chong Yidong
2008-11-24 3:18 ` Stefan Monnier
2008-11-24 5:21 ` Chong Yidong
2008-11-24 15:52 ` Stefan Monnier
2008-11-24 19:58 ` mail
2008-11-25 4:03 ` Miles Bader [this message]
2008-11-25 15:21 ` Stefan Monnier
2008-11-25 20:09 ` Eli Zaretskii
2008-11-24 11:24 ` Alfred M. Szmidt
2008-11-24 15:56 ` Stefan Monnier
2008-11-24 17:52 ` Alfred M. Szmidt
2008-11-28 18:52 ` Romain Francoise
2008-11-28 19:12 ` Chong Yidong
2008-11-28 21:06 ` Stefan Monnier
2008-11-28 22:27 ` partial-completion-mode (was: C-x C-b and C-x C-f bugging about confirmation) Romain Francoise
2008-11-29 2:48 ` partial-completion-mode Stefan Monnier
2008-11-29 19:44 ` partial-completion-mode Romain Francoise
2008-11-29 20:42 ` partial-completion-mode Stefan Monnier
2008-12-02 12:39 ` C-x C-b and C-x C-f bugging about confirmation Klaus Zeitler
2008-12-02 13:05 ` Tassilo Horn
2008-12-03 12:22 ` Klaus Zeitler
2008-11-22 11:16 ` Gilaras Drakeson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=buor650v4d1.fsf@dhapc248.dev.necel.com \
--to=miles@gnu.org \
--cc=ams@gnu.org \
--cc=cyd@stupidchicken.com \
--cc=emacs-devel@gnu.org \
--cc=juri@jurta.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).