From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: Bold by moving pixels problem Date: 19 Dec 2002 17:34:05 +0900 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20021120220834.GC29543@gnu.org> <200211210133.gAL1XiP23941@rum.cs.yale.edu> <5xfzsvqzqx.fsf@kfs2.cua.dk> Reply-To: Miles Bader NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: main.gmane.org 1040286990 3872 80.91.224.249 (19 Dec 2002 08:36:30 GMT) X-Complaints-To: usenet@main.gmane.org NNTP-Posting-Date: Thu, 19 Dec 2002 08:36:30 +0000 (UTC) Cc: emacs-devel@gnu.org Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by main.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 18OwAP-00010K-00 for ; Thu, 19 Dec 2002 09:36:29 +0100 Original-Received: from monty-python.gnu.org ([199.232.76.173]) by quimby.gnus.org with esmtp (Exim 3.12 #1 (Debian)) id 18OwBR-0005dP-00 for ; Thu, 19 Dec 2002 09:37:33 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18Ow9X-0002sB-02 for emacs-devel@quimby.gnus.org; Thu, 19 Dec 2002 03:35:35 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.10.13) id 18Ow9C-0002qF-00 for emacs-devel@gnu.org; Thu, 19 Dec 2002 03:35:14 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.10.13) id 18Ow9A-0002q3-00 for emacs-devel@gnu.org; Thu, 19 Dec 2002 03:35:13 -0500 Original-Received: from tyo202.gate.nec.co.jp ([202.32.8.202]) by monty-python.gnu.org with esmtp (Exim 4.10.13) id 18Ow99-0002iW-00; Thu, 19 Dec 2002 03:35:11 -0500 Original-Received: from mailgate4.nec.co.jp ([10.7.69.197])gBJ8YIU26800; Thu, 19 Dec 2002 17:34:18 +0900 (JST) Original-Received: from mailsv.nec.co.jp (mailgate51.nec.co.jp [10.7.69.190]) by mailgate4.nec.co.jp (8.11.6/3.7W-MAILGATE-NEC) with ESMTP id gBJ8YIr27066; Thu, 19 Dec 2002 17:34:18 +0900 (JST) Original-Received: from mcsss2.ucom.lsi.nec.co.jp ([10.30.114.133]) by mailsv.nec.co.jp (8.11.6/3.7W-MAILSV-NEC) with ESMTP id gBJ8YBs27183; Thu, 19 Dec 2002 17:34:12 +0900 (JST) Original-Received: from mcspd15.ucom.lsi.nec.co.jp (mcspd15 [10.30.114.174]) id gBJ8YAB08023; Thu, 19 Dec 2002 17:34:10 +0900 (JST) Original-Received: by mcspd15.ucom.lsi.nec.co.jp (Postfix, from userid 31295) id 0F2B43702; Thu, 19 Dec 2002 17:34:05 +0900 (JST) Original-To: storm@cua.dk (Kim F. Storm) System-Type: i686-pc-linux-gnu Blat: Foop In-Reply-To: <5xfzsvqzqx.fsf@kfs2.cua.dk> Original-Lines: 26 Original-cc: bob@rattlesnake.com X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1b5 Precedence: list List-Id: Emacs development discussions. List-Help: List-Post: List-Subscribe: , List-Archive: List-Unsubscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:10272 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:10272 storm@cua.dk (Kim F. Storm) writes: > I've looked at your patch, and it seems to be very low-level to give > the filter functions direct access to the actual lface vector elements. Well, it's a low-level thing... :-) > I'd suggest a different approach using the internal-lisp-face attribute > names that are already defined in xfaces.c such as :family, :height, etc. I agree, code filled with `(aref .. 3)' is not good. Going all the way to a plist seems a bit gratuitous though. What about just providing accessor/setter macros for `lface' vectors, e.g., (lface-weight LFACE) and (set-lface-weight LFACE VAL)? After all the `lface' representation _is_ exposed to lisp already, so such macros might help other code as well. [I'm not sure about the term `lface' though -- it's used fairly pervasively in the C code, but of course that's from the perspective of the C code...] -Miles -- The secret to creativity is knowing how to hide your sources. --Albert Einstein