From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Miles Bader Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Delayed loading of image libraries Date: Fri, 02 Jul 2004 17:20:13 +0900 Sender: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Message-ID: References: <20040702093521.CF34.JMBARRANQUERO@wke.es> <20040702095920.CF37.JMBARRANQUERO@wke.es> Reply-To: Miles Bader NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1088756470 28380 80.91.224.253 (2 Jul 2004 08:21:10 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 2 Jul 2004 08:21:10 +0000 (UTC) Cc: Andreas Schwab , David Kastrup , emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Fri Jul 02 10:20:56 2004 Return-path: Original-Received: from quimby.gnus.org ([80.91.224.244]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1BgJI0-0008DA-00 for ; Fri, 02 Jul 2004 10:20:56 +0200 Original-Received: from lists.gnu.org ([199.232.76.165]) by quimby.gnus.org with esmtp (Exim 3.35 #1 (Debian)) id 1BgJI0-0001qL-00 for ; Fri, 02 Jul 2004 10:20:56 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BgJJo-0000pY-Dg for emacs-devel@quimby.gnus.org; Fri, 02 Jul 2004 04:22:48 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.33) id 1BgJJg-0000nw-QN for emacs-devel@gnu.org; Fri, 02 Jul 2004 04:22:40 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.33) id 1BgJJe-0000nD-QX for emacs-devel@gnu.org; Fri, 02 Jul 2004 04:22:39 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.33) id 1BgJJe-0000ms-Md for emacs-devel@gnu.org; Fri, 02 Jul 2004 04:22:38 -0400 Original-Received: from [202.32.8.214] (helo=TYO201.gate.nec.co.jp) by monty-python.gnu.org with esmtp (Exim 4.34) id 1BgJHf-0004Tj-4H; Fri, 02 Jul 2004 04:20:35 -0400 Original-Received: from mailgate4.nec.co.jp (mailgate54.nec.co.jp [10.7.69.197]) by TYO201.gate.nec.co.jp (8.11.7/3.7W01080315) with ESMTP id i628KKp27489; Fri, 2 Jul 2004 17:20:20 +0900 (JST) Original-Received: (from root@localhost) by mailgate4.nec.co.jp (8.11.7/3.7W-MAILGATE-NEC) id i628KKn20162; Fri, 2 Jul 2004 17:20:20 +0900 (JST) Original-Received: from edsgm01.lsi.nec.co.jp ([10.50.208.11]) by mailsv4.nec.co.jp (8.11.7/3.7W-MAILSV4-NEC) with ESMTP id i628KJq00086; Fri, 2 Jul 2004 17:20:19 +0900 (JST) Original-Received: from mcsss2.ucom.lsi.nec.co.jp (localhost [127.0.0.1]) by edsgm01.lsi.nec.co.jp (8.12.10/8.12.10) with ESMTP id i628KFVL017406; Fri, 2 Jul 2004 17:20:16 +0900 (JST) Original-Received: from mctpc71 (mctpc71.ucom.lsi.nec.co.jp [10.30.118.121]) by mcsss2.ucom.lsi.nec.co.jp (8.12.10/8.12.8/EDcg v2.01-mc/1046780839) with ESMTP id i628KEIm008518; Fri, 2 Jul 2004 17:20:14 +0900 (JST) Original-Received: by mctpc71 (Postfix, from userid 31295) id BB38948D; Fri, 2 Jul 2004 17:20:13 +0900 (JST) Original-To: Juanma Barranquero System-Type: i686-pc-linux-gnu Blat: Foop In-Reply-To: <20040702095920.CF37.JMBARRANQUERO@wke.es> (Juanma Barranquero's message of "Fri, 02 Jul 2004 10:10:56 +0200") Original-Lines: 29 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.4 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+emacs-devel=quimby.gnus.org@gnu.org Xref: main.gmane.org gmane.emacs.devel:25381 X-Report-Spam: http://spam.gmane.org/gmane.emacs.devel:25381 Juanma Barranquero writes: > On Fri, 02 Jul 2004 16:56:51 +0900 > Miles Bader wrote: > >> I have no particular opinion about which exact function does it, but it >> _should_ be done `transparently' -- that is any place where a lisp value >> is used to compute deeper information (for display or otherwise). > > If it is done transparently, what to do when the image type is not > available? You're worried about the case where you write an image and > load it afterwards on the same Emacs, but in the general case, you can > write an (image) lisp value with one Emacs and load it with another > (which could not support the type). What's the expected behaviour at > that point? That seems obvious -- just don't display it. > If my reading of the code is right, when lookup_image_type returns NULL > anything can happen. If lookup_image_type returns null, at least valid_image_p should return 0 (after my change), and many places use that as a guard. Perhaps there are more places checks should be inserted -- but inserting such checks seems like the right thing to do. -Miles -- Is it true that nothing can be known? If so how do we know this? -Woody Allen