From: Miles Bader <miles@lsi.nec.co.jp>
Cc: Andreas Schwab <schwab@suse.de>, David Kastrup <dak@gnu.org>,
emacs-devel@gnu.org
Subject: Re: [PATCH] Delayed loading of image libraries
Date: Fri, 02 Jul 2004 17:20:13 +0900 [thread overview]
Message-ID: <buohdsqakhu.fsf@mctpc71.ucom.lsi.nec.co.jp> (raw)
In-Reply-To: <20040702095920.CF37.JMBARRANQUERO@wke.es> (Juanma Barranquero's message of "Fri, 02 Jul 2004 10:10:56 +0200")
Juanma Barranquero <jmbarranquero@wke.es> writes:
> On Fri, 02 Jul 2004 16:56:51 +0900
> Miles Bader <miles@lsi.nec.co.jp> wrote:
>
>> I have no particular opinion about which exact function does it, but it
>> _should_ be done `transparently' -- that is any place where a lisp value
>> is used to compute deeper information (for display or otherwise).
>
> If it is done transparently, what to do when the image type is not
> available? You're worried about the case where you write an image and
> load it afterwards on the same Emacs, but in the general case, you can
> write an (image) lisp value with one Emacs and load it with another
> (which could not support the type). What's the expected behaviour at
> that point?
That seems obvious -- just don't display it.
> If my reading of the code is right, when lookup_image_type returns NULL
> anything can happen.
If lookup_image_type returns null, at least valid_image_p should return
0 (after my change), and many places use that as a guard. Perhaps there
are more places checks should be inserted -- but inserting such checks
seems like the right thing to do.
-Miles
--
Is it true that nothing can be known? If so how do we know this? -Woody Allen
next prev parent reply other threads:[~2004-07-02 8:20 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-10 12:38 [PATCH] Delayed loading of image libraries Juanma Barranquero
2004-06-30 10:15 ` Andreas Schwab
2004-06-30 11:13 ` Juanma Barranquero
2004-06-30 11:24 ` Andreas Schwab
2004-06-30 11:34 ` Juanma Barranquero
2004-06-30 11:41 ` Andreas Schwab
2004-06-30 13:00 ` Juanma Barranquero
2004-06-30 15:42 ` Miles Bader
2004-07-01 9:30 ` Juanma Barranquero
2004-07-01 9:48 ` Miles Bader
2004-07-01 10:13 ` Juanma Barranquero
2004-07-02 1:16 ` Miles Bader
2004-07-02 7:02 ` Juanma Barranquero
2004-07-02 7:10 ` David Kastrup
2004-07-02 7:41 ` Juanma Barranquero
2004-07-02 7:56 ` Miles Bader
2004-07-02 8:10 ` Juanma Barranquero
2004-07-02 8:20 ` Miles Bader [this message]
2004-07-02 8:45 ` Juanma Barranquero
2004-07-02 8:59 ` Miles Bader
2004-07-02 9:02 ` Miles Bader
2004-07-02 8:11 ` David Kastrup
2004-07-02 8:34 ` Juanma Barranquero
2004-07-03 18:21 ` Richard Stallman
2004-06-30 14:19 ` Stefan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=buohdsqakhu.fsf@mctpc71.ucom.lsi.nec.co.jp \
--to=miles@lsi.nec.co.jp \
--cc=dak@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).